From: Miaohe Lin <linmiaohe@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <ziy@nvidia.com>,
<william.kucharski@oracle.com>, <vbabka@suse.cz>,
<richard.weiyang@linux.alibaba.com>, <peterx@redhat.com>,
<anshuman.khandual@arm.com>, <thomas_os@shipmail.org>,
<rcampbell@nvidia.com>, <aneesh.kumar@linux.ibm.com>,
<yang.shi@linux.alibaba.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>
Subject: Re: [PATCH 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge()
Date: Mon, 15 Mar 2021 10:04:23 +0800 [thread overview]
Message-ID: <641f4d6d-97d2-63a8-c61b-a42f71dcba6c@huawei.com> (raw)
In-Reply-To: <20210313200359.GL2577561@casper.infradead.org>
Hi:
On 2021/3/14 4:03, Matthew Wilcox wrote:
> On Sat, Mar 13, 2021 at 05:32:19AM -0500, Miaohe Lin wrote:
>> +static inline void try_to_split_huge_pmd_address(struct vm_area_struct *vma, unsigned long address)
>> +{
>> + if (address & ~HPAGE_PMD_MASK &&
>> + range_in_vma(vma, address & HPAGE_PMD_MASK,
>> + (address & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE))
>> + split_huge_pmd_address(vma, address, false, NULL);
>> +}
>
> This isn't "try to split". This is "split if needed". I think the
> comments also need to be moved up here.
>
Make sense. Would do it in v2! Thanks!
> I'm not even sure this is really an improvement.
> .
>
At least we can eliminate a couple of duplicated lines and use helper range_in_vma() to improve
the readability slightly. Right? :)
next prev parent reply other threads:[~2021-03-15 2:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 10:32 [PATCH 0/6] Some cleanups for huge_memory Miaohe Lin
2021-03-13 10:32 ` [PATCH 1/6] mm/huge_memory.c: rework the function vma_adjust_trans_huge() Miaohe Lin
2021-03-13 20:03 ` Matthew Wilcox
2021-03-15 2:04 ` Miaohe Lin [this message]
2021-03-13 10:32 ` [PATCH] mm/huge_memory.c: use helper function migration_entry_to_page() Miaohe Lin
2021-03-13 10:36 ` Miaohe Lin
2021-03-13 10:32 ` [PATCH 2/6] mm/huge_memory.c: make get_huge_zero_page() return bool Miaohe Lin
2021-03-13 10:32 ` [PATCH 3/6] mm/huge_memory.c: rework the function do_huge_pmd_numa_page() slightly Miaohe Lin
2021-03-13 10:32 ` [PATCH 4/6] mm/huge_memory.c: remove redundant PageCompound() check Miaohe Lin
2021-03-13 10:32 ` [PATCH 5/6] mm/huge_memory.c: remove unused macro TRANSPARENT_HUGEPAGE_DEBUG_COW_FLAG Miaohe Lin
2021-03-13 10:32 ` [PATCH 6/6] mm/huge_memory.c: use helper function migration_entry_to_page() Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=641f4d6d-97d2-63a8-c61b-a42f71dcba6c@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=thomas_os@shipmail.org \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.