All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@google.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Mark Rutland <mark.rutland@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrey Konovalov <andreyknvl@google.com>,
	James Morse <james.morse@arm.com>,
	Kees Cook <keescook@chromium.org>,
	Bart Van Assche <bart.vanassche@wdc.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
	Zi Yan <zi.yan@cs.rutgers.edu>,
	linux-arm-kernel@lists.infradead.org,
	linux-doc@vger.kernel.orglin
Cc: Jacob Bramley <Jacob.Bramley@arm.com>,
	Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
	Lee Smith <Lee.Smith@arm.com>, Kostya Serebryany <kcc@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
	Evgeniy Stepanov <eugenis@google.com>
Subject: [RFC PATCH v2 1/6] arm64: add type casts to untagged_addr macro
Date: Tue, 27 Mar 2018 18:57:37 +0200	[thread overview]
Message-ID: <64234f64bde32a3f58466a74445848bb7f8cda83.1522169685.git.andreyknvl__9034.82747166908$1522169861$gmane$org@google.com> (raw)
In-Reply-To: <cover.1522169685.git.andreyknvl@google.com>
In-Reply-To: <cover.1522169685.git.andreyknvl@google.com>

This patch makes the untagged_addr macro accept all kinds of address types
(void *, unsigned long, etc.) and allows not to specify type casts in each
place where it is used. This is done by using __typeof__.

Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
 arch/arm64/include/asm/uaccess.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index e66b0fca99c2..2d6451cbaa86 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -102,7 +102,8 @@ static inline unsigned long __range_ok(const void __user *addr, unsigned long si
  * up with a tagged userland pointer. Clear the tag to get a sane pointer to
  * pass on to access_ok(), for instance.
  */
-#define untagged_addr(addr)		sign_extend64(addr, 55)
+#define untagged_addr(addr)		\
+	((__typeof__(addr))sign_extend64((__u64)(addr), 55))
 
 #define access_ok(type, addr, size)	__range_ok(addr, size)
 #define user_addr_max			get_fs
-- 
2.17.0.rc0.231.g781580f067-goog

  parent reply	other threads:[~2018-03-27 16:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 16:57 [RFC PATCH v2 0/6] arm64: untag user pointers passed to the kernel Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57 ` [RFC PATCH v2 1/6] arm64: add type casts to untagged_addr macro Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov [this message]
2018-03-27 16:57 ` [RFC PATCH v2 2/6] uaccess: add untagged_addr definition for other arches Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57 ` [RFC PATCH v2 3/6] arm64: untag user addresses in copy_from_user and others Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57 ` [RFC PATCH v2 4/6] mm, arm64: untag user addresses in mm/gup.c Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57 ` [RFC PATCH v2 5/6] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user Andrey Konovalov
2018-03-27 16:57 ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57 ` [RFC PATCH v2 6/6] arm64: update Documentation/arm64/tagged-pointers.txt Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov
2018-03-27 16:57   ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='64234f64bde32a3f58466a74445848bb7f8cda83.1522169685.git.andreyknvl__9034.82747166908$1522169861$gmane$org@google.com' \
    --to=andreyknvl@google.com \
    --cc=Jacob.Bramley@arm.com \
    --cc=Lee.Smith@arm.com \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Ruben.Ayrapetyan@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=bart.vanassche@wdc.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=dvyukov@google.com \
    --cc=eugenis@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=james.morse@arm.com \
    --cc=kcc@google.com \
    --cc=keescook@chromium.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.orglin \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=robin.murphy@arm.com \
    --cc=tglx@linutronix.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=zi.yan@cs.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.