From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Subject: Re: [PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus
 4xx
Date: Mon, 21 May 2018 15:17:09 +0300
Message-ID: <642a4a69-70fb-c72d-5700-1c55755d3073@linaro.org>
References: <20180515075859.17217-1-stanimir.varbanov@linaro.org>
 <20180515075859.17217-8-stanimir.varbanov@linaro.org>
 <CAAFQd5Ck1x1voV3=G_3yJEh_0S-4kYkx13P00kyMRbhJ4=sSCA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <CAAFQd5Ck1x1voV3=G_3yJEh_0S-4kYkx13P00kyMRbhJ4=sSCA@mail.gmail.com>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
To: Tomasz Figa <tfiga@google.com>, Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>, Linux Media Mailing List <linux-media@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, vgarodia@codeaurora.org
List-Id: linux-arm-msm@vger.kernel.org

Hi Tomasz,

On 05/18/2018 05:23 PM, Tomasz Figa wrote:
> On Tue, May 15, 2018 at 5:12 PM Stanimir Varbanov <
> stanimir.varbanov@linaro.org> wrote:
> 
>> Add AXI halt support for version 4xx by using venus wrapper
>> registers.
> 
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>>   drivers/media/platform/qcom/venus/hfi_venus.c | 17 +++++++++++++++++
>>   1 file changed, 17 insertions(+)
> 
>> diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c
> b/drivers/media/platform/qcom/venus/hfi_venus.c
>> index 734ce11b0ed0..53546174aab8 100644
>> --- a/drivers/media/platform/qcom/venus/hfi_venus.c
>> +++ b/drivers/media/platform/qcom/venus/hfi_venus.c
>> @@ -532,6 +532,23 @@ static int venus_halt_axi(struct venus_hfi_device
> *hdev)
>>          u32 val;
>>          int ret;
> 
>> +       if (hdev->core->res->hfi_version == HFI_VERSION_4XX) {
>> +               val = venus_readl(hdev, WRAPPER_CPU_AXI_HALT);
>> +               val |= BIT(16);
> 
> Can we have the bit defined?
> 
>> +               venus_writel(hdev, WRAPPER_CPU_AXI_HALT, val);
>> +
>> +               ret = readl_poll_timeout(base +
> WRAPPER_CPU_AXI_HALT_STATUS,
>> +                                        val, val & BIT(24),
> 
> Ditto.

Sure will add defines.

-- 
regards,
Stan