From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Paul Durrant <Paul.Durrant@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Jan Beulich <JBeulich@suse.com>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH] x86/msr: Fix fallout from mostly c/s 832c180
Date: Thu, 11 Apr 2019 19:28:25 +0100 [thread overview]
Message-ID: <642bdef3-dead-2306-2f2f-35108586ee7d@citrix.com> (raw)
In-Reply-To: <1554884886189.62867@citrix.com>
On 10/04/2019 09:28, Paul Durrant wrote:
> Again, digging back in mail...
>
> -----
> [From Jan]
>> + case MSR_IA32_BNDCFGS:
>> + if ( !is_hvm_domain(d) || !cp->feat.mpx ||
>> + !hvm_set_guest_bndcfgs(v, val) )
>> + goto gp_fault;
> In both cases the is_hvm_*() check looks to be redundant, as
> for PV guests cp->feat.mpx can't be set. Personally I'd prefer
> this to be an ASSERT() instead, but I'd listen to Andrew (as
> the main author of this code) saying otherwise.
In this case, the compiler/linkers opinion in the shim build does
provide a very clear answer. The check is not redundant and must remain.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-04-11 18:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 17:53 [PATCH] x86/msr: Fix fallout from mostly c/s 832c180 Andrew Cooper
2019-04-10 8:23 ` Wei Liu
2019-04-10 9:41 ` Andrew Cooper
2019-04-10 10:23 ` Wei Liu
2019-04-10 8:28 ` Paul Durrant
2019-04-10 8:39 ` Paul Durrant
2019-04-11 18:28 ` Andrew Cooper [this message]
2019-04-10 10:24 ` Jan Beulich
2019-04-11 18:20 ` Andrew Cooper
2019-04-12 10:46 ` Jan Beulich
2019-04-12 11:00 ` Paul Durrant
2019-04-12 11:19 ` Jan Beulich
2019-04-12 13:52 ` Andrew Cooper
2019-04-12 14:57 ` Jan Beulich
2019-04-15 9:03 ` Wei Liu
2019-04-15 9:29 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642bdef3-dead-2306-2f2f-35108586ee7d@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=Paul.Durrant@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.