On 5/17/19 5:45 PM, John Snow wrote: > > > On 5/17/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add new optional parameter making possible to merge bitmaps from >> different nodes. It is needed to maintain external snapshots during >> incremental backup chain history. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> +# Since: 4.1 >> +## >> +{ 'alternate': 'BlockDirtyBitmapMergeSource', >> + 'data': { 'local': 'str', >> + 'external': 'BlockDirtyBitmap' } } >> + > > We might be able to use something more generic to name this type of > thing, but I think such changes are wire compatible, so we can rename it > to be more generic if we decide to use this for something else in the > future, so this is good. Correct - type names are not API, so we can rename them later if it makes sense. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org