From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Cc: Guo Jin <guoj17@chinatelecom.cn>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
x86@kernel.org
Subject: Re: [tip: locking/urgent] locking: Fix qspinlock/x86 inline asm error
Date: Wed, 16 Nov 2022 10:40:10 +0100 [thread overview]
Message-ID: <64372250-a413-076e-3b6d-2d263ee9c7f2@suse.com> (raw)
In-Reply-To: <166859051534.4906.7078966677789928700.tip-bot2@tip-bot2>
[-- Attachment #1.1.1: Type: text/plain, Size: 1572 bytes --]
On 16.11.22 10:21, tip-bot2 for Guo Jin wrote:
> The following commit has been merged into the locking/urgent branch of tip:
>
> Commit-ID: 23df39fc6a36183af5e6e4f47523f1ad2cdc1d30
> Gitweb: https://git.kernel.org/tip/23df39fc6a36183af5e6e4f47523f1ad2cdc1d30
> Author: Guo Jin <guoj17@chinatelecom.cn>
> AuthorDate: Tue, 08 Nov 2022 14:01:26 +08:00
> Committer: Peter Zijlstra <peterz@infradead.org>
> CommitterDate: Wed, 16 Nov 2022 10:18:09 +01:00
>
> locking: Fix qspinlock/x86 inline asm error
>
> When compiling linux 6.1.0-rc3 configured with CONFIG_64BIT=y and
> CONFIG_PARAVIRT_SPINLOCKS=y on x86_64 using LLVM 11.0, an error:
> "<inline asm> error: changed section flags for .spinlock.text,
> expected:: 0x6" occurred.
>
> The reason is the .spinlock.text in kernel/locking/qspinlock.o
> is used many times, but its flags are omitted in subsequent use.
>
> LLVM 11.0 assembler didn't permit to
> leave out flags in subsequent uses of the same sections.
>
> So this patch adds the corresponding flags to avoid above error.
>
> Fixes: 501f7f69bca1 ("locking: Add __lockfunc to slow path functions")
> Signed-off-by: Guo Jin <guoj17@chinatelecom.cn>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> Link: https://lore.kernel.org/r/20221108060126.2505-1-guoj17@chinatelecom.cn
Wouldn't it be better to take my more generic patch [1] instead?
[1]: https://lore.kernel.org/lkml/20221109134418.6516-1-jgross@suse.com/
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2022-11-16 9:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 6:01 [PATCH] locking: fix kernel/locking/ inline asm error guoj17
2022-11-08 22:40 ` Nathan Chancellor
2022-11-10 10:05 ` 回复: " huyd12
2022-11-10 20:50 ` Nathan Chancellor
2022-11-16 9:21 ` [tip: locking/urgent] locking: Fix qspinlock/x86 " tip-bot2 for Guo Jin
2022-11-16 9:40 ` Juergen Gross [this message]
2022-11-16 10:39 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64372250-a413-076e-3b6d-2d263ee9c7f2@suse.com \
--to=jgross@suse.com \
--cc=guoj17@chinatelecom.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.