All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Chew <AChew@nvidia.com>
To: "'Guennadi Liakhovetski'" <g.liakhovetski@gmx.de>
Cc: "mchehab@redhat.com" <mchehab@redhat.com>,
	"olof@lixom.net" <olof@lixom.net>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/5 v2] [media] ov9740: Fixed some settings
Date: Tue, 31 May 2011 18:12:20 -0700	[thread overview]
Message-ID: <643E69AA4436674C8F39DCC2C05F76382A75BF37C2@HQMAIL03.nvidia.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105291218250.18788@axis700.grange>

> > +	{ OV9740_MIPI_CTRL00,		0x64 }, /* 0x44 for 
> continuous clock */
> 
> I think, the choice between continuous and discontinuous CSI-2 clock 
> should become configurable. You can only use discontinuous clock with 
> hosts, that support it, right? Whereas all hosts must support 
> continuous 
> clock. So, I'm not sure we should unconditionally switch to 
> discontinuous 
> clock here... Maybe it's better to keep it continuous until 
> we make it 
> configurable?

Yes, that's right.  The camera host needs to support discontinuous clocks.  I'll change it back to continuous clock by default, and change the comment to "0x64 for discontinuous clock", so we remember for when this becomes configurable.

  reply	other threads:[~2011-06-01  1:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  0:04 [PATCH 1/5 v2] [media] ov9740: Cleanup hex casing inconsistencies achew
2011-05-26  0:04 ` [PATCH 2/5 v2] [media] ov9740: Correct print in ov9740_reg_rmw() achew
2011-05-26  0:04 ` [PATCH 3/5 v2] [media] ov9740: Fixed some settings achew
2011-05-29 10:21   ` Guennadi Liakhovetski
2011-06-01  1:12     ` Andrew Chew [this message]
2011-05-26  0:04 ` [PATCH 4/5 v2] [media] ov9740: Remove hardcoded resolution regs achew
2011-05-29 10:36   ` Guennadi Liakhovetski
2011-06-01  1:50     ` Andrew Chew
2011-06-01 19:35       ` Guennadi Liakhovetski
2011-05-26  0:04 ` [PATCH 5/5 v2] [media] ov9740: Add suspend/resume achew
2011-05-29 10:58   ` Guennadi Liakhovetski
2011-06-01  1:58     ` Andrew Chew
2011-06-01 19:51       ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=643E69AA4436674C8F39DCC2C05F76382A75BF37C2@HQMAIL03.nvidia.com \
    --to=achew@nvidia.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=olof@lixom.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.