From: Michael Nosthoff via buildroot <buildroot@busybox.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Michael Nosthoff via buildroot <buildroot@busybox.net>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/boost: bump version to 1.77.0
Date: Wed, 18 Aug 2021 22:38:15 +0200 [thread overview]
Message-ID: <643f3f7d-7c72-810b-eb27-c639e683dd8d@heine.tech> (raw)
In-Reply-To: <20210818122324.7daa3258@windsurf>
Hi Thomas,
On 18.08.21 12:23, Thomas Petazzoni wrote:
> Hello Michael,
>
> On Tue, 17 Aug 2021 22:01:39 +0200
> Michael Nosthoff via buildroot <buildroot@busybox.net> wrote:
>
>> config BR2_PACKAGE_BOOST_FILESYSTEM
>> bool "boost-filesystem"
>> + depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-atomic
> Unfortunately, if you add such a dependency, you need to look at all
> the place where you have a "select BR2_PACKAGE_BOOST_FILESYSTEM" or a
> "select BR2_PACKAGE_BOOST_ATOMIC" and make sure they have a "depends on
> BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS". And recursively,
> any package selecting those packages will also need to have this
> "depends on" added.
Damn, I forgot those dependencies. Fabrice added them for atomic and
thread before.
It's not nice but it seems to be necessary since the dependency is now
there.
>
> For example: package/cc-tool/Config.in selects
> BR2_PACKAGE_BOOST_FILESYSTEM, so it now needs to have this depends on
> BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS.
>
> In other words, if you can get a fix for this, it would make this
> version bump a lot simpler :-)
The culprit is this commit [1]. So if c++20 is not available it always
falls back on boost-atomic.
From the sheer size of the commit I don't think we can "fix" this from
buildroot in a sensible way.
Luckily no packages depend on boost-math, where I hope this dependency
can be fixed/removed.
Regards,
Michael
[1]
https://github.com/boostorg/filesystem/commit/2dda038306fd2953c2bbd01a15795994fbc32af2
>
> Thanks!
>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-18 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 20:01 [Buildroot] [PATCH] package/boost: bump version to 1.77.0 Michael Nosthoff via buildroot
2021-08-18 10:23 ` Thomas Petazzoni
2021-08-18 20:38 ` Michael Nosthoff via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=643f3f7d-7c72-810b-eb27-c639e683dd8d@heine.tech \
--to=buildroot@busybox.net \
--cc=buildroot@buildroot.org \
--cc=buildroot@heine.tech \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.