From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH libdrm 03/10] xf86drm: Fold drmDevice processing into process_device() helper Date: Thu, 28 Jun 2018 13:50:48 +0200 Message-ID: <643f4626-20fd-8801-e266-3e27ff18704e@collabora.com> References: <20180625173626.8046-1-emil.l.velikov@gmail.com> <20180625173626.8046-3-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 998936ED12 for ; Thu, 28 Jun 2018 11:50:52 +0000 (UTC) In-Reply-To: <20180625173626.8046-3-emil.l.velikov@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RmVlbCBmcmVlIHRvIGFkZCBteSByLWIgdG8gdGhpcyBwYXRjaC4KCk9uIDIwMTgtMDYtMjUgMTk6 MzYsIEVtaWwgVmVsaWtvdiB3cm90ZToKPiBGcm9tOiBFbWlsIFZlbGlrb3YgPGVtaWwudmVsaWtv dkBjb2xsYWJvcmEuY29tPgo+IAo+IERvbid0IHRoZSBkdXBsaWNhdGUgKG5lYXJseSkgaWRlbnRp Y2FsIGNvZGUgYWNyb3NzIHRoZSB0d28gY2FsbCBzaXRlcy4KPiBJdCBpbXByb3ZlcyBsZWdpYmls aXR5IGFuZCB0aGUgZGlmZiBzdGF0IHNlZW1zIG5pY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogRW1p bCBWZWxpa292IDxlbWlsLnZlbGlrb3ZAY29sbGFib3JhLmNvbT4KPiAtLS0KPiAgIHhmODZkcm0u YyB8IDE1OSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAxMDggZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL3hmODZkcm0uYyBiL3hmODZkcm0uYwo+IGluZGV4IGNiYzBh NDA4Li4xMTRjZjg1NSAxMDA2NDQKPiAtLS0gYS94Zjg2ZHJtLmMKPiArKysgYi94Zjg2ZHJtLmMK PiBAQCAtMzY3Niw2ICszNjc2LDUyIEBAIGZyZWVfZGV2aWNlOgo+ICAgICAgIHJldHVybiByZXQ7 Cj4gICB9Cj4gICAKPiArc3RhdGljIGludAo+ICtwcm9jZXNzX2RldmljZShkcm1EZXZpY2VQdHIg KmRldmljZSwgY29uc3QgY2hhciAqZF9uYW1lLAo+ICsgICAgICAgICAgICAgICBpbnQgcmVxX3N1 YnN5c3RlbV90eXBlLAo+ICsgICAgICAgICAgICAgICBib29sIGZldGNoX2RldmljZWluZm8sIHVp bnQzMl90IGZsYWdzKQo+ICt7Cj4gKyAgICBzdHJ1Y3Qgc3RhdCBzYnVmOwo+ICsgICAgY2hhciBu b2RlW1BBVEhfTUFYICsgMV07Cj4gKyAgICBpbnQgbm9kZV90eXBlLCBzdWJzeXN0ZW1fdHlwZTsK PiArICAgIHVuc2lnbmVkIGludCBtYWosIG1pbjsKPiArCj4gKyAgICBub2RlX3R5cGUgPSBkcm1H ZXROb2RlVHlwZShkX25hbWUpOwo+ICsgICAgaWYgKG5vZGVfdHlwZSA8IDApCj4gKyAgICAgICAg cmV0dXJuIC0xOwo+ICsKPiArICAgIHNucHJpbnRmKG5vZGUsIFBBVEhfTUFYLCAiJXMvJXMiLCBE Uk1fRElSX05BTUUsIGRfbmFtZSk7Cj4gKyAgICBpZiAoc3RhdChub2RlLCAmc2J1ZikpCj4gKyAg ICAgICAgcmV0dXJuIC0xOwo+ICsKPiArICAgIG1haiA9IG1ham9yKHNidWYuc3RfcmRldik7Cj4g KyAgICBtaW4gPSBtaW5vcihzYnVmLnN0X3JkZXYpOwo+ICsKPiArICAgIGlmIChtYWogIT0gRFJN X01BSk9SIHx8ICFTX0lTQ0hSKHNidWYuc3RfbW9kZSkpCj4gKyAgICAgICAgcmV0dXJuIC0xOwo+ ICsKPiArICAgIHN1YnN5c3RlbV90eXBlID0gZHJtUGFyc2VTdWJzeXN0ZW1UeXBlKG1haiwgbWlu KTsKPiArICAgIGlmIChyZXFfc3Vic3lzdGVtX3R5cGUgIT0gLTEgJiYgcmVxX3N1YnN5c3RlbV90 eXBlICE9IHN1YnN5c3RlbV90eXBlKQo+ICsgICAgICAgIHJldHVybiAtMTsKPiArCj4gKyAgICBz d2l0Y2ggKHN1YnN5c3RlbV90eXBlKSB7Cj4gKyAgICBjYXNlIERSTV9CVVNfUENJOgo+ICsgICAg ICAgIHJldHVybiBkcm1Qcm9jZXNzUGNpRGV2aWNlKGRldmljZSwgbm9kZSwgbm9kZV90eXBlLCBt YWosIG1pbiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmZXRjaF9kZXZp Y2VpbmZvLCBmbGFncyk7Cj4gKyAgICBjYXNlIERSTV9CVVNfVVNCOgo+ICsgICAgICAgIHJldHVy biBkcm1Qcm9jZXNzVXNiRGV2aWNlKGRldmljZSwgbm9kZSwgbm9kZV90eXBlLCBtYWosIG1pbiwK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmZXRjaF9kZXZpY2VpbmZvLCBm bGFncyk7Cj4gKyAgICBjYXNlIERSTV9CVVNfUExBVEZPUk06Cj4gKyAgICAgICAgcmV0dXJuIGRy bVByb2Nlc3NQbGF0Zm9ybURldmljZShkZXZpY2UsIG5vZGUsIG5vZGVfdHlwZSwgbWFqLCBtaW4s Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmZXRjaF9kZXZpY2Vp bmZvLCBmbGFncyk7Cj4gKyAgICBjYXNlIERSTV9CVVNfSE9TVDFYOgo+ICsgICAgICAgIHJldHVy biBkcm1Qcm9jZXNzSG9zdDF4RGV2aWNlKGRldmljZSwgbm9kZSwgbm9kZV90eXBlLCBtYWosIG1p biwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmZXRjaF9kZXZpY2Vp bmZvLCBmbGFncyk7Cj4gKyAgICBkZWZhdWx0Ogo+ICsgICAgICAgIHJldHVybiAtMTsKPiArICAg fQo+ICt9Cj4gKwo+ICAgLyogQ29uc2lkZXIgZGV2aWNlcyBsb2NhdGVkIG9uIHRoZSBzYW1lIGJ1 cyBhcyBkdXBsaWNhdGUgYW5kIGZvbGQgdGhlIHJlc3BlY3RpdmUKPiAgICAqIGVudHJpZXMgaW50 byBhIHNpbmdsZSBvbmUuCj4gICAgKgo+IEBAIC0zODA1LDggKzM4NTEsNyBAQCBpbnQgZHJtR2V0 RGV2aWNlMihpbnQgZmQsIHVpbnQzMl90IGZsYWdzLCBkcm1EZXZpY2VQdHIgKmRldmljZSkKPiAg ICAgICBESVIgKnN5c2RpcjsKPiAgICAgICBzdHJ1Y3QgZGlyZW50ICpkZW50Owo+ICAgICAgIHN0 cnVjdCBzdGF0IHNidWY7Cj4gLSAgICBjaGFyIG5vZGVbUEFUSF9NQVggKyAxXTsKPiAtICAgIGlu dCBub2RlX3R5cGUsIHN1YnN5c3RlbV90eXBlOwo+ICsgICAgaW50IHN1YnN5c3RlbV90eXBlOwo+ ICAgICAgIGludCBtYWosIG1pbjsKPiAgICAgICBpbnQgcmV0LCBpLCBub2RlX2NvdW50Owo+ICAg ICAgIGludCBtYXhfY291bnQgPSAxNjsKPiBAQCAtMzg0NCw1NSArMzg4OSw5IEBAIGludCBkcm1H ZXREZXZpY2UyKGludCBmZCwgdWludDMyX3QgZmxhZ3MsIGRybURldmljZVB0ciAqZGV2aWNlKQo+ ICAgCj4gICAgICAgaSA9IDA7Cj4gICAgICAgd2hpbGUgKChkZW50ID0gcmVhZGRpcihzeXNkaXIp KSkgewo+IC0gICAgICAgIG5vZGVfdHlwZSA9IGRybUdldE5vZGVUeXBlKGRlbnQtPmRfbmFtZSk7 Cj4gLSAgICAgICAgaWYgKG5vZGVfdHlwZSA8IDApCj4gLSAgICAgICAgICAgIGNvbnRpbnVlOwo+ IC0KPiAtICAgICAgICBzbnByaW50Zihub2RlLCBQQVRIX01BWCwgIiVzLyVzIiwgRFJNX0RJUl9O QU1FLCBkZW50LT5kX25hbWUpOwo+IC0gICAgICAgIGlmIChzdGF0KG5vZGUsICZzYnVmKSkKPiAt ICAgICAgICAgICAgY29udGludWU7Cj4gLQo+IC0gICAgICAgIG1haiA9IG1ham9yKHNidWYuc3Rf cmRldik7Cj4gLSAgICAgICAgbWluID0gbWlub3Ioc2J1Zi5zdF9yZGV2KTsKPiAtCj4gLSAgICAg ICAgaWYgKG1haiAhPSBEUk1fTUFKT1IgfHwgIVNfSVNDSFIoc2J1Zi5zdF9tb2RlKSkKPiAtICAg ICAgICAgICAgY29udGludWU7Cj4gLQo+IC0gICAgICAgIGlmIChkcm1QYXJzZVN1YnN5c3RlbVR5 cGUobWFqLCBtaW4pICE9IHN1YnN5c3RlbV90eXBlKQo+IC0gICAgICAgICAgICBjb250aW51ZTsK PiAtCj4gLSAgICAgICAgc3dpdGNoIChzdWJzeXN0ZW1fdHlwZSkgewo+IC0gICAgICAgIGNhc2Ug RFJNX0JVU19QQ0k6Cj4gLSAgICAgICAgICAgIHJldCA9IGRybVByb2Nlc3NQY2lEZXZpY2UoJmQs IG5vZGUsIG5vZGVfdHlwZSwgbWFqLCBtaW4sIHRydWUsIGZsYWdzKTsKPiAtICAgICAgICAgICAg aWYgKHJldCkKPiAtICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+IC0KPiAtICAgICAgICAgICAg YnJlYWs7Cj4gLQo+IC0gICAgICAgIGNhc2UgRFJNX0JVU19VU0I6Cj4gLSAgICAgICAgICAgIHJl dCA9IGRybVByb2Nlc3NVc2JEZXZpY2UoJmQsIG5vZGUsIG5vZGVfdHlwZSwgbWFqLCBtaW4sIHRy dWUsIGZsYWdzKTsKPiAtICAgICAgICAgICAgaWYgKHJldCkKPiAtICAgICAgICAgICAgICAgIGNv bnRpbnVlOwo+IC0KPiAtICAgICAgICAgICAgYnJlYWs7Cj4gLQo+IC0gICAgICAgIGNhc2UgRFJN X0JVU19QTEFURk9STToKPiAtICAgICAgICAgICAgcmV0ID0gZHJtUHJvY2Vzc1BsYXRmb3JtRGV2 aWNlKCZkLCBub2RlLCBub2RlX3R5cGUsIG1haiwgbWluLCB0cnVlLCBmbGFncyk7Cj4gLSAgICAg ICAgICAgIGlmIChyZXQpCj4gLSAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAtCj4gLSAgICAg ICAgICAgIGJyZWFrOwo+IC0KPiAtICAgICAgICBjYXNlIERSTV9CVVNfSE9TVDFYOgo+IC0gICAg ICAgICAgICByZXQgPSBkcm1Qcm9jZXNzSG9zdDF4RGV2aWNlKCZkLCBub2RlLCBub2RlX3R5cGUs IG1haiwgbWluLCB0cnVlLCBmbGFncyk7Cj4gLSAgICAgICAgICAgIGlmIChyZXQpCj4gLSAgICAg ICAgICAgICAgICBjb250aW51ZTsKPiAtCj4gLSAgICAgICAgICAgIGJyZWFrOwo+IC0KPiAtICAg ICAgICBkZWZhdWx0Ogo+ICsgICAgICAgIHJldCA9IHByb2Nlc3NfZGV2aWNlKCZkLCBkZW50LT5k X25hbWUsIHN1YnN5c3RlbV90eXBlLCB0cnVlLCBmbGFncyk7Cj4gKyAgICAgICAgaWYgKHJldCkK PiAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+IC0gICAgICAgIH0KPiAgIAo+ICAgICAgICAgICBp ZiAoaSA+PSBtYXhfY291bnQpIHsKPiAgICAgICAgICAgICAgIGRybURldmljZVB0ciAqdGVtcDsK PiBAQCAtMzk3MywxMCArMzk3Miw2IEBAIGludCBkcm1HZXREZXZpY2VzMih1aW50MzJfdCBmbGFn cywgZHJtRGV2aWNlUHRyIGRldmljZXNbXSwgaW50IG1heF9kZXZpY2VzKQo+ICAgICAgIGRybURl dmljZVB0ciBkZXZpY2U7Cj4gICAgICAgRElSICpzeXNkaXI7Cj4gICAgICAgc3RydWN0IGRpcmVu dCAqZGVudDsKPiAtICAgIHN0cnVjdCBzdGF0IHNidWY7Cj4gLSAgICBjaGFyIG5vZGVbUEFUSF9N QVggKyAxXTsKPiAtICAgIGludCBub2RlX3R5cGUsIHN1YnN5c3RlbV90eXBlOwo+IC0gICAgaW50 IG1haiwgbWluOwo+ICAgICAgIGludCByZXQsIGksIG5vZGVfY291bnQsIGRldmljZV9jb3VudDsK PiAgICAgICBpbnQgbWF4X2NvdW50ID0gMTY7Cj4gICAKPiBAQCAtMzk5NSw2MSArMzk5MCw5IEBA IGludCBkcm1HZXREZXZpY2VzMih1aW50MzJfdCBmbGFncywgZHJtRGV2aWNlUHRyIGRldmljZXNb XSwgaW50IG1heF9kZXZpY2VzKQo+ICAgCj4gICAgICAgaSA9IDA7Cj4gICAgICAgd2hpbGUgKChk ZW50ID0gcmVhZGRpcihzeXNkaXIpKSkgewo+IC0gICAgICAgIG5vZGVfdHlwZSA9IGRybUdldE5v ZGVUeXBlKGRlbnQtPmRfbmFtZSk7Cj4gLSAgICAgICAgaWYgKG5vZGVfdHlwZSA8IDApCj4gLSAg ICAgICAgICAgIGNvbnRpbnVlOwo+IC0KPiAtICAgICAgICBzbnByaW50Zihub2RlLCBQQVRIX01B WCwgIiVzLyVzIiwgRFJNX0RJUl9OQU1FLCBkZW50LT5kX25hbWUpOwo+IC0gICAgICAgIGlmIChz dGF0KG5vZGUsICZzYnVmKSkKPiAtICAgICAgICAgICAgY29udGludWU7Cj4gLQo+IC0gICAgICAg IG1haiA9IG1ham9yKHNidWYuc3RfcmRldik7Cj4gLSAgICAgICAgbWluID0gbWlub3Ioc2J1Zi5z dF9yZGV2KTsKPiAtCj4gLSAgICAgICAgaWYgKG1haiAhPSBEUk1fTUFKT1IgfHwgIVNfSVNDSFIo c2J1Zi5zdF9tb2RlKSkKPiAtICAgICAgICAgICAgY29udGludWU7Cj4gLQo+IC0gICAgICAgIHN1 YnN5c3RlbV90eXBlID0gZHJtUGFyc2VTdWJzeXN0ZW1UeXBlKG1haiwgbWluKTsKPiAtCj4gLSAg ICAgICAgaWYgKHN1YnN5c3RlbV90eXBlIDwgMCkKPiAtICAgICAgICAgICAgY29udGludWU7Cj4g LQo+IC0gICAgICAgIHN3aXRjaCAoc3Vic3lzdGVtX3R5cGUpIHsKPiAtICAgICAgICBjYXNlIERS TV9CVVNfUENJOgo+IC0gICAgICAgICAgICByZXQgPSBkcm1Qcm9jZXNzUGNpRGV2aWNlKCZkZXZp Y2UsIG5vZGUsIG5vZGVfdHlwZSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtYWosIG1pbiwgZGV2aWNlcyAhPSBOVUxMLCBmbGFncyk7Cj4gLSAgICAgICAgICAgIGlm IChyZXQpCj4gLSAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAtCj4gLSAgICAgICAgICAgIGJy ZWFrOwo+IC0KPiAtICAgICAgICBjYXNlIERSTV9CVVNfVVNCOgo+IC0gICAgICAgICAgICByZXQg PSBkcm1Qcm9jZXNzVXNiRGV2aWNlKCZkZXZpY2UsIG5vZGUsIG5vZGVfdHlwZSwgbWFqLCBtaW4s Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2aWNlcyAhPSBOVUxM LCBmbGFncyk7Cj4gLSAgICAgICAgICAgIGlmIChyZXQpCj4gLSAgICAgICAgICAgICAgICBjb250 aW51ZTsKPiAtCj4gLSAgICAgICAgICAgIGJyZWFrOwo+IC0KPiAtICAgICAgICBjYXNlIERSTV9C VVNfUExBVEZPUk06Cj4gLSAgICAgICAgICAgIHJldCA9IGRybVByb2Nlc3NQbGF0Zm9ybURldmlj ZSgmZGV2aWNlLCBub2RlLCBub2RlX3R5cGUsIG1haiwgbWluLAo+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2aWNlcyAhPSBOVUxMLCBmbGFncyk7Cj4gLSAg ICAgICAgICAgIGlmIChyZXQpCj4gLSAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAtCj4gLSAg ICAgICAgICAgIGJyZWFrOwo+IC0KPiAtICAgICAgICBjYXNlIERSTV9CVVNfSE9TVDFYOgo+IC0g ICAgICAgICAgICByZXQgPSBkcm1Qcm9jZXNzSG9zdDF4RGV2aWNlKCZkZXZpY2UsIG5vZGUsIG5v ZGVfdHlwZSwgbWFqLCBtaW4sCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZGV2aWNlcyAhPSBOVUxMLCBmbGFncyk7Cj4gLSAgICAgICAgICAgIGlmIChyZXQpCj4g LSAgICAgICAgICAgICAgICBjb250aW51ZTsKPiAtCj4gLSAgICAgICAgICAgIGJyZWFrOwo+IC0K PiAtICAgICAgICBkZWZhdWx0Ogo+ICsgICAgICAgIHJldCA9IHByb2Nlc3NfZGV2aWNlKCZkZXZp Y2UsIGRlbnQtPmRfbmFtZSwgLTEsIGRldmljZXMgIT0gTlVMTCwgZmxhZ3MpOwo+ICsgICAgICAg IGlmIChyZXQpCj4gICAgICAgICAgICAgICBjb250aW51ZTsKPiAtICAgICAgICB9Cj4gICAKPiAg ICAgICAgICAgaWYgKGkgPj0gbWF4X2NvdW50KSB7Cj4gICAgICAgICAgICAgICBkcm1EZXZpY2VQ dHIgKnRlbXA7Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=