Re: [External] Re: [PATCH v3] ACPI: platform-profile: Add platform profile support

From: Hans de Goede <hdegoede@redhat.com>
To: "Bastien Nocera" <hadess@hadess.net>,
	"Mark Pearson" <markpearson@lenovo.com>,
	"Barnabás Pőcze" <pobrn@protonmail.com>
Cc: "rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"mgross@linux.intel.com" <mgross@linux.intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"mario.limonciello@dell.com" <mario.limonciello@dell.com>,
	"eliadevito@gmail.com" <eliadevito@gmail.com>,
	"bberg@redhat.com" <bberg@redhat.com>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"dvhart@infradead.org" <dvhart@infradead.org>
Subject: Re: [External] Re: [PATCH v3] ACPI: platform-profile: Add platform profile support
Date: Thu, 26 Nov 2020 11:36:23 +0100	[thread overview]
Message-ID: <64447d3f-c328-aef2-cd29-a9eed10ff27e@redhat.com> (raw)
In-Reply-To: <2207fea9195877a7ac6d6d203d9f81d07362a80f.camel@hadess.net>

Hi,

On 11/25/20 11:32 PM, Bastien Nocera wrote:
> On Wed, 2020-11-25 at 14:41 -0500, Mark Pearson wrote:
>> On 25/11/2020 11:42, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 11/24/20 4:30 PM, Bastien Nocera wrote:
>>>> On Sat, 2020-11-21 at 15:27 +0100, Hans de Goede wrote:
>>>>> Hi,
>>>>> On 11/20/20 8:50 PM, Barnabás Pőcze wrote:
>>>>>> Hi
>>>>>> 2020. november 15., vasárnap 1:44 keltezéssel, Mark Pearson
>>>>>> írta:
>>>>>>
>>>>> Bastien, what do you think about Barnabás' suggestion to always
>>>>> have the files present and use poll (POLL_PRI) on it to see
>>>>> when
>>>>> it changes, listing maybe "none" as available profiles when
>>>>> there
>>>>> is no provider?
>>>>
>>>> Whether the file exists or doesn't, we have ways to monitor it 
>>>> appearing or disappearing. I can monitor the directory with
>>>> inotify
>>>> to see the file appearing or disappearing, or I can monitor the
>>>> file with inotify to see whether it changes.
>>>
>>> Ok, do you have a preference either way? I personally think having
>>> the file only appear if its functional is a bit cleaner. So if it
>>> does not matter much for userspace either way then I suggest we go
>>> that route.
>>>
>> My (limited) vote is having the file appear when the profile is
>> loaded 
>> seems nicer (and to disappear if the profile is unloaded). No
>> profile, 
>> no interface just seems elegant.
>>
>> I pretty much have v4 of the patches ready to go (I wanted to rebase
>> on 
>> the update for the palm sensor and finished that today). I'm happy to
>> hold off on them until we're ready if that helps. Bastien - let me
>> know 
>> if it would be useful to have a version to test against to see what
>> will 
>> work best for you, or if you need something different. Definitely
>> want 
>> to make sure user space gets the best option as my understanding is 
>> changing this later becomes a pain :)
> 
> I don't have the hardware. I agree with you that "no profile = no file"
> seems cleaner, but whichever is easier for you.

Ok, lets go with that then (so same as in v3).

Mark, if you can submit v4 upstream that would be great.

Regards,

Hans