From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbeEVFaI (ORCPT ); Tue, 22 May 2018 01:30:08 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41207 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbeEVFaG (ORCPT ); Tue, 22 May 2018 01:30:06 -0400 X-Google-Smtp-Source: AB8JxZqdpfTFtQzcNiL+KENpieD9LvZLqsjv0BoGSITZtkv+9HeKKwfo857bD+sP6u5nn/ooSZ2rXw== Subject: Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth To: Florian Fainelli , netdev@vger.kernel.org Cc: michal.vokac@ysoft.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, mark.rutland@arm.com, robh+dt@kernel.org, davem@davemloft.net References: <1526909293-56377-1-git-send-email-michal.vokac@ysoft.com> <1526909293-56377-5-git-send-email-michal.vokac@ysoft.com> <7d73f1b8-453a-fcbe-a1b8-41ced652deb0@gmail.com> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: <64573982-6ab3-c92d-bc24-5e27d70b89ce@gmail.com> Date: Tue, 22 May 2018 07:30:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <7d73f1b8-453a-fcbe-a1b8-41ced652deb0@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.5.2018 17:19, Florian Fainelli wrote: > > On 05/21/2018 06:28 AM, Michal Vokáč wrote: >> By default autonegotiation is enabled to configure MAC on all ports. >> For the CPU port autonegotiation can not be used so we need to set >> some sensible defaults manually. >> >> This patch forces the default setting of the CPU port to 1000Mbps/full >> duplex which is the chip maximum capability. >> >> Also correct size of the bit field used to configure link speed. >> >> Signed-off-by: Michal Vokáč > > Reviewed-by: Florian Fainelli > > Likewise, would not we want to have a: > > Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family") > > tag here as well? Good point, I will add this in v2. Thanks, Michal