From: "Christian König" <deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
To: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 1/2] drm/amdgpu: fix bug set incorrect value to vce register
Date: Wed, 11 Jan 2017 12:51:33 +0100 [thread overview]
Message-ID: <646b0b19-1a04-bd4b-ddc8-4b0fb930689c@vodafone.de> (raw)
In-Reply-To: <1484106519-10827-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
Am 11.01.2017 um 04:48 schrieb Rex Zhu:
> Change-Id: I1495894d01ca10e5d496e71f5d4b1a93a12336f3
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Not deeply into VCE programming any more, but both patches look like
they make sense and are Acked-by: Christian König
<christian.koenig@amd.com>.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> index e3bad82d..0ac4983 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c
> @@ -175,7 +175,7 @@ static void vce_v3_0_set_vce_sw_clock_gating(struct amdgpu_device *adev,
> WREG32(mmVCE_UENC_CLOCK_GATING_2, data);
>
> data = RREG32(mmVCE_UENC_REG_CLOCK_GATING);
> - data &= ~0xffc00000;
> + data &= ~0x3ff;
> WREG32(mmVCE_UENC_REG_CLOCK_GATING, data);
>
> data = RREG32(mmVCE_UENC_DMA_DCLK_CTRL);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-01-11 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 3:48 [PATCH 1/2] drm/amdgpu: fix bug set incorrect value to vce register Rex Zhu
[not found] ` <1484106519-10827-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2017-01-11 3:48 ` [PATCH 2/2] drm/amdgpu: fix program vce instance logic error Rex Zhu
2017-01-11 11:51 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=646b0b19-1a04-bd4b-ddc8-4b0fb930689c@vodafone.de \
--to=deathsimple-antagkrnahcb1svskn2v4q@public.gmane.org \
--cc=Rex.Zhu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.