From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08346C433EF for ; Mon, 13 Jun 2022 05:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233222AbiFMFgJ (ORCPT ); Mon, 13 Jun 2022 01:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233204AbiFMFfa (ORCPT ); Mon, 13 Jun 2022 01:35:30 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86487FD05 for ; Sun, 12 Jun 2022 22:35:00 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id s6so7071642lfo.13 for ; Sun, 12 Jun 2022 22:35:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=buhJIxm8AqBO3bD99fC3A2PxIb9sSGllubXvwSLnjxI=; b=poLeG6zhCv/e/uvaonfvqyZcWLUQoZKI6x1zrBYzR8yEcLqX5MJjRu0DpBmK0UieGM 9s8GkMwlIhLIZoQPjVePmWg9+eHaw3B/mxAbv92cla9k0nTwF0/t7OND21vBl/jnCbIU IRCipafuU6E/GhmoUqu9xNvZBtbB5Z528WMihwahUcILGFkidaBexjc14Cq8pW8Z7Pvj N7AfutKNP8hBX8d3mBRFD1w6M6/KhKiGE+zL5Mh/NHBVYzb1srbsoyGopRzu/uGFFuO0 9CT6RkUDfugqIiBXyVg6DD3bipqyjO7hrVYqc1/pWq903VKpx9vz96zgU+w6o/ZlFCvC 9x1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=buhJIxm8AqBO3bD99fC3A2PxIb9sSGllubXvwSLnjxI=; b=iui6TLodh35ocJ5nQIkwuurKw+RzC1IIhcT9ocHNESEeibOPT+d7e2GS2NS34scHpj o30pz1DWZAN4JXlt8jornb2mrUEGKHVmN/UL1CUQJM97D2yG1iDRss6HxfOC5rt5YZbv L9Lf5cblf94eJw4rcrnOh0WWaRaeFpe1WXHWCtZ7eWQxWLHbV6m+LOx2fyMt2wtyvhbK Sws1Zxfs8QOY4oFfEHecytNPpUuM7rkpTnCPezAq3UQJ2k/Qz3aGn3D33kIZpiIRQEeU Ew23r+XWGaQ7Thsfr4V2+zZ2frEvhTSdLBCowvTKqZt2aHT3HVQeHSQwyHeU6Ybs7FO/ Wo9w== X-Gm-Message-State: AOAM530EnxqfGm2+J778dr2ZzIdW29B9n/gXeXx81/Lk1p4JU2NP81X7 hXbzn1/abPxP/PP0iI21DKsgyw== X-Google-Smtp-Source: ABdhPJz8mC+oy5QTxd+FVDFv22laevGRjje04Lf2wVUa8G+vhmhElanXbHdoiJIbuGw58hKsSQKOWg== X-Received: by 2002:a05:6512:2249:b0:478:f926:ad7 with SMTP id i9-20020a056512224900b00478f9260ad7mr38742258lfu.511.1655098500094; Sun, 12 Jun 2022 22:35:00 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id j2-20020a2e6e02000000b002555c9d5d7fsm894992ljc.11.2022.06.12.22.34.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 22:34:59 -0700 (PDT) Message-ID: <647143fa-2521-10ae-2c4d-41dbb74d00cf@openvz.org> Date: Mon, 13 Jun 2022 08:34:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Vasily Averin Subject: [PATCH mm v4 3/9] memcg: enable accounting for kernfs iattrs To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups@vger.kernel.org References: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Content-Language: en-US In-Reply-To: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org kernfs nodes are quite small kernel objects, however there are few scenarios where it consumes significant piece of all allocated memory: 1) creating a new netdevice allocates ~50Kb of memory, where ~10Kb was allocated for 80+ kernfs nodes. 2) cgroupv2 mkdir allocates ~60Kb of memory, ~10Kb of them are kernfs structures. 3) Shakeel Butt reports that Google has workloads which create 100s of subcontainers and they have observed high system overhead without memcg accounting of kernfs. Usually new kernfs node creates few other objects: Allocs Alloc Allocation number size -------------------------------------------- 1 + 128 (__kernfs_new_node+0x4d) kernfs node 1 + 88 (__kernfs_iattrs+0x57) kernfs iattrs 1 + 96 (simple_xattr_alloc+0x28) simple_xattr, can grow over 4Kb 1 32 (simple_xattr_set+0x59) 1 8 (__kernfs_new_node+0x30) '+' -- to be accounted This patch enables accounting for kernfs_iattrs_cache slab cache Signed-off-by: Vasily Averin Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt Reviewed-by: Muchun Song --- fs/kernfs/mount.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c index 3ac4191b1c40..40e896c7c86b 100644 --- a/fs/kernfs/mount.c +++ b/fs/kernfs/mount.c @@ -397,5 +397,6 @@ void __init kernfs_init(void) /* Creates slab cache for kernfs inode attributes */ kernfs_iattrs_cache = kmem_cache_create("kernfs_iattrs_cache", sizeof(struct kernfs_iattrs), - 0, SLAB_PANIC, NULL); + 0, SLAB_PANIC | SLAB_ACCOUNT, + NULL); } -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [PATCH mm v4 3/9] memcg: enable accounting for kernfs iattrs Date: Mon, 13 Jun 2022 08:34:59 +0300 Message-ID: <647143fa-2521-10ae-2c4d-41dbb74d00cf@openvz.org> References: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=buhJIxm8AqBO3bD99fC3A2PxIb9sSGllubXvwSLnjxI=; b=poLeG6zhCv/e/uvaonfvqyZcWLUQoZKI6x1zrBYzR8yEcLqX5MJjRu0DpBmK0UieGM 9s8GkMwlIhLIZoQPjVePmWg9+eHaw3B/mxAbv92cla9k0nTwF0/t7OND21vBl/jnCbIU IRCipafuU6E/GhmoUqu9xNvZBtbB5Z528WMihwahUcILGFkidaBexjc14Cq8pW8Z7Pvj N7AfutKNP8hBX8d3mBRFD1w6M6/KhKiGE+zL5Mh/NHBVYzb1srbsoyGopRzu/uGFFuO0 9CT6RkUDfugqIiBXyVg6DD3bipqyjO7hrVYqc1/pWq903VKpx9vz96zgU+w6o/ZlFCvC 9x1A== Content-Language: en-US In-Reply-To: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> List-ID: Content-Type: text/plain; charset="macroman" To: Andrew Morton Cc: kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org a2VybmZzIG5vZGVzIGFyZSBxdWl0ZSBzbWFsbCBrZXJuZWwgb2JqZWN0cywgaG93ZXZlciB0aGVy ZSBhcmUgZmV3CnNjZW5hcmlvcyB3aGVyZSBpdCBjb25zdW1lcyBzaWduaWZpY2FudCBwaWVjZSBv ZiBhbGwgYWxsb2NhdGVkIG1lbW9yeToKCjEpIGNyZWF0aW5nIGEgbmV3IG5ldGRldmljZSBhbGxv Y2F0ZXMgfjUwS2Igb2YgbWVtb3J5LCB3aGVyZSB+MTBLYgogICB3YXMgYWxsb2NhdGVkIGZvciA4 MCsga2VybmZzIG5vZGVzLgoKMikgY2dyb3VwdjIgbWtkaXIgYWxsb2NhdGVzIH42MEtiIG9mIG1l bW9yeSwgfjEwS2Igb2YgdGhlbSBhcmUga2VybmZzCiAgIHN0cnVjdHVyZXMuCgozKSBTaGFrZWVs IEJ1dHQgcmVwb3J0cyB0aGF0IEdvb2dsZSBoYXMgd29ya2xvYWRzIHdoaWNoIGNyZWF0ZSAxMDBz CiAgIG9mIHN1YmNvbnRhaW5lcnMgYW5kIHRoZXkgaGF2ZSBvYnNlcnZlZCBoaWdoIHN5c3RlbSBv dmVyaGVhZAogICB3aXRob3V0IG1lbWNnIGFjY291bnRpbmcgb2Yga2VybmZzLgoKVXN1YWxseSBu ZXcga2VybmZzIG5vZGUgY3JlYXRlcyBmZXcgb3RoZXIgb2JqZWN0czoKCkFsbG9jcyAgQWxsb2Mg ICAgQWxsb2NhdGlvbgpudW1iZXIgIHNpemUKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0KMSAgICsgIDEyOCAgICAgIChfX2tlcm5mc19uZXdfbm9kZSsweDRkKSAg ICAgICAga2VybmZzIG5vZGUKMSAgICsgICA4OCAgICAgIChfX2tlcm5mc19pYXR0cnMrMHg1Nykg ICAgICAgICAga2VybmZzIGlhdHRycwoxICAgKyAgIDk2ICAgICAgKHNpbXBsZV94YXR0cl9hbGxv YysweDI4KSAgICAgICBzaW1wbGVfeGF0dHIsIGNhbiBncm93IG92ZXIgNEtiCjEgICAgICAgMzIg ICAgICAoc2ltcGxlX3hhdHRyX3NldCsweDU5KQoxICAgICAgIDggICAgICAgKF9fa2VybmZzX25l d19ub2RlKzB4MzApCgonKycgLS0gdG8gYmUgYWNjb3VudGVkCgpUaGlzIHBhdGNoIGVuYWJsZXMg YWNjb3VudGluZyBmb3Iga2VybmZzX2lhdHRyc19jYWNoZSBzbGFiIGNhY2hlCgpTaWduZWQtb2Zm LWJ5OiBWYXNpbHkgQXZlcmluIDx2dnMtR0VGQVF6Wlg3cjhkbm0reVJPZkUwQUBwdWJsaWMuZ21h bmUub3JnPgpSZXZpZXdlZC1ieTogUm9tYW4gR3VzaGNoaW4gPHJvbWFuLmd1c2hjaGluLWZ4VVZY ZnRJRkRueUcxekVPYlh0ZkFAcHVibGljLmdtYW5lLm9yZz4KUmV2aWV3ZWQtYnk6IE1pY2hhbCBL b3V0bsO9IDxta291dG55LUlCaTlSRy9iNjdrQHB1YmxpYy5nbWFuZS5vcmc+CkFja2VkLWJ5OiBT aGFrZWVsIEJ1dHQgPHNoYWtlZWxiLWhwSXFzRDRBS2xmUVQwZFpSK0FsZkFAcHVibGljLmdtYW5l Lm9yZz4KUmV2aWV3ZWQtYnk6IE11Y2h1biBTb25nIDxzb25nbXVjaHVuLUVDOFV4bDZOcHlkbDU3 TUlkUkNGRGdAcHVibGljLmdtYW5lLm9yZz4KLS0tCiBmcy9rZXJuZnMvbW91bnQuYyB8IDMgKyst CiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvZnMva2VybmZzL21vdW50LmMgYi9mcy9rZXJuZnMvbW91bnQuYwppbmRleCAzYWM0MTkx YjFjNDAuLjQwZTg5NmM3Yzg2YiAxMDA2NDQKLS0tIGEvZnMva2VybmZzL21vdW50LmMKKysrIGIv ZnMva2VybmZzL21vdW50LmMKQEAgLTM5Nyw1ICszOTcsNiBAQCB2b2lkIF9faW5pdCBrZXJuZnNf aW5pdCh2b2lkKQogCS8qIENyZWF0ZXMgc2xhYiBjYWNoZSBmb3Iga2VybmZzIGlub2RlIGF0dHJp YnV0ZXMgKi8KIAlrZXJuZnNfaWF0dHJzX2NhY2hlICA9IGttZW1fY2FjaGVfY3JlYXRlKCJrZXJu ZnNfaWF0dHJzX2NhY2hlIiwKIAkJCQkJICAgICAgc2l6ZW9mKHN0cnVjdCBrZXJuZnNfaWF0dHJz KSwKLQkJCQkJICAgICAgMCwgU0xBQl9QQU5JQywgTlVMTCk7CisJCQkJCSAgICAgIDAsIFNMQUJf UEFOSUMgfCBTTEFCX0FDQ09VTlQsCisJCQkJCSAgICAgIE5VTEwpOwogfQotLSAKMi4zNi4xCgo=