From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Tanjuate Brunostar <tanjubrunostar0@gmail.com>,
gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH v7 1/6] staging: vt6655: fix lines of code ending in a '('
Date: Fri, 28 Oct 2022 16:57:49 +0200 [thread overview]
Message-ID: <647b1d2d-f25a-c088-6a0e-0c2a39904150@gmail.com> (raw)
In-Reply-To: <6742e42999e05ddf09318a0a3bda9ce23b6ae562.1666849707.git.tanjubrunostar0@gmail.com>
On 10/28/22 08:39, Tanjuate Brunostar wrote:
> fix several checkpatch errors related to lines ending with a '(' by
> joining splitted lines of code and indenting properly to increase
> visibility
>
> Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
> ---
> drivers/staging/vt6655/rxtx.c | 165 ++++++++++++++--------------------
> 1 file changed, 69 insertions(+), 96 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 1e5036121665..7eb7c6eb5cf0 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -139,15 +139,11 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> * PK_TYPE_11GB 2
> * PK_TYPE_11GA 3
> */
> -static
> -unsigned int
> -s_uGetTxRsvTime(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - unsigned int cbFrameLength,
> - unsigned short wRate,
> - bool bNeedAck
> -)
> +static unsigned int s_uGetTxRsvTime(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + unsigned int cbFrameLength,
> + unsigned short wRate,
> + bool bNeedAck)
> {
> unsigned int uDataTime, uAckTime;
>
> @@ -214,20 +210,16 @@ static __le16 get_rtscts_time(struct vnt_private *priv,
> }
>
> /* byFreqType 0: 5GHz, 1:2.4Ghz */
> -static
> -unsigned int
> -s_uGetDataDuration(
> - struct vnt_private *pDevice,
> - unsigned char byDurType,
> - unsigned int cbFrameLength,
> - unsigned char byPktType,
> - unsigned short wRate,
> - bool bNeedAck,
> - unsigned int uFragIdx,
> - unsigned int cbLastFragmentSize,
> - unsigned int uMACfragNum,
> - unsigned char byFBOption
> -)
> +static unsigned int s_uGetDataDuration(struct vnt_private *pDevice,
> + unsigned char byDurType,
> + unsigned int cbFrameLength,
> + unsigned char byPktType,
> + unsigned short wRate,
> + bool bNeedAck,
> + unsigned int uFragIdx,
> + unsigned int cbLastFragmentSize,
> + unsigned int uMACfragNum,
> + unsigned char byFBOption)
> {
> bool bLastFrag = false;
> unsigned int uAckTime = 0, uNextPktTime = 0, len;
> @@ -316,17 +308,13 @@ s_uGetDataDuration(
> }
>
> /* byFreqType: 0=>5GHZ 1=>2.4GHZ */
> -static
> -__le16
> -s_uGetRTSCTSDuration(
> - struct vnt_private *pDevice,
> - unsigned char byDurType,
> - unsigned int cbFrameLength,
> - unsigned char byPktType,
> - unsigned short wRate,
> - bool bNeedAck,
> - unsigned char byFBOption
> -)
> +static __le16 s_uGetRTSCTSDuration(struct vnt_private *pDevice,
> + unsigned char byDurType,
> + unsigned int cbFrameLength,
> + unsigned char byPktType,
> + unsigned short wRate,
> + bool bNeedAck,
> + unsigned char byFBOption)
> {
> unsigned int uCTSTime = 0, uDurTime = 0;
>
> @@ -409,22 +397,18 @@ s_uGetRTSCTSDuration(
> return cpu_to_le16((u16)uDurTime);
> }
>
> -static
> -__le16
> -s_uFillDataHead(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - void *pTxDataHead,
> - unsigned int cbFrameLength,
> - unsigned int uDMAIdx,
> - bool bNeedAck,
> - unsigned int uFragIdx,
> - unsigned int cbLastFragmentSize,
> - unsigned int uMACfragNum,
> - unsigned char byFBOption,
> - unsigned short wCurrentRate,
> - bool is_pspoll
> -)
> +static __le16 s_uFillDataHead(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + void *pTxDataHead,
> + unsigned int cbFrameLength,
> + unsigned int uDMAIdx,
> + bool bNeedAck,
> + unsigned int uFragIdx,
> + unsigned int cbLastFragmentSize,
> + unsigned int uMACfragNum,
> + unsigned char byFBOption,
> + unsigned short wCurrentRate,
> + bool is_pspoll)
> {
> struct vnt_tx_datahead_ab *buf = pTxDataHead;
>
> @@ -555,19 +539,15 @@ s_uFillDataHead(
> return buf->duration;
> }
>
> -static
> -void
> -s_vFillRTSHead(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - void *pvRTS,
> - unsigned int cbFrameLength,
> - bool bNeedAck,
> - bool bDisCRC,
> - struct ieee80211_hdr *hdr,
> - unsigned short wCurrentRate,
> - unsigned char byFBOption
> -)
> +static void s_vFillRTSHead(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + void *pvRTS,
> + unsigned int cbFrameLength,
> + bool bNeedAck,
> + bool bDisCRC,
> + struct ieee80211_hdr *hdr,
> + unsigned short wCurrentRate,
> + unsigned char byFBOption)
> {
> unsigned int uRTSFrameLen = 20;
>
> @@ -750,19 +730,15 @@ s_vFillRTSHead(
> }
> }
>
> -static
> -void
> -s_vFillCTSHead(
> - struct vnt_private *pDevice,
> - unsigned int uDMAIdx,
> - unsigned char byPktType,
> - void *pvCTS,
> - unsigned int cbFrameLength,
> - bool bNeedAck,
> - bool bDisCRC,
> - unsigned short wCurrentRate,
> - unsigned char byFBOption
> -)
> +static void s_vFillCTSHead(struct vnt_private *pDevice,
> + unsigned int uDMAIdx,
> + unsigned char byPktType,
> + void *pvCTS,
> + unsigned int cbFrameLength,
> + bool bNeedAck,
> + bool bDisCRC,
> + unsigned short wCurrentRate,
> + unsigned char byFBOption)
> {
> unsigned int uCTSFrameLen = 14;
>
> @@ -868,21 +844,17 @@ s_vFillCTSHead(
> -
> * unsigned int cbFrameSize, Hdr+Payload+FCS
> */
> -static
> -void
> -s_vGenerateTxParameter(
> - struct vnt_private *pDevice,
> - unsigned char byPktType,
> - struct vnt_tx_fifo_head *tx_buffer_head,
> - void *pvRrvTime,
> - void *pvRTS,
> - void *pvCTS,
> - unsigned int cbFrameSize,
> - bool bNeedACK,
> - unsigned int uDMAIdx,
> - void *psEthHeader,
> - unsigned short wCurrentRate
> -)
> +static void s_vGenerateTxParameter(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + struct vnt_tx_fifo_head *tx_buffer_head,
> + void *pvRrvTime,
> + void *pvRTS,
> + void *pvCTS,
> + unsigned int cbFrameSize,
> + bool bNeedACK,
> + unsigned int uDMAIdx,
> + void *psEthHeader,
> + unsigned short wCurrentRate)
> {
> u16 fifo_ctl = le16_to_cpu(tx_buffer_head->fifo_ctl);
> bool bDisCRC = false;
> @@ -954,11 +926,12 @@ s_vGenerateTxParameter(
> }
> }
>
> -static unsigned int
> -s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
> - unsigned char *pbyTxBufferAddr,
> - unsigned int uDMAIdx, struct vnt_tx_desc *pHeadTD,
> - unsigned int is_pspoll)
> +static unsigned int s_cbFillTxBufHead(struct vnt_private *pDevice,
> + unsigned char byPktType,
> + unsigned char *pbyTxBufferAddr,
> + unsigned int uDMAIdx,
> + struct vnt_tx_desc *pHeadTD,
> + unsigned int is_pspoll)
> {
> struct vnt_td_info *td_info = pHeadTD->td_info;
> struct sk_buff *skb = td_info->skb;
Patch series coverletter is missing or the wrong one was send.
Changelog is also missing.
next prev parent reply other threads:[~2022-10-28 14:57 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 6:01 [PATCH v5 0/6] staging: vt6655: a series of checkpatch fixes on the file: rxtx.c Tanjuate Brunostar
2022-10-28 6:34 ` Tanjuate Brunostar
2022-10-27 9:05 ` Tanjuate Brunostar
2022-10-27 8:59 ` Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 1/6] staging: vt6655: fix lines ending in a '(' Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 1/6] staging: vt6655: fix lines of code " Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 1/6] staging: vt6655: fix lines " Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 " Tanjuate Brunostar
2022-10-27 9:20 ` Greg KH
2022-10-28 5:55 ` [PATCH v6 " Philipp Hortmann
2022-10-28 14:57 ` Philipp Hortmann [this message]
2022-10-28 16:42 ` [PATCH v7 1/6] staging: vt6655: fix lines of code " Tanju Brunostar
2022-10-28 17:52 ` Alison Schofield
2022-10-28 17:59 ` Tanju Brunostar
2022-10-27 6:01 ` [PATCH v5 2/6] staging: vt6655: refactor code in s_uGetRTSCTSDuration Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 2/6] staging: vt6655: split code lines " Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 2/6] staging: vt6655: refactor code " Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 " Tanjuate Brunostar
2022-10-27 6:37 ` Greg KH
2022-10-27 9:19 ` Greg KH
2022-10-27 13:09 ` Tanju Brunostar
2022-10-27 14:50 ` Greg KH
2022-10-27 6:01 ` [PATCH v5 3/6] staging: vt6655: refactor code in s_uFillDataHead Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 3/6] staging: vt6655: split long lines of " Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 3/6] staging: vt6655: refactor " Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 4/6] staging: vt6655: refactor code in s_vGenerateTxParameter Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 4/6] staging: vt6655: split long lines of " Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 4/6] staging: vt6655: refactor " Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 5/6] staging: vt6655: refactor code in the rest of the file Tanjuate Brunostar
2022-10-28 6:39 ` [PATCH v7 5/6] staging: vt6655: split long lines of code in " Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 5/6] staging: vt6655: refactor code in the rest of " Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 " Tanjuate Brunostar
2022-10-27 6:01 ` [PATCH v5 6/6] staging: vt6655: refactor code to avoid a line ending in '(' Tanjuate Brunostar
2022-10-28 17:40 ` [PATCH v7 6/6] staging: vt6655: fix lines of code ending in a '(' Tanjuate Brunostar
2022-10-28 6:39 ` Tanjuate Brunostar
2022-10-27 9:05 ` [PATCH v6 6/6] staging: vt6655: refactor code to avoid a line ending in '(' Tanjuate Brunostar
2022-10-27 8:59 ` [PATCH v5 " Tanjuate Brunostar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=647b1d2d-f25a-c088-6a0e-0c2a39904150@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=tanjubrunostar0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.