From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DCF7C433EF for ; Thu, 2 Jun 2022 00:31:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C76F0842B6; Thu, 2 Jun 2022 02:31:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="aC2VKA7E"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1182C8427E; Thu, 2 Jun 2022 02:31:22 +0200 (CEST) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 435A9842BF for ; Thu, 2 Jun 2022 02:31:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p3.samsung.com (unknown [182.195.41.47]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20220602003100epoutp014c8762109086dd292858e96bddbc0690~0plggdcBl1455214552epoutp01c for ; Thu, 2 Jun 2022 00:31:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20220602003100epoutp014c8762109086dd292858e96bddbc0690~0plggdcBl1455214552epoutp01c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1654129860; bh=tlrn796eS+VW7g1z4vW8IpWBk7geSIqHNqlXOoHN0Rc=; h=Date:Subject:From:To:Cc:In-Reply-To:References:From; b=aC2VKA7E8Ko0IDMCTejU/GNvybjkdazquJlfzlvrlcMgUmV9MwZlCFRcO22p7m8ZF ebC1TaC4z7+SF/bpZB2uA+YiT2mpZsVzPIkPxFOwxX9ju7gw6pPwAZHGs9TgJ2gTR6 TEN9N2jfXrxAcrnUUoaSygIzWqVnIWZ2t0rNosCU= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p3.samsung.com (KnoxPortal) with ESMTP id 20220602003100epcas1p3c5284b8618bb9798550a50fa559b55ab~0plgUfV240609306093epcas1p3D; Thu, 2 Jun 2022 00:31:00 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.36.133]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LD6PZ5wPwz4x9QL; Thu, 2 Jun 2022 00:30:58 +0000 (GMT) Received: from epcas1p2.samsung.com ( [182.195.41.46]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id 49.7F.10038.9B408926; Thu, 2 Jun 2022 09:30:49 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas1p4.samsung.com (KnoxPortal) with ESMTPA id 20220602003049epcas1p45de756b78c5aee3a452becc7959f2e16~0plWUTZPa1636516365epcas1p4C; Thu, 2 Jun 2022 00:30:49 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20220602003049epsmtrp27ec1e03e8a34f0e4769d5d1ed68a5e6d~0plWTjUj_0852008520epsmtrp2P; Thu, 2 Jun 2022 00:30:49 +0000 (GMT) X-AuditID: b6c32a37-127ff70000002736-33-629804b95afd Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id F2.1C.11276.9B408926; Thu, 2 Jun 2022 09:30:49 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220602003049epsmtip1c289083dbf247c67ccd434d5686866eb~0plWC7gwb0485004850epsmtip1K; Thu, 2 Jun 2022 00:30:49 +0000 (GMT) Message-ID: <647cad05-a26d-8591-d17b-ae08a9874872@samsung.com> Date: Thu, 2 Jun 2022 09:30:49 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] pmic: pca9450: drop pointless .data entries Content-Language: en-US From: Jaehoon Chung To: Rasmus Villemoes , u-boot@lists.denx.de Cc: Marek Vasut , Fabio Estevam , Peng Fan In-Reply-To: <09b4214c-c869-8de2-73b8-cf19c7eae3a7@samsung.com> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupik+LIzCtJLcpLzFFi42LZdlhTT3cny4wkg5WfjC3mL1jMZvGmrZHR 4seqL6wWN187WLzd28nuwOoxb9YJFo+zd3Ywemx8t4PJY8bsN4wBLFHZNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6djZF +aUlqQoZ+cUltkqpBSk5BaYFesWJucWleel6eaklVoYGBkamQIUJ2Rlvl0xgKtjFVbFr/nv2 BsatHF2MnBwSAiYS5x9/Z+pi5OIQEtjBKNG94QQrhPOJUWJ69ykWCOcbo8Sbln6gDAdYy9kn /hDxvYwSM9/ugWp/zyixdlk7E8hcXgE7ibsz7rGA2CwCKhK3fuxnhYgLSpyc+QQsLioQIbGy 9Q2YLSzgInHqxBWwXmYBcYlbT+aD2WwCOhLbvx0Hs0UE3CVeH77AClGTIHGodxM7iM0pYC+x 7nIPC0RcXmL72znMIAdJCHxll1ix8SEbxKMuEt8XH2SBsIUlXh3fwg5hS0l8freXDaKhmVFi 6ZKDrBBOD6PEv4brUN3GEvuXTmYC+Z9ZQFNi/S59iLCixM7fcxkhNvNJvPvaAw0iXomONiGI EhWJS69fMsHsuvvkPyuE7SHRffwo+wRGxVlI4TILyf+zkPwzC2HxAkaWVYxiqQXFuempxYYF xvDoTs7P3cQITpRa5jsYp739oHeIkYmD8RCjBAezkghvya6pSUK8KYmVValF+fFFpTmpxYcY TYGxM5FZSjQ5H5iq80riDU0sDUzMjIxNLAzNDJXEeVdNO50oJJCeWJKanZpakFoE08fEwSnV wDTvZ3fittkGa2eXf2RMrJK7d94pN/3bNLYs7uVPVbgvJmwXuS9c6SYpwL/oYLCQbcTeIy/E 2p3knr3Zqzrt25EHCsl5n5uKP+219ln9u0838fsvwW4tm7f3P+SGnLjKen+vx7ZDtZkC//X1 f/Mdiu84sMX17zb33l9/0jZKc5X/+vBgGpe2S8HcNxnVOwxT8pbWtHTt+GL77WP8Ju+gcw+e xX7R/+lsnPJ2SuRxs9m7nzJdLeBYzODyJtp48hebD3OK7EXSew1/aJ0zOOmmsOPsvXC1S6cv PT/f9O2Wp3GniUv7AbXJwR+myG38uzJKcHpztKVbZarF/h1eTBUtpuZ6Sb+kv9q+KtP6mB/M fkiJpTgj0VCLuag4EQBT8rxtHQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKLMWRmVeSWpSXmKPExsWy7bCSnO5OlhlJBltfK1rMX7CYzeJNWyOj xY9VX1gtbr52sHi7t5PdgdVj3qwTLB5n7+xg9Nj4bgeTx4zZbxgDWKK4bFJSczLLUov07RK4 Mt4umcBUsIurYtf89+wNjFs5uhg5OCQETCTOPvHvYuTiEBLYzSjx9uZili5GTqC4lMTnp1PZ IGqEJQ4fLoaoecsocf7IfiaQGl4BO4m7M+6B1bMIqEjc+rGfFSIuKHFy5hOwuKhAhMSnZRPA 4sICLhKnTlwB62UWEJe49WQ+mM0moCOx/dtxMFtEwF3i9eELrBA1CRLPFrUxQixuYJKY1X8M bCingL3Euss9LCDHMQuoS6yfJwRRLy+x/e0c5gmMQrOQnDELybpZCB2zkHQsYGRZxSiZWlCc m55bbFhgmJdarlecmFtcmpeul5yfu4kRHBNamjsYt6/6oHeIkYmD8RCjBAezkghvya6pSUK8 KYmVValF+fFFpTmpxYcYpTlYlMR5L3SdjBcSSE8sSc1OTS1ILYLJMnFwSjUw6XdX3g+a/cWf e+49fdaXqZVWnF0iy06rC014uyIwLOxI+/qpbR8Proh/xXtFwq7j7obpc15v8GNNyHpdcSKt 9hvLzit5ZytUWxrEjlzo1K0yexTkwJPZ76upsv5Xhs2Bf/ZPD1lfW6KeZOXB1TpTXpA98OTP K1bn4sLaZ9+dHBzOXCv1z/ul9XtmT7krx7SvLtArFt6xNv6bGVPtu6cvDBLuGl6pPM23ytSl ePeDPScM1K9azZZ5FJh5Kpyx/EbiVv6j/mnTNG5oX15ZFJH63E8hSVhQZo3irxy14mMlCxUO Ka1L2bm7UOm92oUVsQZBfvMdj5YlBZ6efnAqx4KFfMtCvKoP6J0JrtuhfOuXEktxRqKhFnNR cSIACm8oZPgCAAA= X-CMS-MailID: 20220602003049epcas1p45de756b78c5aee3a452becc7959f2e16 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220503085823epcas1p1762ee209ae2cc01d759e2a54133fdc21 References: <20220503085807.904742-1-rasmus.villemoes@prevas.dk> <20220503085807.904742-2-rasmus.villemoes@prevas.dk> <09b4214c-c869-8de2-73b8-cf19c7eae3a7@samsung.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Dear Rasums, On 5/17/22 08:44, Jaehoon Chung wrote: > On 5/3/22 17:58, Rasmus Villemoes wrote: >> These are the i2c addresses of the chips, but that comes from device >> tree. Having that information duplicated here just adds confusion. >> >> Signed-off-by: Rasmus Villemoes There is a conflict with commit 326337fb005f968911d897867d09d1228b070d84. Could you send the patch again? Sorry for too late. Best Regards, Jaehoon Chung > > > Reviewed-by: Jaehoon Chung > > Best Regards, > Jaehoon Chung > >> --- >> drivers/power/pmic/pca9450.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c >> index 2394b196c5..34cee34dba 100644 >> --- a/drivers/power/pmic/pca9450.c >> +++ b/drivers/power/pmic/pca9450.c >> @@ -81,9 +81,9 @@ static struct dm_pmic_ops pca9450_ops = { >> }; >> >> static const struct udevice_id pca9450_ids[] = { >> - { .compatible = "nxp,pca9450a", .data = 0x25, }, >> - { .compatible = "nxp,pca9450b", .data = 0x25, }, >> - { .compatible = "nxp,pca9450c", .data = 0x25, }, >> + { .compatible = "nxp,pca9450a" }, >> + { .compatible = "nxp,pca9450b" }, >> + { .compatible = "nxp,pca9450c" }, >> { } >> }; >> > >