From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [PATCH] devtools: check commit log fixes syntax
Date: Wed, 30 Jan 2019 12:27:58 +0100 [thread overview]
Message-ID: <6481538.UeMWjqPEGc@xps> (raw)
In-Reply-To: <7d48eede-61eb-9dc0-ea1b-799489850eb0@intel.com>
30/01/2019 12:17, Ferruh Yigit:
> On 1/30/2019 9:58 AM, David Marchand wrote:
> > The contributing guide does indicate you are supposed to run both
> > checkpatches.sh and check-git-log.sh.
> > I am pretty sure I missed this second step in the past..
> >
> > How about calling check-git-log.sh from checkpatches.sh ?
> > check-git-log.sh does not support patch files as input, so it would need
> > support for it.
>
> That sounds good idea to have single script to run.
It will never be only one script to run.
There are more scripts in devtools and I plan to add more.
Some checks can be done only once for a group of commits,
and will be really too slow if run for each patch when merging a branch.
About check-git-log, some tests cannot be possible outside of a git tree.
Do you want to run it when checkpatches is run on git tree?
Wouldn't it be confusing?
next prev parent reply other threads:[~2019-01-30 11:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 15:30 [PATCH] devtools: check commit log fixes syntax Ferruh Yigit
2019-01-29 17:34 ` David Marchand
2019-01-29 18:07 ` Ferruh Yigit
2019-01-30 9:58 ` David Marchand
2019-01-30 11:17 ` Ferruh Yigit
2019-01-30 11:24 ` Bruce Richardson
2019-01-30 11:27 ` Thomas Monjalon [this message]
2019-01-30 11:31 ` Bruce Richardson
2019-01-30 12:23 ` Thomas Monjalon
2019-01-29 20:41 ` Thomas Monjalon
2019-01-30 11:15 ` Ferruh Yigit
2019-01-30 11:29 ` Bruce Richardson
2019-01-30 11:31 ` Thomas Monjalon
2019-01-30 11:35 ` Bruce Richardson
2019-01-30 12:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6481538.UeMWjqPEGc@xps \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.