From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAZrq-0001Zw-W2 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 05:33:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAZrl-0005bx-N6 for qemu-devel@nongnu.org; Wed, 08 Jun 2016 05:33:40 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:63371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAZrl-0005br-Co for qemu-devel@nongnu.org; Wed, 08 Jun 2016 05:33:37 -0400 References: <1465239499-5048-1-git-send-email-peter.maydell@linaro.org> <1465239499-5048-15-git-send-email-peter.maydell@linaro.org> <8e7c37a6-2df3-0c1c-e52c-07c2676195ea@vivier.eu> From: Laurent Vivier Message-ID: <6482e445-af59-8973-a1ea-970d3160ccdf@vivier.eu> Date: Wed, 8 Jun 2016 11:33:26 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 14/18] linux-user: Use __get_user() and __put_user() to handle structs in do_fcntl() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Patch Tracking , Riku Voipio Le 07/06/2016 à 23:20, Peter Maydell a écrit : > On 7 June 2016 at 21:41, Laurent Vivier wrote: >>> - fl64.l_type = >>> - target_to_host_bitmask(tswap16(target_fl64->l_type), flock_tbl) >> 1; >> >> The ">> 1" disappears... > > ...and it's correct that it disappears, right? Yes. I forgot to remove this when I have understood what was the reason of the shift. Thanks, Laurent