From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 03/41] bus/dpaa: add compatibility and
	helper macros
Date: Thu, 28 Sep 2017 00:09:41 +0100
Message-ID: <6489a791-e586-9f15-dd71-4aff3294493b@intel.com>
References: <20170823141213.25476-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-1-shreyansh.jain@nxp.com>
 <20170909112132.13936-4-shreyansh.jain@nxp.com>
 <916531df-edb4-d0fe-cb86-32cedb6fc46a@intel.com>
 <690be1c8-67d1-31e0-b1dc-4b270b1f8519@nxp.com>
 <3bf46b37-6bcb-b6c5-62ea-5632f81f518a@intel.com>
 <c10aa368-1ce4-8bc1-4e40-4dfcaeb99e11@nxp.com>
 <dbfd3338-711d-8ef5-1df4-ce5dfa13dce6@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id EB2EA276C
 for <dev@dpdk.org>; Thu, 28 Sep 2017 01:09:44 +0200 (CEST)
In-Reply-To: <dbfd3338-711d-8ef5-1df4-ce5dfa13dce6@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/26/2017 1:43 PM, Shreyansh Jain wrote:
> On Tuesday 19 September 2017 07:27 PM, Shreyansh Jain wrote:
>> On Tuesday 19 September 2017 07:10 PM, Ferruh Yigit wrote:
>>> On 9/19/2017 2:18 PM, Shreyansh Jain wrote:
>>>> On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote:
>>>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote:
>>>>>> From: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>>
>>>>>> Linked list, bit operations and compatibility macros.
>>>>>>
>>>>>> Signed-off-by: Geoff Thorpe <geoff.thorpe@nxp.com>
>>>>>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>>>>
> 
> [...]
> 
>>>>>> + */
>>>>>
>>>
>>> <...>
>>>
>>>>>> +
>>>>>> +#ifndef __DPAA_LIST_H
>>>>>> +#define __DPAA_LIST_H
>>>>>> +
>>>>>> +/****************/
>>>>>> +/* Linked-lists */
>>>>>> +/****************/
>>>>>
>>>>> Do we need to maintain a linked list implementation, why no just use
>>>>> sys/queue.h ones as done many places in DPDK?
>>>>>
>>>>>> +
>>>>>> +struct list_head {
>>>>>> +    struct list_head *prev;
>>>>>> +    struct list_head *next;
>>>>>> +};
>>>>>> +
>>>>>
>>>>> <...>
>>>>>
>>>>
>>>> The underlying DPAA infrastructure code is shared between kernel and
>>>> userspace. That is why, changing the internal headers (for example,
>>>> using RTE_* queues) is something I want to avoid until absolutely
>>>> necessary. The outer layers (drivers/*/dpaa/<here>) are something I am
>>>> trying to keep as close to possible to DPDK.
>>>
>>> I understand you want to escape from maintaining a copy of common files
>>> for DPDK, this has been done by many drivers, as not changing "base"
>>> files, this makes sense.
>>>
>>> But for this case, file is "dpaa_list.h" and as far as I can see all it
>>> has is linked list implementation, this looked easy to exclude, but if
>>> not you can ignore the comment.
>>
>> Got your point. I will respin and see how much is the impact.
>> Thanks for inputs.
> 
> I tried to work around the dpaa_list.h use in DPAA code - but, the 
> changes are subtle but large in number - though, restricted only to base 
> framework.
> I would prefer to skip this for a while as the driver is stable now. I 
> would probably do this change in a incremental manner to keep it traceable.
> 
> Ferruh, Is that OK with you?

That is OK, if it is not easy to escape from it.