All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alban Gruin <alban.gruin@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
	Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, phillip.wood123@gmail.com
Subject: Re: ag/sequencer-todo-updates , was Re: What's cooking in git.git (Nov 2019, #03; Tue, 19)
Date: Thu, 21 Nov 2019 09:17:59 +0100	[thread overview]
Message-ID: <6489e9f6-2d9f-33fe-cc44-fff80732c138@gmail.com> (raw)
In-Reply-To: <xmqqv9rfckq0.fsf@gitster-ct.c.googlers.com>

Hi Jonathan & Junio,

Le 20/11/2019 à 04:03, Junio C Hamano a écrit :
> Jonathan Tan <jonathantanmy@google.com> writes:
> 
>>>> * ag/sequencer-todo-updates (2019-10-28) 6 commits
>>>>  - SQUASH??? tentative leakfix
>>>>  - sequencer: directly call pick_commits() from complete_action()
>>>>  - rebase: fill `squash_onto' in get_replay_opts()
>>>>  - sequencer: move the code writing total_nr on the disk to a new function
>>>>  - sequencer: update `done_nr' when skipping commands in a todo list
>>>>  - sequencer: update `total_nr' when adding an item to a todo list
>>>>
>>>>  Reduce unnecessary reading of state variables back from the disk
>>>>  during sequener operation.
>>>>
>>>>  Is the leakfix patch at the tip the only thing that needs to
>>>>  prepare the topic ready for 'next'?
>>>>
>>>
>>> Yes, it is.
>>
>> I took a look at this. Some comments:

Thank you for the feedback.

> 
> I took a look at your comments and re-read the patches and I do
> agree with many of your points.
> 
> Let me not merge this round to 'next' and wait for a reroll.
> 
> Thanks for stopping me.
> 

I’ll send a reroll in the next few days.

Cheers,
Alban


  reply	other threads:[~2019-11-21  8:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19  7:05 What's cooking in git.git (Nov 2019, #03; Tue, 19) Junio C Hamano
2019-11-19  9:38 ` Danh Doan
2019-11-20  2:52   ` Junio C Hamano
2019-11-19 17:58 ` SZEDER Gábor
2019-11-20  3:02   ` Junio C Hamano
2019-11-20 13:58     ` Derrick Stolee
2019-11-21  0:36       ` Junio C Hamano
2019-11-21 11:10         ` Derrick Stolee
2019-11-22  5:42           ` Junio C Hamano
2019-11-19 18:01 ` ag/sequencer-todo-updates , was " Alban Gruin
2019-11-19 20:41   ` Jonathan Tan
2019-11-20  3:03     ` Junio C Hamano
2019-11-21  8:17       ` Alban Gruin [this message]
2019-11-23  0:47     ` Alban Gruin
2019-11-20 23:32 ` Denton Liu
2019-11-21  0:39   ` Junio C Hamano
2019-11-23 20:35 ` Philippe Blain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6489e9f6-2d9f-33fe-cc44-fff80732c138@gmail.com \
    --to=alban.gruin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.