All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: John Snow <jsnow@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms
Date: Wed, 2 Oct 2019 19:54:24 +0200	[thread overview]
Message-ID: <6491a70e-c574-5ccf-1d2e-f9b49632fec2@redhat.com> (raw)
In-Reply-To: <20191002164438.GD5819@localhost.localdomain>


[-- Attachment #1.1: Type: text/plain, Size: 1656 bytes --]

On 02/10/2019 18.44, Kevin Wolf wrote:
> Not sure where in this thread to reply, but since my name is mentioned
> in this mail, it might at least be not the worst one.
> 
> Am 02.10.2019 um 13:57 hat Max Reitz geschrieben:
>> On 02.10.19 06:46, Thomas Huth wrote:
>>> On 01/10/2019 20.44, Max Reitz wrote:
>>> [...]
>>>> As I have said, the conceptual problem is that the iotests now run as
>>>> part of make check.  As such, allowing auto tests to run on non-Linux
>>>> platforms may introduce build failures that I cannot do anything about.
>>>
>>> Well, simply run "make vm-build-openbsd", "make vm-build-freebsd", ...
>>> if something fails there, it likely should not be in the auto group.
>>
>> Then we come to Windows and macOS.
>>
>> What I’ve proposed to John on IRC was to simply skip the iotests in make
>> check for non-Linux systems.
> 
> I think this really makes sense. Or at least have a blacklist of OSes
> that we can't support iotests on, which would contain at least Windows
> and OS X. Windows because I'm pretty sure that it doesn't work anyway,
> and OS X because if something fails there, we have no way to reproduce.

Both, .travis.yml and .cirrus-ci.yml have a macOS test, so you can
reproduce bugs there. It's just a PITA that you cannot do any
interactive debugging there.

[...]
> Can we run tests in 'auto' that require the system emulator?

Yes. In fact, tests/check-block.sh explicitly checks for the
availability of a system emulator before running the iotests.

> If so, let's add 030 040 041 to the default set.
Sure, but let's check whether they work in Travis first.

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2019-10-02 17:55 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 23:45 [Qemu-devel] [PATCH v5 0/5] iotests: use python logging John Snow
2019-09-17 23:45 ` [Qemu-devel] [PATCH v5 1/5] iotests: remove 'linux' from default supported platforms John Snow
2019-09-18 13:16   ` Vladimir Sementsov-Ogievskiy
2019-09-23 13:09   ` Max Reitz
2019-09-23 17:21     ` John Snow
2019-09-27 23:35     ` John Snow
2019-10-01 18:44       ` Max Reitz
2019-10-02  4:46         ` Thomas Huth
2019-10-02 11:57           ` Max Reitz
2019-10-02 13:11             ` Thomas Huth
2019-10-02 13:36               ` Max Reitz
2019-10-02 14:26                 ` Thomas Huth
2019-10-02 16:44             ` Kevin Wolf
2019-10-02 17:47               ` Max Reitz
2019-10-04 10:19                 ` Kevin Wolf
2019-10-04 12:44                   ` Max Reitz
2019-10-04 13:16                     ` Peter Maydell
2019-10-04 13:50                       ` Max Reitz
2019-10-04 14:05                         ` Peter Maydell
2019-10-04 14:40                           ` Max Reitz
2019-10-07 12:16                     ` Thomas Huth
2019-10-07 12:38                       ` Peter Maydell
2019-10-07 12:52                       ` Max Reitz
2019-10-07 13:11                         ` Thomas Huth
2019-10-07 16:28                           ` Thomas Huth
2019-10-07 16:55                             ` Max Reitz
2019-10-02 17:54               ` Thomas Huth [this message]
2019-10-03  0:16         ` John Snow
2019-09-17 23:45 ` [Qemu-devel] [PATCH v5 2/5] iotests: add script_initialize John Snow
2019-09-18 13:48   ` Vladimir Sementsov-Ogievskiy
2019-09-23 13:30   ` Max Reitz
2019-09-23 13:34     ` Max Reitz
2019-09-17 23:45 ` [Qemu-devel] [PATCH v5 3/5] iotest 258: use script_main John Snow
2019-09-23 13:33   ` Max Reitz
2019-09-17 23:45 ` [Qemu-devel] [PATCH v5 4/5] iotests: specify protocol support via initialization info John Snow
2019-09-23 13:35   ` Max Reitz
2019-09-17 23:45 ` [Qemu-devel] [PATCH v5 5/5] iotests: use python logging for iotests.log() John Snow
2019-09-18 14:52   ` Vladimir Sementsov-Ogievskiy
2019-09-18 17:11     ` John Snow
2019-09-23 13:57   ` Max Reitz
2019-10-04 15:39 ` [PATCH v5 0/5] iotests: use python logging Max Reitz
2019-10-11 23:39   ` John Snow
2020-02-24 11:15     ` Max Reitz
2020-02-25 21:50       ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6491a70e-c574-5ccf-1d2e-f9b49632fec2@redhat.com \
    --to=thuth@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.