From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vladimir Zapolskiy Subject: Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine Date: Sat, 11 Nov 2017 16:21:07 +0200 Message-ID: <6492d1af-19fa-253f-2b75-2c37ccd44cbe@mleia.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Greg Kroah-Hartman , Rob Herring , Mauro Carvalho Chehab , Stephen Warren Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Dan Carpenter , linux-media@vger.kernel.org List-Id: linux-tegra@vger.kernel.org Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > > diff --git a/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > new file mode 100644 > index 000000000000..470237ed6fe5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > @@ -0,0 +1,55 @@ > +NVIDIA Tegra Video Decoder Engine > + > +Required properties: > +- compatible : Must contain one of the following values: > + - "nvidia,tegra20-vde" > + - "nvidia,tegra30-vde" > + - "nvidia,tegra114-vde" > + - "nvidia,tegra124-vde" > + - "nvidia,tegra132-vde" > +- reg : Must contain an entry for each entry in reg-names. > +- reg-names : Must include the following entries: > + - sxe > + - bsev > + - mbe > + - ppe > + - mce > + - tfe > + - ppb > + - vdma > + - frameid I've already mentioned it in my review of the driver code, but the version from v3 with a single region is more preferable. Also it implies that "reg-names" property will be removed. > +- iram : Must contain phandle to the mmio-sram device node that represents > + IRAM region used by VDE. > +- interrupts : Must contain an entry for each entry in interrupt-names. > +- interrupt-names : Must include the following entries: > + - sync-token > + - bsev > + - sxe > +- clocks : Must include the following entries: > + - vde > +- resets : Must include the following entries: > + - vde > + > +Example: > + > +video-codec@6001a000 { > + compatible = "nvidia,tegra20-vde"; > + reg = <0x6001a000 0x1000 /* Syntax Engine */ > + 0x6001b000 0x1000 /* Video Bitstream Engine */ > + 0x6001c000 0x100 /* Macroblock Engine */ > + 0x6001c200 0x100 /* Post-processing Engine */ > + 0x6001c400 0x100 /* Motion Compensation Engine */ > + 0x6001c600 0x100 /* Transform Engine */ > + 0x6001c800 0x100 /* Pixel prediction block */ > + 0x6001ca00 0x100 /* Video DMA */ > + 0x6001d800 0x300 /* Video frame controls */>; > + reg-names = "sxe", "bsev", "mbe", "ppe", "mce", > + "tfe", "ppb", "vdma", "frameid"; > + iram = <&vde_pool>; /* IRAM region */ > + interrupts = , /* Sync token interrupt */ > + , /* BSE-V interrupt */ > + ; /* SXE interrupt */ > + interrupt-names = "sync-token", "bsev", "sxe"; > + clocks = <&tegra_car TEGRA20_CLK_VDE>; > + resets = <&tegra_car 61>; > +}; > -- With best wishes, Vladimir From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448AbdKKOVP (ORCPT ); Sat, 11 Nov 2017 09:21:15 -0500 Received: from mleia.com ([178.79.152.223]:53742 "EHLO mail.mleia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbdKKOVK (ORCPT ); Sat, 11 Nov 2017 09:21:10 -0500 Subject: Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine To: Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Greg Kroah-Hartman , Rob Herring , Mauro Carvalho Chehab , Stephen Warren References: Cc: Dan Carpenter , linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Vladimir Zapolskiy Message-ID: <6492d1af-19fa-253f-2b75-2c37ccd44cbe@mleia.com> Date: Sat, 11 Nov 2017 16:21:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-49551924 X-CRM114-CacheID: sfid-20171111_142226_224309_246AA76C X-CRM114-Status: GOOD ( 21.15 ) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > > diff --git a/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > new file mode 100644 > index 000000000000..470237ed6fe5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > @@ -0,0 +1,55 @@ > +NVIDIA Tegra Video Decoder Engine > + > +Required properties: > +- compatible : Must contain one of the following values: > + - "nvidia,tegra20-vde" > + - "nvidia,tegra30-vde" > + - "nvidia,tegra114-vde" > + - "nvidia,tegra124-vde" > + - "nvidia,tegra132-vde" > +- reg : Must contain an entry for each entry in reg-names. > +- reg-names : Must include the following entries: > + - sxe > + - bsev > + - mbe > + - ppe > + - mce > + - tfe > + - ppb > + - vdma > + - frameid I've already mentioned it in my review of the driver code, but the version from v3 with a single region is more preferable. Also it implies that "reg-names" property will be removed. > +- iram : Must contain phandle to the mmio-sram device node that represents > + IRAM region used by VDE. > +- interrupts : Must contain an entry for each entry in interrupt-names. > +- interrupt-names : Must include the following entries: > + - sync-token > + - bsev > + - sxe > +- clocks : Must include the following entries: > + - vde > +- resets : Must include the following entries: > + - vde > + > +Example: > + > +video-codec@6001a000 { > + compatible = "nvidia,tegra20-vde"; > + reg = <0x6001a000 0x1000 /* Syntax Engine */ > + 0x6001b000 0x1000 /* Video Bitstream Engine */ > + 0x6001c000 0x100 /* Macroblock Engine */ > + 0x6001c200 0x100 /* Post-processing Engine */ > + 0x6001c400 0x100 /* Motion Compensation Engine */ > + 0x6001c600 0x100 /* Transform Engine */ > + 0x6001c800 0x100 /* Pixel prediction block */ > + 0x6001ca00 0x100 /* Video DMA */ > + 0x6001d800 0x300 /* Video frame controls */>; > + reg-names = "sxe", "bsev", "mbe", "ppe", "mce", > + "tfe", "ppb", "vdma", "frameid"; > + iram = <&vde_pool>; /* IRAM region */ > + interrupts = , /* Sync token interrupt */ > + , /* BSE-V interrupt */ > + ; /* SXE interrupt */ > + interrupt-names = "sync-token", "bsev", "sxe"; > + clocks = <&tegra_car TEGRA20_CLK_VDE>; > + resets = <&tegra_car 61>; > +}; > -- With best wishes, Vladimir