From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Piyush Mehta <piyush.mehta@amd.com>,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, balbi@kernel.org,
linux-usb@vger.kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
git@amd.com, michal.simek@amd.com,
siva.durga.prasad.paladugu@amd.com,
Piyush Mehta <piyush.mehta@xilinx.com>
Subject: Re: [PATCH V2 1/2] dt-bindings: usb: snps,dwc3: Add 'snps,resume-hs-terminations' quirk
Date: Mon, 19 Sep 2022 14:53:51 +0200 [thread overview]
Message-ID: <6499fa0e-3e07-85b4-0800-849db7c2593b@linaro.org> (raw)
In-Reply-To: <20220919104816.4075019-2-piyush.mehta@amd.com>
On 19/09/2022 12:48, Piyush Mehta wrote:
> From: Piyush Mehta <piyush.mehta@xilinx.com>
>
> Add a new 'snps,resume-hs-terminations' DT quirk to dwc3 core to resolved
> issue of CRC failed error.
>
> On the resume path, U3/U2 exit controller fails to send proper CRC checksum
> in CRC5 field. As result Transaction Error is generated. Enabling bit 10 of
> GUCTL1 will correct this problem.
>
> When this bit is set to '1', the UTMI/ULPI opmode will be changed to
> "normal" along with HS terminations and term/xcvr select signals after EOR.
> This option is to support certain legacy UTMI/ULPI PHYs.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
Only one SoB is needed for one person. For example switch to amd.com
(with ownership of commit) or skip second SoB.
> ---
> Changes in V2:
> - Addressed Krzysztof Kozlowski review comments
> - Update the quirk name and No underscores in properties.
> - Modified the quirk description.
> Link: https://lore.kernel.org/all/e15168ac-b5a1-0c15-cfb3-34fb518e737f@linaro.org/
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-19 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 10:48 [PATCH V2 0/2] usb: dwc3: core: Enable GUCTL1 bit 10 for fixing crc error after resume Piyush Mehta
2022-09-19 10:48 ` [PATCH V2 1/2] dt-bindings: usb: snps,dwc3: Add 'snps,resume-hs-terminations' quirk Piyush Mehta
2022-09-19 12:53 ` Krzysztof Kozlowski [this message]
2022-09-19 10:48 ` [PATCH V2 2/2] usb: dwc3: core: Enable GUCTL1 bit 10 for fixing termination error after resume bug Piyush Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6499fa0e-3e07-85b4-0800-849db7c2593b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=piyush.mehta@amd.com \
--cc=piyush.mehta@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=siva.durga.prasad.paladugu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.