All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@scylladb.com>
To: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Cc: michaelcallahan@fb.com
Subject: Re: discard improvements
Date: Fri, 28 Oct 2016 13:11:55 +0300	[thread overview]
Message-ID: <64a1c5dc-4a36-1ef6-606e-b382d36161ef@scylladb.com> (raw)
In-Reply-To: <1476735753-5861-1-git-send-email-hch@lst.de>

On 10/17/2016 11:22 PM, Christoph Hellwig wrote:
> iThis series improves XFS discard support so that we don't stall the
> log commit thread and improve performance for workloads with lots
> of deletions.
>
> The first patch is a fix for a long-standing allocator issue when we
> have busy extents in the way of an allocation.  Without the async
> discard support it was harder to hit, but it's basically been there
> since we added busy extent tracking and non-synchronous delete
> transactions.
>
> The second patch is the main async discard support, and the third
> one allows to batch up multiple extents into a single discard bio,
> which is a common occurance.
>

With these patches, is it reasonable to run with discard enabled, or is 
more work needed?

  parent reply	other threads:[~2016-10-28 10:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 20:22 Christoph Hellwig
2016-10-17 20:22 ` [PATCH 1/3] xfs: fix the AG loop in xfs_alloc_vextent for busy extents Christoph Hellwig
2016-10-19 13:48   ` Brian Foster
2016-10-21 12:48     ` Christoph Hellwig
2016-10-21 14:41       ` Brian Foster
2016-11-08  6:15   ` Dave Chinner
2016-11-10 19:17     ` Christoph Hellwig
2016-10-17 20:22 ` [PATCH 2/3] xfs: don't block the log commit handler for discards Christoph Hellwig
2016-10-17 23:29   ` Dave Chinner
2016-10-18  5:05     ` Christoph Hellwig
2016-10-19 10:58     ` Christoph Hellwig
2016-10-28 16:16       ` Michael Callahan
2016-10-31 15:16         ` Christoph Hellwig
2016-10-17 20:22 ` [PATCH 3/3] xfs: merge discard requests Christoph Hellwig
2016-10-28 10:11 ` Avi Kivity [this message]
2016-10-31 15:14   ` discard improvements Christoph Hellwig
2016-11-05 18:18     ` Avi Kivity
2016-11-06 16:36       ` Christoph Hellwig
2016-11-06 23:21         ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64a1c5dc-4a36-1ef6-606e-b382d36161ef@scylladb.com \
    --to=avi@scylladb.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=michaelcallahan@fb.com \
    --subject='Re: discard improvements' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.