From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933768AbdHYPOi (ORCPT ); Fri, 25 Aug 2017 11:14:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933705AbdHYPNi (ORCPT ); Fri, 25 Aug 2017 11:13:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 99E4661487 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [RFC v2 1/2] virt: Add vboxguest driver for Virtual Box Guest integration To: Christoph Hellwig Cc: Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , "Knut St . Osmundsen" , Larry Finger , linux-kernel@vger.kernel.org References: <20170825143732.10836-1-hdegoede@redhat.com> <20170825143732.10836-2-hdegoede@redhat.com> <20170825145806.GA6706@infradead.org> <9e9b6c22-50dd-4935-9dfd-7c8a885f75e9@redhat.com> <20170825150324.GA23830@infradead.org> <20170825150916.GA353@infradead.org> From: Hans de Goede Message-ID: <64a29ce3-3e48-5ce8-64a0-c4384cdd5a94@redhat.com> Date: Fri, 25 Aug 2017 17:13:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170825150916.GA353@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 25 Aug 2017 15:13:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 25-08-17 17:09, Christoph Hellwig wrote: > On Fri, Aug 25, 2017 at 05:06:52PM +0200, Hans de Goede wrote: >> I'm afraid that the userspace API is more or less a take it >> or leave it kinda deal, we can do small cleanups, but an >> entire re-design is out of the question. The vboxguest code >> has a long (too long) out of tree history and the same ioctl >> interface is used by VirtualBox upstream on Windows, Mac OS X, >> the BSDs and Solaris, so we cannot just go and break it to >> out hart's content. > > Then hard out NAK for the code. You know I've been working on this for almost 2 fulltime months and this has been discussed in several places already long before you jumped on this thread and so far everyone liked the idea of getting this merged and was ok with living with the existing ioctl API (assuming no security issues / other nasty warts are found during review). So although your input on this is appreciated some pragmatism would also be much appreciated. Remember perfect is the enemy of good. Regards, Hans