* [PATCH v2] docs/nvdimm: Update nvdimm option value in machine example
@ 2021-09-23 10:30 Pankaj Gupta
2021-09-23 14:59 ` Laurent Vivier
0 siblings, 1 reply; 2+ messages in thread
From: Pankaj Gupta @ 2021-09-23 10:30 UTC (permalink / raw)
To: xiaoguangrong.eric, pankaj.gupta.linux, lvivier, stefanha, pankaj.gupta
Cc: qemu-trivial, qemu-devel, Laurent Vivier
Update nvdimm option value in example command from "-machine pc,nvdimm"
to "-machine pc,nvdimm=on" as former complains with the below error:
"qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
---
docs/nvdimm.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
index 0aae682be3..fd7773dc5a 100644
--- a/docs/nvdimm.txt
+++ b/docs/nvdimm.txt
@@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
way to create a vNVDIMM device at startup time is done via the
following command line options:
- -machine pc,nvdimm
+ -machine pc,nvdimm=on
-m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
-object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
-device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] docs/nvdimm: Update nvdimm option value in machine example
2021-09-23 10:30 [PATCH v2] docs/nvdimm: Update nvdimm option value in machine example Pankaj Gupta
@ 2021-09-23 14:59 ` Laurent Vivier
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Vivier @ 2021-09-23 14:59 UTC (permalink / raw)
To: Pankaj Gupta, xiaoguangrong.eric, lvivier, stefanha, pankaj.gupta
Cc: qemu-trivial, qemu-devel
Le 23/09/2021 à 12:30, Pankaj Gupta a écrit :
> Update nvdimm option value in example command from "-machine pc,nvdimm"
> to "-machine pc,nvdimm=on" as former complains with the below error:
>
> "qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> ---
> docs/nvdimm.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
> index 0aae682be3..fd7773dc5a 100644
> --- a/docs/nvdimm.txt
> +++ b/docs/nvdimm.txt
> @@ -15,7 +15,7 @@ backend (i.e. memory-backend-file and memory-backend-ram). A simple
> way to create a vNVDIMM device at startup time is done via the
> following command line options:
>
> - -machine pc,nvdimm
> + -machine pc,nvdimm=on
> -m $RAM_SIZE,slots=$N,maxmem=$MAX_SIZE
> -object memory-backend-file,id=mem1,share=on,mem-path=$PATH,size=$NVDIMM_SIZE,readonly=off
> -device nvdimm,id=nvdimm1,memdev=mem1,unarmed=off
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-23 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-23 10:30 [PATCH v2] docs/nvdimm: Update nvdimm option value in machine example Pankaj Gupta
2021-09-23 14:59 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.