From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling
Date: Tue, 6 Apr 2021 11:06:13 +0100 [thread overview]
Message-ID: <64acfa0f-8047-07ad-ee3d-6c59afcf5bcb@intel.com> (raw)
In-Reply-To: <20210402104504.166aa8da@hermes.local>
On 02-Apr-21 6:45 PM, Stephen Hemminger wrote:
> On Thu, 1 Apr 2021 15:05:17 +0000
> Anatoly Burakov <anatoly.burakov@intel.com> wrote:
>
>>
>> +#define FOPEN_OR_ERR_GOTO(f, label) do { \
>> + if ((f) == NULL) { \
>> + RTE_LOG(ERR, POWER, "File not opened\n"); \
>> + goto label; \
>> + } \
>> +} while (0)
>> +
>
> I am not a fan of macros like this that have gotos.
> It is clearer to just open code it.
>
Well, it's keeping consistent style with the rest of the file. If we are
to remove these, ideally we should just replace usage of all of them.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-04-06 10:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 15:05 [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling Anatoly Burakov
2021-04-02 9:27 ` [dpdk-dev] [21.08 v2] " Anatoly Burakov
2021-04-02 17:45 ` [dpdk-dev] [PATCH 21.08] " Stephen Hemminger
2021-04-06 10:06 ` Burakov, Anatoly [this message]
2021-04-02 17:46 ` Stephen Hemminger
2021-04-06 10:05 ` Burakov, Anatoly
2021-04-22 15:08 ` [dpdk-dev] [21.08 PATCH v3 1/1] " Anatoly Burakov
2021-04-23 11:03 ` [dpdk-dev] [21.08 PATCH v4 1/2] power: don't use rte prefix in internal code Anatoly Burakov
2021-05-31 10:23 ` David Hunt
2021-06-22 12:43 ` [dpdk-dev] [PATCH v2 " David Hunt
2021-06-22 12:43 ` [dpdk-dev] [PATCH v2 2/2] power: refactor pstate and acpi code David Hunt
2021-06-22 13:00 ` David Hunt
2021-06-22 12:59 ` [dpdk-dev] [PATCH v2 1/2] power: don't use rte prefix in internal code David Hunt
2021-06-22 12:58 ` [dpdk-dev] [PATCH v5 " David Hunt
2021-06-22 12:58 ` [dpdk-dev] [PATCH v5 2/2] power: refactor pstate and acpi code David Hunt
2021-06-22 13:27 ` David Hunt
2021-06-23 8:54 ` Richael Zhuang
2021-06-23 9:00 ` David Hunt
2021-06-23 12:03 ` [dpdk-dev] [PATCH v6 1/2] power: don't use rte prefix in internal code David Hunt
2021-06-23 12:03 ` [dpdk-dev] [PATCH v6 2/2] power: refactor pstate and acpi code David Hunt
2021-06-23 12:27 ` Burakov, Anatoly
2021-06-30 5:32 ` Richael Zhuang
2021-07-08 12:49 ` David Marchand
2021-07-08 13:33 ` David Hunt
2021-07-08 15:38 ` [dpdk-dev] [PATCH v7 1/2] power: don't use rte prefix in internal code David Hunt
2021-07-08 15:38 ` [dpdk-dev] [PATCH v7 2/2] power: refactor pstate and acpi code David Hunt
2021-07-08 20:41 ` [dpdk-dev] [PATCH v7 1/2] power: don't use rte prefix in internal code David Marchand
2021-04-23 11:03 ` [dpdk-dev] [21.08 PATCH v4 2/2] power: refactor pstate and acpi code Anatoly Burakov
2021-05-07 2:13 ` Richael Zhuang
2021-05-07 9:49 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64acfa0f-8047-07ad-ee3d-6c59afcf5bcb@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.