From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720E1C282CA for ; Sun, 27 Jan 2019 21:10:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32FBD20880 for ; Sun, 27 Jan 2019 21:10:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MZlsmGmm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbfA0VJ7 (ORCPT ); Sun, 27 Jan 2019 16:09:59 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40398 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726920AbfA0VJ6 (ORCPT ); Sun, 27 Jan 2019 16:09:58 -0500 Received: by mail-wr1-f66.google.com with SMTP id p4so15879036wrt.7 for ; Sun, 27 Jan 2019 13:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XjYe1PPH5OFH0crhTicGspSxdhojOsMnWSNHKCR35OQ=; b=MZlsmGmmG/DQJQkF13Kl/ZT3+gt4T7uEI782M06KZV17/Dly6gLdbWKfFJyzufeFAu CYOHXH8hCeCaLi7J7cBSZZIg5ALALUOesPhmG9esymtcqXyYAHMKq0kfHDVzCEdc77TU tvhS2csZa0R2nNbNCP4gGHwOsx7Z4s0+VVNDWOv7sJxeKwA/LGqVmm47zbdd941CeDA0 Ep5tsFtKjF2CsMznu4Si3kt2sg+Y1nCJbOYGCRBCNlGXjvZqNPg01Fl6vtdHhEt3RRk9 mjblnmBwhy0Wd5PQgb+GfUIs53/ftytVEhuwQYGaSw19RQ5FDn+G6fzomC5CZ68VTfbT Bw8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XjYe1PPH5OFH0crhTicGspSxdhojOsMnWSNHKCR35OQ=; b=WIzQG6iNtLwRZMkLKrZLp2SY6Z0tDW/FMVmpLlXQmKn2yyrITCodT+lSmmmOLArjm/ XIomN0db0CAaJ1mXxqBKAjzVZY+MuMqD2IvIgDD34/uho+zyXtNy16UDt7OG+WB3TszQ 9KeJqjwhWcpK3MsKw7A5txrqI9WRWHutSix10sw9M46EWD7dF98yh4mrhhZm/Y8vl1e4 MHIHe38tzGN1ysfTgSwAd0SyEZ9nrQ1Vea+3s4K9zZ9Q7Y2H/PwTvtwZMTZI5eLJ6CfT 1YeqRikkwbbE+MwTwsd6/oJtuSJpQI6SNPLXCAsyl3FAxP1hnQS5p8mpJxcFkOKrW+LR MxdA== X-Gm-Message-State: AJcUukehSqg4s7bJEEeQpVQShtpSRwvpMd0yxp+kwmrotzIiy0A51gDx f5WKyprhnMJM1MytyaQ9A1ATwBId X-Google-Smtp-Source: ALg8bN4AIjdNBic9PD8WPFnIlbimbh6IAr2MSJzRvR76OuBxZ7kSDSg0jC3a3ScfiixhNP/D+Lcu1A== X-Received: by 2002:adf:ce86:: with SMTP id r6mr20148081wrn.257.1548623396619; Sun, 27 Jan 2019 13:09:56 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:a0e2:30d5:7099:fd82? (p200300EA8BF1E200A0E230D57099FD82.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:a0e2:30d5:7099:fd82]) by smtp.googlemail.com with ESMTPSA id o3sm86161520wrs.30.2019.01.27.13.09.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Jan 2019 13:09:55 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 To: Marc Haber Cc: "netdev@vger.kernel.org" References: <20190122161005.GA27062@torres.zugschlus.de> <3c3249f8-6e09-43a7-e4e2-f4fc2b9531ab@gmail.com> <20190125055919.GB27062@torres.zugschlus.de> <6ae02156-8903-70fd-675f-a5aee9c452b4@gmail.com> <20190125120210.GC27062@torres.zugschlus.de> <548c1682-ad7c-3a0a-b2ea-2207f328b070@gmail.com> <20190126135640.GD27062@torres.zugschlus.de> <1a17454a-3017-7283-89d6-206681ca4c47@gmail.com> <20190126170752.GE27062@torres.zugschlus.de> <6ecafe07-3278-a9c4-d76d-971c0df26ce8@gmail.com> <20190127205555.GF27062@torres.zugschlus.de> From: Heiner Kallweit Message-ID: <64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com> Date: Sun, 27 Jan 2019 22:09:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190127205555.GF27062@torres.zugschlus.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 27.01.2019 21:55, Marc Haber wrote: > On Sat, Jan 26, 2019 at 08:22:33PM +0100, Heiner Kallweit wrote: >> You could go with this range: >> from 4ff364662814 ("r8169: replace get_protocol with vlan_get_protocol") >> to 649f0837a8cc ("r8169: fix broken Wake-on-LAN from S5 (poweroff)") > > I am quite inexperienced with bisecting and am therefore giving a better > account of my actions here. > > [2/4994]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git pull > remote: Counting objects: 786, done. > remote: Compressing objects: 100% (197/197), done. > remote: Total 786 (delta 659), reused 697 (delta 589) > Receiving objects: 100% (786/786), 146.00 KiB | 1.20 MiB/s, done. > Resolving deltas: 100% (659/659), completed with 237 local objects. >>>From git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux > ba6069759381..1fc7f56db7a7 master -> origin/master > You are not currently on a branch. > 1 [3/4995]mh@fan:~/linux/git/linux ((v4.18.16) %) $ git checkout 4ff364662814 > Checking out files: 100% (13994/13994), done. > Previous HEAD position was 6b3252287aa2 Linux 4.18.16 > HEAD is now at 4ff364662814 r8169: replace get_protocol with vlan_get_protocol > [4/4996]mh@fan:~/linux/git/linux ((4ff364662814...) %) $ git bisect start drivers/net/ethernet/realtek/r8169.c > [5/4997]mh@fan:~/linux/git/linux ((4ff364662814...) %|BISECTING) $ > (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try) > this boots and wakes up on magic packet from suspend to ram > [2/4994]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git bisect good > [3/4995]mh@fan:~/linux/git/linux ((4ff364662814...) *%|BISECTING) $ git checkout 649f0837a8cc > Checking out files: 100% (21794/21794), done. > M scripts/package/Makefile > Previous HEAD position was 4ff364662814 r8169: replace get_protocol with vlan_get_protocol > HEAD is now at 649f0837a8cc r8169: fix broken Wake-on-LAN from S5 (poweroff) > [4/4996]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ > (copy 4.20 config, make oldconfig, say no to everything, make deb-pkg, install and try) > this boots and does not wake up from StR on magic packet, after > waking up with any key on the keyboard I had an amdgpu issue on the console > and a dead console, but was able to ssh in and reboot. > > [2/4994]mh@fan:~/linux/git/linux ((649f0837a8cc...) *%|BISECTING) $ git > bisect bad > Bisecting: 33 revisions left to test after this (roughly 5 steps) > [098b01ad9837b4d4d0022f407300f069a999e55a] r8169: don't include asm > headers directly > [3/4995]mh@fan:~/linux/git/linux ((098b01ad9837...) *%|BISECTING) $ > > I think I am on the right way here, am I? > > Greetings > Marc > Yes. All you have to do after each "git bisect good/bad" is build again, test, and make current build as good or bad.