From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Sat, 29 Oct 2016 14:12:46 +0200 Subject: [U-Boot] [PATCH 00/11] sunxi: Add full SPL support for sun9i (A80) In-Reply-To: References: <20161028102138.8678-1-wens@csie.org> <33fa2d19-0ca9-86f9-2302-483a650c5fd1@redhat.com> Message-ID: <64b86a00-6ead-63cd-0531-63888ac63eb3@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 29-10-16 03:16, Chen-Yu Tsai wrote: > On Sat, Oct 29, 2016 at 1:30 AM, Hans de Goede wrote: >> Hi Chen-Yu, >> >> On 28-10-16 12:21, Chen-Yu Tsai wrote: >>> >>> Hi everyone, >>> >>> This series adds full SPL with DRAM initialization for sun9i (A80). >>> The bulk of the work was done by the people at Theobroma Systems. >>> Their work can be found here: >>> >>> https://git.theobroma-systems.com/armadillo-u-boot.git/ >>> >>> I picked the essential patches and cleaned them up a bit more, >>> and added commit messages if they were missing. >>> >>> As the DRAM bits are essentially a code dump with some cleanups and >>> some bits disabled, expect many warnings. Checkpatch is still not >>> happy with it. >>> >>> I've tested the series on both my A80 boards, which I've added >>> defconfigs for in the last 2 patches. My A80 Optimus does not >>> boot from micro SD, so I'm still FEL booting that one. But my >>> Cubieboard 4 is now standalone. >>> >>> As usual, please have a look, test if possible. >> >> >> Awesome, thanks for doing this and it was good to have >> some face2face time at ELCE. >> >> I've merged this into my personal sunxi-wip u-boot branch, >> I've made 2 changes: >> >> 1) in : ?sunxi: DRAM initialisation for sun9i" there are a >> lot of #if 0 #endif blocks, most of these document some features >> which we may want to enable in the future, but a few were just >> dead weight IMHO, so I've pruned a few > > Thanks. I suppose some of the testing and verbose debug calls > aren't needed. Most of the #if 0 blocks within data structures > were C99 // comments that I fixed up to get checkpatch happy. > > About the features, I was already half way through the clock > code cleanup when Maxime pointed me to Theobroma's repository, > so I could add and test sigma delta modulation for PLL DDR. If you want to, I would be fine with adding that, but IIRC we are not doing that on a number of other SoC generations either, not sure what this would bring it us. So it is up to you. > For the other types of DRAM we could clean it up, but there's > really no hardware to test it on. I would not bother with this until someone with the relevant hardware comes forward. >> 2) in : "sunxi: Add support for A80 Optimus board", we already >> have a configs/Merrii_A80_Optimus_defconfig, so I've made the patch >> update that instead of adding a new defconfig > > Cool. I didn't notice. > >> I have not tested this yet, I will do tomorrow, assuming it >> works for me too I will include it in my next pull-req (*) and >> try to get it included in the 2016.11 release, yes the merge >> window has closed, but the changes here are very isolated so >> I will try and see what Tom says :) > > Do you need me to send a v2 addressing review comments? No need, I've fixed everything up in my own tree. Regards, Hans > > Thanks > ChenYu > >> >> Regards, >> >> Hans >> >> >> *) Which I hope to send out this weekend >> >> >> >> >>> >>> >>> Regards >>> ChenYu >>> >>> >>> Chen-Yu Tsai (5): >>> sunxi: Set default CPU clock rate to 1008 MHz for sun9i (A80) >>> sunxi: Add support for SID e-fuses on sun9i >>> sunxi: Add default zq value for sun9i (A80) >>> sunxi: Add support for A80 Optimus board >>> sunxi: Add support for Cubieboard4 >>> >>> Philipp Tomsich (6): >>> sunxi: DRAM initialisation for sun9i >>> sunxi: add gtbus-initialisation for sun9i >>> sunxi: Enable SMP mode for the boot CPU on sun9i (A80) >>> sunxi: add initial clock setup for sun9i for SPL >>> sunxi: enable SPL for sun9i >>> sunxi: add MMC pinmux setup for SDC2 on sun9i >>> >>> arch/arm/include/asm/arch-sunxi/clock_sun9i.h | 116 ++- >>> arch/arm/include/asm/arch-sunxi/cpu_sun9i.h | 10 + >>> arch/arm/include/asm/arch-sunxi/dram.h | 2 + >>> arch/arm/include/asm/arch-sunxi/dram_sun9i.h | 275 +++++++ >>> arch/arm/include/asm/arch-sunxi/gtbus.h | 21 + >>> arch/arm/include/asm/arch-sunxi/gtbus_sun9i.h | 89 +++ >>> arch/arm/mach-sunxi/Makefile | 2 + >>> arch/arm/mach-sunxi/board.c | 3 +- >>> arch/arm/mach-sunxi/clock.c | 6 + >>> arch/arm/mach-sunxi/clock_sun9i.c | 146 +++- >>> arch/arm/mach-sunxi/dram_sun9i.c | 1059 >>> +++++++++++++++++++++++++ >>> arch/arm/mach-sunxi/gtbus_sun9i.c | 48 ++ >>> board/sunxi/Kconfig | 10 +- >>> board/sunxi/MAINTAINERS | 10 + >>> board/sunxi/board.c | 7 + >>> configs/A80_Optimus_defconfig | 18 + >>> configs/Cubieboard4_defconfig | 18 + >>> 17 files changed, 1818 insertions(+), 22 deletions(-) >>> create mode 100644 arch/arm/include/asm/arch-sunxi/dram_sun9i.h >>> create mode 100644 arch/arm/include/asm/arch-sunxi/gtbus.h >>> create mode 100644 arch/arm/include/asm/arch-sunxi/gtbus_sun9i.h >>> create mode 100644 arch/arm/mach-sunxi/dram_sun9i.c >>> create mode 100644 arch/arm/mach-sunxi/gtbus_sun9i.c >>> create mode 100644 configs/A80_Optimus_defconfig >>> create mode 100644 configs/Cubieboard4_defconfig >>> >>