Re: [PATCH][dunfell] coreutils: don't split stdbuf to own package with single-binary

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Fri, 2020-07-03 at 09:36 +0200, Rasmus Villemoes wrote:
> Commit 992cec44 (coreutils: Move stdbuf into an own package
> coreutils-stdbuf) breaks package-qa when the single-binary
> PACKAGECONFIG is used:
> 
> ERROR: coreutils-8.31-r0 do_package_qa: QA Issue: /usr/bin/stdbuf
> contained in package coreutils-stdbuf requires /usr/bin/coreutils,
> but no providers found in RDEPENDS_coreutils-stdbuf? [file-rdeps]
> ERROR: coreutils-8.31-r0 do_package_qa: QA run found fatal errors.
> Please consider fixing them.
> ERROR: Logfile of failure stored in:
> /mnt/ext4/projects/deif/pdsystems/yocto/tmp-glibc/work/ppce300c3-oe-
> linux/coreutils/8.31-r0/temp/log.do_package_qa.5594
> ERROR: Task (/mnt/ext4/projects/deif/pdsystems/yocto/meta-
> poky/meta/recipes-core/coreutils/coreutils_8.31.bb:do_package_qa)
> failed with exit code '1'
> 
> With that PACKAGECONFIG, /usr/bin/stdbuf is just a simple "script"
> containing the single line
> 
>   #!/usr/bin/coreutils --coreutils-prog-shebang=stdbuf
> 
> Since there's no point splitting stdbuf to its own package when all
> the functionality is in the single big coreutils binary anyway, fix
> this by not creating the separate stdbuf package for the single-
> binary
> case.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> The same issue exists in master, which has been bumped to 8.32, but
> other than that the patch should apply cleanly there as well.

Does this problem exist for other packages in coreutils? I'd suspect it
does in which case why is stdbuf special? Whilst I realise there is a
problem here is the correct fix not:

RDEPENDS_coreutils-stdbuf_class-target += "${@bb.utils.contains('PACKAGECONFIG', 'single-binary', '', 'coreutils', d)}"

?

As Alex says, this would need to be merged in master before we can even
consider it for dunfell.

Cheers,

Richard