From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B056CC433EF for ; Wed, 22 Dec 2021 04:18:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242324AbhLVES5 (ORCPT ); Tue, 21 Dec 2021 23:18:57 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:60102 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242314AbhLVES4 (ORCPT ); Tue, 21 Dec 2021 23:18:56 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R611e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=chengyou@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0V.OXpdI_1640146733; Received: from 30.43.106.56(mailfrom:chengyou@linux.alibaba.com fp:SMTPD_---0V.OXpdI_1640146733) by smtp.aliyun-inc.com(127.0.0.1); Wed, 22 Dec 2021 12:18:54 +0800 Message-ID: <64bebb14-d0d2-790d-6507-9cb0639620db@linux.alibaba.com> Date: Wed, 22 Dec 2021 12:18:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH rdma-next 07/11] RDMA/erdma: Add verbs implementation Content-Language: en-US From: Cheng Xu To: Bernard Metzler , Leon Romanovsky Cc: "jgg@ziepe.ca" , "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , "KaiShen@linux.alibaba.com" , "tonylu@linux.alibaba.com" References: <20211221024858.25938-1-chengyou@linux.alibaba.com> <20211221024858.25938-8-chengyou@linux.alibaba.com> <252268cf-55d6-35b1-3daf-20b231c2d8ee@linux.alibaba.com> In-Reply-To: <252268cf-55d6-35b1-3daf-20b231c2d8ee@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 12/22/21 11:11 AM, Cheng Xu wrote: > > > On 12/21/21 11:20 PM, Bernard Metzler wrote: >>> -----Original Message----- >>> From: Leon Romanovsky >>> Sent: Tuesday, 21 December 2021 14:32 >>> To: Cheng Xu >>> Cc: jgg@ziepe.ca; dledford@redhat.com; linux-rdma@vger.kernel.org; >>> KaiShen@linux.alibaba.com; tonylu@linux.alibaba.com >>> Subject: [EXTERNAL] Re: [PATCH rdma-next 07/11] RDMA/erdma: Add verbs >>> implementation >>> >>> On Tue, Dec 21, 2021 at 10:48:54AM +0800, Cheng Xu wrote: >>>> The RDMA verbs implementation of erdma is divided into three files: >>>> erdma_qp.c, erdma_cq.c, and erdma_verbs.c. Internal used functions and >>>> datapath functions of QP/CQ are put in erdma_qp.c and erdma_cq.c, the >>> reset >>>> is in erdma_verbs.c. >>>> >>>> Signed-off-by: Cheng Xu >>>> --- >>>>   drivers/infiniband/hw/erdma/erdma_cq.c    |  201 +++ >>>>   drivers/infiniband/hw/erdma/erdma_qp.c    |  624 +++++++++ >>>>   drivers/infiniband/hw/erdma/erdma_verbs.c | 1477 >>>> +++++++++++++++++++++ >>>>   3 files changed, 2302 insertions(+) >>>>   create mode 100644 drivers/infiniband/hw/erdma/erdma_cq.c >>>>   create mode 100644 drivers/infiniband/hw/erdma/erdma_qp.c >>>>   create mode 100644 drivers/infiniband/hw/erdma/erdma_verbs.c >>> >>> >>> Please no inline functions in .c files and no void casting for the >>> return values of functions. >>> >>> <...> >>> >>>> diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c >>> b/drivers/infiniband/hw/erdma/erdma_qp.c >>>> new file mode 100644 >>>> index 000000000000..8c02215cee04 >>>> --- /dev/null >>>> +++ b/drivers/infiniband/hw/erdma/erdma_qp.c >>>> @@ -0,0 +1,624 @@ >>>> +// SPDX-License-Identifier: GPL-2.0 >>>> +/* >>>> + * Authors: Cheng Xu >>>> + *          Kai Shen >>>> + * Copyright (c) 2020-2021, Alibaba Group. >>>> + * >>>> + * Authors: Bernard Metzler >>>> + *          Fredy Neeser >>>> + * Copyright (c) 2008-2016, IBM Corporation >>> >>> What does it mean? >>> >> >> Significant parts of the driver have been taken from siw it seems. >> Probably really from an old version of it. >> In that case I would have recommended to take the upstream siw >> code, which has been cleaned from those issues we now see again >> (including debugfs code, extern definitions, inline in .c code, >> casting issues, etc etc.). Why starting in 2020 with >> code from 2016, if better code is available? >> >> Bernard. > > First of all, thank you for developing siw, Bernard and Fredy, so we > can build our erdma based on your work. > At the beginning, we started developing erdma driver in kernel > 4.9/4.19/5.10, and didn't know the upstream siw version since it is in Correction: At first we develop in kernel 4.9/4.19, kernel 5.10 was added to support later. Thanks, Cheng Xu > the newer kernel version. As a result, we develop erdma based on the > older version. > Thank you for your recommendation. We will check the differences and > take the upstream siw code if needed. > > Thanks, > Cheng Xu