From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB70C47082 for ; Thu, 3 Jun 2021 17:20:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FBAA6108E for ; Thu, 3 Jun 2021 17:20:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FBAA6108E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lor10-0006Ni-7p for qemu-devel@archiver.kernel.org; Thu, 03 Jun 2021 13:20:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loqxX-0001GY-Sm for qemu-devel@nongnu.org; Thu, 03 Jun 2021 13:16:43 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]:33549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loqxU-0007Qa-V4 for qemu-devel@nongnu.org; Thu, 03 Jun 2021 13:16:43 -0400 Received: by mail-pj1-x1033.google.com with SMTP id k22-20020a17090aef16b0290163512accedso3729330pjz.0 for ; Thu, 03 Jun 2021 10:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FtNAMkyuR6DdTqQtDmmjUjfmQ1AjtIwvxI4mVzNAENM=; b=fRbH8wLeK5VDMsZcHAhko31in/jmmXvvSymfwmIcMr7es8mTskeCQ5Rv7qY8CMl8Ol Rj4xwAsowSwfpem95tmbDYfo3kSX0VjyccfCH36k9V9GMqi5l97srSZJJ8Yr3MSPwf7m l2B7fTThwwtmx/6xn6kZbpc7lAMH73aQc0CUbOGhCtqAWpnqX1T4OXziWhNUuEJloMt/ vuoZzwpjHn0gskpGf7arxRDNn6Z+RwKPklRXRJ1gqO6cmIegDxdFhl9zwlyeQdlzjnoL LCKRFsrZUydqU2pCxGm8kvW146kouj3B0I0LJ/ET7PC2hSSXF9N9qBhQwocLsc9resYl qIog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FtNAMkyuR6DdTqQtDmmjUjfmQ1AjtIwvxI4mVzNAENM=; b=Q+2OiYNtQVjzjoyyz3pxyjXuQTAC/yQoYuZCYfYNqEkr7dmDUfEqBhyOoHIm0v/sHt mkSEh+CfIfIQ3aZUbpmNzXWrrqqpls4Dp6IltOl7aOPGhxN+30dVtoNvf5B2yGsOtJG+ LqdQTxD/0mTP+89JB8usoeZV4i29B4AeVMgTrVrBOJ4paiYs7Dl2UPOkEuxud4DiIhgO RLXqt93Lh72eMlnIXtIaKEQS/7B56iWi49VgPJy7INE4oPeAit4RQHsxr3q++wXerrW/ e0TLPIUm4+jovNnDVbxrGzlGUJEJZ4B4i4KLtrMgsdRYS8m7az47LS3Nn/fsHvQUkO2Q KM8w== X-Gm-Message-State: AOAM533mLnNHDqO+5yY83NxVIYqxVX5tU5tUimAYHGGP4CQS+Qtx6pze bcB9P6dAtsCDsHSG/vMZdwWIWA== X-Google-Smtp-Source: ABdhPJyonSCDztWwjgUBcQKqXjG4PDkPeYI5nQUIA6tUWxwDpjj255hmim3ijKBWy/8BchZwtqZskA== X-Received: by 2002:a17:902:7d83:b029:105:8b10:629e with SMTP id a3-20020a1709027d83b02901058b10629emr220260plm.0.1622740599371; Thu, 03 Jun 2021 10:16:39 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id h16sm1325077pfk.119.2021.06.03.10.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 10:16:39 -0700 (PDT) Subject: Re: [PATCH v2 04/26] s390x/tcg: Simplify vop64_2() handling To: David Hildenbrand , qemu-devel@nongnu.org References: <20210517142739.38597-1-david@redhat.com> <20210517142739.38597-5-david@redhat.com> From: Richard Henderson Message-ID: <64d0fa38-7f8d-b6ed-d871-68b97fa20d9e@linaro.org> Date: Thu, 3 Jun 2021 10:16:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210517142739.38597-5-david@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1033; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1033.google.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.603, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Cornelia Huck , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/17/21 7:27 AM, David Hildenbrand wrote: > +#define DEF_GVEC_VOP2_FN(NAME, FN, BITS) \ > +void HELPER(gvec_##NAME##BITS)(void *v1, const void *v2, CPUS390XState *env, \ > + uint32_t desc) \ > +{ \ > + const uint8_t erm = extract32(simd_data(desc), 4, 4); \ > + const uint8_t se = extract32(simd_data(desc), 3, 1); \ bool for se? The argumemt to vopN_2 is bool... Otherwise, Reviewed-by: Richard Henderson r~