From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C71DC433F5 for ; Thu, 13 Jan 2022 06:35:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 06F40833A2; Thu, 13 Jan 2022 07:35:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642055746; bh=/8AsAkt9F7LIipdMktWEnk3nVVli2ZPRpFVyYHKzGdo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w6j9Md6OaRXWJSQwF3LdCalp1HAApQxgkhkgR2ZWN53cbhmIYcvjqNI2S3eXMfT2o FyR0Q+PjPgLCFlcic9Kbv0T3Q8rge+X+nnoaKRTzC+eioImthKVFUhnHeydCRzaY7x kPO5BEC7snZwcgSj1mVC5FujzRaodHcanx/DqgZJkW+KmXCFOCqEZozWC0jgGDnRP4 fUHnF6H/WoUuJUxEuZkiporVseTQn4CzutdciTEVwhlxQJW/WpTS2/EnK0DmS7taTi ImBnUr5jerIrqbYzU1/9THYYVQbQjp/lqwru80mTUUQgGorOJu+THFTZmiKW/B1Iha +KXHXaxFxWPNg== Received: by phobos.denx.de (Postfix, from userid 109) id 96017833B4; Thu, 13 Jan 2022 07:35:44 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5A44D8338C for ; Thu, 13 Jan 2022 07:35:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4JZF716q7rzQj8m; Thu, 13 Jan 2022 07:35:41 +0100 (CET) Message-ID: <6502103a-c36e-79e5-8932-1ea21c56f3ff@denx.de> Date: Thu, 13 Jan 2022 07:35:37 +0100 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell v2 08/20] tools: kwbimage: Check the return value of image_headersz_v1() Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= , Chris Packham Cc: u-boot@lists.denx.de References: <20211221155416.8557-1-pali@kernel.org> <20220112172054.5961-1-pali@kernel.org> <20220112172054.5961-9-pali@kernel.org> From: Stefan Roese In-Reply-To: <20220112172054.5961-9-pali@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/12/22 18:20, Pali Rohár wrote: > Function image_headersz_v1() may return zero on fatal errors. > In this case the function already printed an error message. > > Check the return value of image_headersz_v1() in kwbimage_generate(), > and exit on zero value with EXIT_FAILURE. > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > tools/kwbimage.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/kwbimage.c b/tools/kwbimage.c > index c0f1bdac0210..a5b518f60bc8 100644 > --- a/tools/kwbimage.c > +++ b/tools/kwbimage.c > @@ -2029,6 +2029,10 @@ static int kwbimage_generate(struct image_tool_params *params, > > case 1: > alloc_len = image_headersz_v1(NULL); > + if (!alloc_len) { > + free(image_cfg); > + exit(EXIT_FAILURE); > + } > break; > > default: > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de