From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 10/27] net/ena: add lrte_timer dependency
	for linking
Date: Mon, 18 Jun 2018 10:30:00 +0200
Message-ID: <6508461.cpII4DF8a3@xps>
References: <20180607094322.14312-1-mk@semihalf.com> <3540745.n2F2IE3GfD@xps>
 <CAJMMOfOuB83Gq-LG_NgZZcDtnoefc2EwzrvCWuffggbSaW=Liw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, Marcin Wojtas <mw@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>,
 "Matushevsky, Alexander" <matua@amazon.com>, ferruh.yigit@intel.com
To: =?utf-8?B?TWljaGHFgg==?= Krawczyk <mk@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 79FCF968
 for <dev@dpdk.org>; Mon, 18 Jun 2018 10:30:05 +0200 (CEST)
In-Reply-To: <CAJMMOfOuB83Gq-LG_NgZZcDtnoefc2EwzrvCWuffggbSaW=Liw@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

18/06/2018 08:04, Micha=C5=82 Krawczyk:
> 2018-06-18 0:37 GMT+02:00 Thomas Monjalon <thomas@monjalon.net>:
> > 07/06/2018 11:43, Michal Krawczyk:
> >> ENA PMD is required to use librte_timer. The appropriate depndency must
> >> be added ifin case the DPDK will be built as shared library.
> >>
> >> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> >> ---
> >>  drivers/net/ena/Makefile | 1 +
> >>  mk/rte.app.mk            | 1 +
> >>  2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/net/ena/Makefile b/drivers/net/ena/Makefile
> >> index 43339f3b9..ff9ce315b 100644
> >> --- a/drivers/net/ena/Makefile
> >> +++ b/drivers/net/ena/Makefile
> >> @@ -58,5 +58,6 @@ CFLAGS +=3D $(INCLUDES)
> >>  LDLIBS +=3D -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> >>  LDLIBS +=3D -lrte_ethdev -lrte_net -lrte_kvargs
> >>  LDLIBS +=3D -lrte_bus_pci
> >> +LDLIBS +=3D -lrte_timer
> >>
> >>  include $(RTE_SDK)/mk/rte.lib.mk
> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> >> index 1e32c83e7..c70bc254e 100644
> >> --- a/mk/rte.app.mk
> >> +++ b/mk/rte.app.mk
> >> @@ -60,6 +60,7 @@ endif
> >>
> >>  _LDLIBS-y +=3D --whole-archive
> >>
> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          +=3D -lrte_timer
> >
> > Why is it added in rte.app.mk? It is already there, few lines below.
>=20
> I think that's because it wasn't present on the version I was
> preparing the patch (18.02) and I didn't notice that it was added
> meantime when I was rebasing this patch.
>=20
> This patch is already merged to dpdk-next-net. Should I add a patch
> that is reverting this change there?

I can remove it when pulling next-net today.