From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EF7CC433F5 for ; Fri, 27 May 2022 09:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350544AbiE0J2M (ORCPT ); Fri, 27 May 2022 05:28:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240627AbiE0J2L (ORCPT ); Fri, 27 May 2022 05:28:11 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F70B7D2; Fri, 27 May 2022 02:28:10 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 27so4383446ljw.0; Fri, 27 May 2022 02:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Krhf4p2A4F/OozPS2wYakVlCdwv1A4RoS750BCdPKcc=; b=Lw1bpYpSg6Xu8NYSj+hYo9JMrcr1uhDlArl5ZVRhx6dypMyJ7zKZ3kcR9dRux2FrPZ BmVJTGXFFCR3ba14zXc5mJ7+oYZxeWuzvLMfTDBudWpx7eTDF1zVAqJSsDFZW8FP0Jcv LCuSpakjj/F+JPoz5ggzjQkap3QhTs34BCJG+s4ZdWIy9hmIbtufuKALLsn+YPKZ/8Y1 qd7PP1O4Mth3HrZXpnbXWo5nZ5CHgpWaodAe2lFGAFpUYjnj5mWQ7XJMknD521TV5LqR E2e17Y6Y6xXevcEbzNJsgqd/z7Zr7cY6OsenyRBQd7sy54/cmLQLf1whxWN2zge/OB8W sCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Krhf4p2A4F/OozPS2wYakVlCdwv1A4RoS750BCdPKcc=; b=ZCRPsf1KVUc10SrZ9QjvxM3Z0/qU6XKc1y0a4D7Bcra9vuiIA+WbmN8q+ZsgRJG2Eo yC4yBzbBZIfP0VjW6kkTCAOQjN6t2QophnguqhXVoRI7qP1D0AldSDOTQHNGSf2aUa3C fS0ErL4PbMr2nOTzhIbGBbKw0c5spgfxzRFuikOBE4b6RxiR0/Ozvk8mjYtROKDDJIoG wPlnVvdbsg67KoZPVSzPjI1nPPDi5lmxxIbeGXNq+GvgFhFLfBmccWfIoCyiF3GKxzpR C8ozTkWM18Fv/Z2rcDEUxpUQAKHufCirYfSnpwew2od/YxdORf5rNZzGeCj8adR+gm8W gguA== X-Gm-Message-State: AOAM531EWxPPt3KjVJo5C3KMqAeKFW6XUyb8+XvlmPbD0HxG1nAeSUuz 32TDc/mTRfrbaL6ThQM4cDc= X-Google-Smtp-Source: ABdhPJyilFQbXSAMaOm+DGPi2n3CTBILPrU5RfGaNxR0GU6ym+ew2t5uYYPEGFHYpijTzWR52odNHQ== X-Received: by 2002:a05:651c:248:b0:253:d7cb:136 with SMTP id x8-20020a05651c024800b00253d7cb0136mr23043541ljn.65.1653643688369; Fri, 27 May 2022 02:28:08 -0700 (PDT) Received: from [192.168.0.192] ([194.146.248.76]) by smtp.gmail.com with ESMTPSA id k27-20020ac2457b000000b0047255d2114csm792432lfm.123.2022.05.27.02.28.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 May 2022 02:28:07 -0700 (PDT) Message-ID: <6531e5e0-d4d5-1a16-5c5c-e8ff443f3275@gmail.com> Date: Fri, 27 May 2022 11:28:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] media: platform: samsung: s5p-jpeg: replace ternary operator with max() Content-Language: en-US To: Guo Zhengkui , Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab , "moderated list:ARM/SAMSUNG S5P SERIES JPEG CODEC SUPPORT" , "open list:ARM/SAMSUNG S5P SERIES JPEG CODEC SUPPORT" , open list Cc: zhengkui_guo@outlook.com References: <1761ab1a-68ce-4946-24d4-8f4f9575e735@xs4all.nl> <20220518120836.126368-1-guozhengkui@vivo.com> From: Andrzej Pietrasiewicz In-Reply-To: <20220518120836.126368-1-guozhengkui@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guo Zhengkui, Sorry about the delay. W dniu 18.05.2022 o 14:08, Guo Zhengkui pisze: > Fix the following coccicheck warning: > > drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:1712:24-25: > WARNING opportunity for max() > > max() macro is defined in include/linux/minmax.h. It avoids multiple > evaluations of the arguments when non-constant and performs strict > type-checking. > > Signed-off-by: Guo Zhengkui Acked-by: Andrzej Pietrasiewicz > --- > v1 -> v2: Change the subject according to Hans Verkuil's suggestion. > > drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > index 456287186ad8..55814041b8d8 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > @@ -1709,7 +1709,7 @@ static int exynos3250_jpeg_try_downscale(struct s5p_jpeg_ctx *ctx, > w_ratio = ctx->out_q.w / r->width; > h_ratio = ctx->out_q.h / r->height; > > - scale_factor = w_ratio > h_ratio ? w_ratio : h_ratio; > + scale_factor = max(w_ratio, h_ratio); > scale_factor = clamp_val(scale_factor, 1, 8); > > /* Align scale ratio to the nearest power of 2 */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CD43C433F5 for ; Fri, 27 May 2022 09:29:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=na+nLPBRzGW/JJLXoLboWgF80LiCfQCk7ZL6RAO0uWg=; b=ZpoKXF72Fiq8At qKoCqxUlFyk4G6JSr35LyNA5lwhk2D5B+60W1YgOK92z6+TLwaGDmAf2zR6T5PH+VXcLBAeeudcKy xNwm9pKalQyqTyZqE/C2Xb5biCtHfX0wuQrz6GcNal8/cg4toLjQtriJV8AbY9i9VWj8q9+hrA+2H F6KfTVg8O02SRQoNQF9KjY+cMLlds4T+V+ZJV5tNE2EnmmrOTVPLyPB5HQ2EOoB7X/cSc+QDdmXaM BhKLx94rVmPelORHfhYQRHMZMIpePtJKgWf1+tyrAAdsDa0XSB/EKf8HPZZCElWNN2Bmy93j/XQgc PaYLxzj/mXookdMHz3+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuWGV-00HBe4-Ls; Fri, 27 May 2022 09:28:15 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuWGS-00HBbs-1g for linux-arm-kernel@lists.infradead.org; Fri, 27 May 2022 09:28:13 +0000 Received: by mail-lj1-x22e.google.com with SMTP id u7so4315619ljd.11 for ; Fri, 27 May 2022 02:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Krhf4p2A4F/OozPS2wYakVlCdwv1A4RoS750BCdPKcc=; b=Lw1bpYpSg6Xu8NYSj+hYo9JMrcr1uhDlArl5ZVRhx6dypMyJ7zKZ3kcR9dRux2FrPZ BmVJTGXFFCR3ba14zXc5mJ7+oYZxeWuzvLMfTDBudWpx7eTDF1zVAqJSsDFZW8FP0Jcv LCuSpakjj/F+JPoz5ggzjQkap3QhTs34BCJG+s4ZdWIy9hmIbtufuKALLsn+YPKZ/8Y1 qd7PP1O4Mth3HrZXpnbXWo5nZ5CHgpWaodAe2lFGAFpUYjnj5mWQ7XJMknD521TV5LqR E2e17Y6Y6xXevcEbzNJsgqd/z7Zr7cY6OsenyRBQd7sy54/cmLQLf1whxWN2zge/OB8W sCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Krhf4p2A4F/OozPS2wYakVlCdwv1A4RoS750BCdPKcc=; b=u9/DyT7IOo07Xo0P2ME4MWjKUWyUeus4F/GMUGDV9pV1rC5zrcZHJk7JzUnDSgOTdF 7D2ZVaDo9+yN2TlJr63z/BDd3znIANNEdrOde3X6o70O36ZnlGmJOUMvwCYTC8Wmr2BT dek5HdrG2QRgnzTUGIl+u9zcmAsCTH3cS4k5Q5QLcDxfaw5DbOMPvrnLp5GNidmKX1rB Yx0YUZzVAQO2OzgCdFiRty+PYfNusBytcFTv9KVq3H/w2JCtuHrKSDeRkGxcdt6Yi43p R0UAVLvlx6vCpruqZNeZk0WJkymyi+pWzCTnCWf3vVe2WWE4sOyOPj73G0Syh9h8Zi2I BV/g== X-Gm-Message-State: AOAM533SiSU4MaHzq10cTTN3QUGFf+Lews7/LrDXIj+UjfxSLq8p84hE yDgkLsUGb47WaAswbPTN9dA= X-Google-Smtp-Source: ABdhPJyilFQbXSAMaOm+DGPi2n3CTBILPrU5RfGaNxR0GU6ym+ew2t5uYYPEGFHYpijTzWR52odNHQ== X-Received: by 2002:a05:651c:248:b0:253:d7cb:136 with SMTP id x8-20020a05651c024800b00253d7cb0136mr23043541ljn.65.1653643688369; Fri, 27 May 2022 02:28:08 -0700 (PDT) Received: from [192.168.0.192] ([194.146.248.76]) by smtp.gmail.com with ESMTPSA id k27-20020ac2457b000000b0047255d2114csm792432lfm.123.2022.05.27.02.28.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 May 2022 02:28:07 -0700 (PDT) Message-ID: <6531e5e0-d4d5-1a16-5c5c-e8ff443f3275@gmail.com> Date: Fri, 27 May 2022 11:28:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] media: platform: samsung: s5p-jpeg: replace ternary operator with max() Content-Language: en-US To: Guo Zhengkui , Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab , "moderated list:ARM/SAMSUNG S5P SERIES JPEG CODEC SUPPORT" , "open list:ARM/SAMSUNG S5P SERIES JPEG CODEC SUPPORT" , open list Cc: zhengkui_guo@outlook.com References: <1761ab1a-68ce-4946-24d4-8f4f9575e735@xs4all.nl> <20220518120836.126368-1-guozhengkui@vivo.com> From: Andrzej Pietrasiewicz In-Reply-To: <20220518120836.126368-1-guozhengkui@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220527_022812_143859_3DCDCE8F X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgR3VvIFpoZW5na3VpLAoKU29ycnkgYWJvdXQgdGhlIGRlbGF5LgoKVyBkbml1IDE4LjA1LjIw MjIgb8KgMTQ6MDgsIEd1byBaaGVuZ2t1aSBwaXN6ZToKPiBGaXggdGhlIGZvbGxvd2luZyBjb2Nj aWNoZWNrIHdhcm5pbmc6Cj4gCj4gZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zYW1zdW5nL3M1cC1q cGVnL2pwZWctY29yZS5jOjE3MTI6MjQtMjU6Cj4gV0FSTklORyBvcHBvcnR1bml0eSBmb3IgbWF4 KCkKPiAKPiBtYXgoKSBtYWNybyBpcyBkZWZpbmVkIGluIGluY2x1ZGUvbGludXgvbWlubWF4Lmgu IEl0IGF2b2lkcyBtdWx0aXBsZQo+IGV2YWx1YXRpb25zIG9mIHRoZSBhcmd1bWVudHMgd2hlbiBu b24tY29uc3RhbnQgYW5kIHBlcmZvcm1zIHN0cmljdAo+IHR5cGUtY2hlY2tpbmcuCj4gCj4gU2ln bmVkLW9mZi1ieTogR3VvIFpoZW5na3VpIDxndW96aGVuZ2t1aUB2aXZvLmNvbT4KCkFja2VkLWJ5 OiBBbmRyemVqIFBpZXRyYXNpZXdpY3ogPGFuZHJ6ZWp0cDIwMTBAZ21haWwuY29tPgoKPiAtLS0K PiB2MSAtPiB2MjogQ2hhbmdlIHRoZSBzdWJqZWN0IGFjY29yZGluZyB0byBIYW5zIFZlcmt1aWwn cyBzdWdnZXN0aW9uLgo+IAo+ICAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zYW1zdW5nL3M1cC1q cGVnL2pwZWctY29yZS5jIHwgMiArLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v c2Ftc3VuZy9zNXAtanBlZy9qcGVnLWNvcmUuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vc2Ft c3VuZy9zNXAtanBlZy9qcGVnLWNvcmUuYwo+IGluZGV4IDQ1NjI4NzE4NmFkOC4uNTU4MTQwNDFi OGQ4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vc2Ftc3VuZy9zNXAtanBl Zy9qcGVnLWNvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vc2Ftc3VuZy9zNXAt anBlZy9qcGVnLWNvcmUuYwo+IEBAIC0xNzA5LDcgKzE3MDksNyBAQCBzdGF0aWMgaW50IGV4eW5v czMyNTBfanBlZ190cnlfZG93bnNjYWxlKHN0cnVjdCBzNXBfanBlZ19jdHggKmN0eCwKPiAgIAl3 X3JhdGlvID0gY3R4LT5vdXRfcS53IC8gci0+d2lkdGg7Cj4gICAJaF9yYXRpbyA9IGN0eC0+b3V0 X3EuaCAvIHItPmhlaWdodDsKPiAgIAo+IC0Jc2NhbGVfZmFjdG9yID0gd19yYXRpbyA+IGhfcmF0 aW8gPyB3X3JhdGlvIDogaF9yYXRpbzsKPiArCXNjYWxlX2ZhY3RvciA9IG1heCh3X3JhdGlvLCBo X3JhdGlvKTsKPiAgIAlzY2FsZV9mYWN0b3IgPSBjbGFtcF92YWwoc2NhbGVfZmFjdG9yLCAxLCA4 KTsKPiAgIAo+ICAgCS8qIEFsaWduIHNjYWxlIHJhdGlvIHRvIHRoZSBuZWFyZXN0IHBvd2VyIG9m IDIgKi8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK