From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05AEBC54EBC for ; Thu, 12 Jan 2023 10:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CdWDoo5Tcdt3TBxLW73+RCJagGArHJHPNBDV9/XZzJc=; b=AxNM2ntSd/YwYs mlhDGNhyuJsOvFhUmGCMsj7n5gIw6wH7OUt1Ul+rOYEtmlZHpNmMtsA8LdFdActxByZhBiHc0fTt9 fhHPiuvnGWT+DZi13FUTBAoopUd659/im0fbQhaISXW6y5wNrAovRthwx/6L/9BBsySzPoLQVVfZ6 /EhRHaZLbPHRdBIzHAyD4GGbmv1tGZ+hr/0bcwTYZT4V0gp6tSZJBhEu71SwaMvGzt51KYOgkqkUF nGV8EdwMB0SZy0Nadw5T8S/OmkqZJXKCqx7n+i7TFnzQfDWLCouKLaLIlsjw+M4cuVioSUvKIMl39 e37k3O6nSqf1zFw7KDNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFuns-00EZiu-Ql; Thu, 12 Jan 2023 10:27:24 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFuno-00EZgT-DD for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 10:27:22 +0000 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 12 Jan 2023 19:27:14 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id E94292059054; Thu, 12 Jan 2023 19:27:13 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Thu, 12 Jan 2023 19:27:13 +0900 Received: from [10.212.157.104] (unknown [10.212.157.104]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 50398179F; Thu, 12 Jan 2023 19:27:13 +0900 (JST) Message-ID: <65428915-ab7a-3325-612d-5b99e97dc617@socionext.com> Date: Thu, 12 Jan 2023 19:27:12 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 20/23] arm64: dts: Update cache properties for socionext To: Pierre Gondois Cc: Rob Herring , Krzysztof Kozlowski , Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, LKML References: <20221107155825.1644604-1-pierre.gondois@arm.com> <20221107155825.1644604-21-pierre.gondois@arm.com> <29f24401-8e39-ea40-52f6-a03c428ca445@arm.com> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <29f24401-8e39-ea40-52f6-a03c428ca445@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_022720_593004_613EE7EE X-CRM114-Status: GOOD ( 17.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pierre, On 2023/01/12 17:33, Pierre Gondois wrote: > (subset for cc list) > Hello, > Just a reminder in case the patch was forgotten, > Regards, > Pierre > > On 11/7/22 16:57, Pierre Gondois wrote: >> The DeviceTree Specification v0.3 specifies that the cache node >> 'compatible' and 'cache-level' properties are 'required'. Cf. >> s3.8 Multi-level and Shared Cache Nodes >> The 'cache-unified' property should be present if one of the >> properties for unified cache is present ('cache-size', ...). >> >> Update the Device Trees accordingly. >> >> Signed-off-by: Pierre Gondois >> --- >> arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 1 + >> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 2 ++ >> arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi | 1 + >> 3 files changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> b/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> index 1c76b4375b2e..6e1e00939214 100644 >> --- a/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> @@ -52,6 +52,7 @@ cpu1: cpu@1 { >> >> l2: l2-cache { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> }; >> >> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> index 9308458f9611..db7d20a1a301 100644 >> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> @@ -86,10 +86,12 @@ cpu3: cpu@101 { >> >> a72_l2: l2-cache0 { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> >> a53_l2: l2-cache1 { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> }; >> >> diff --git a/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> b/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> index b0c29510a7da..9ce544c9ea0a 100644 >> --- a/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> +++ b/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> @@ -83,6 +83,7 @@ cpu3: cpu@3 { >> >> l2: l2-cache { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> }; >> Looks good to me. "cache-unified" will be added with other cache-related (size etc.) properties if needed. Reviewed-by: Kunihiko Hayashi Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79CF2C54EBC for ; Thu, 12 Jan 2023 10:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbjALKbV (ORCPT ); Thu, 12 Jan 2023 05:31:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235981AbjALKaU (ORCPT ); Thu, 12 Jan 2023 05:30:20 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 168245566A; Thu, 12 Jan 2023 02:27:14 -0800 (PST) Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 12 Jan 2023 19:27:14 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id E94292059054; Thu, 12 Jan 2023 19:27:13 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Thu, 12 Jan 2023 19:27:13 +0900 Received: from [10.212.157.104] (unknown [10.212.157.104]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 50398179F; Thu, 12 Jan 2023 19:27:13 +0900 (JST) Message-ID: <65428915-ab7a-3325-612d-5b99e97dc617@socionext.com> Date: Thu, 12 Jan 2023 19:27:12 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 20/23] arm64: dts: Update cache properties for socionext To: Pierre Gondois Cc: Rob Herring , Krzysztof Kozlowski , Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, LKML References: <20221107155825.1644604-1-pierre.gondois@arm.com> <20221107155825.1644604-21-pierre.gondois@arm.com> <29f24401-8e39-ea40-52f6-a03c428ca445@arm.com> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: <29f24401-8e39-ea40-52f6-a03c428ca445@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pierre, On 2023/01/12 17:33, Pierre Gondois wrote: > (subset for cc list) > Hello, > Just a reminder in case the patch was forgotten, > Regards, > Pierre > > On 11/7/22 16:57, Pierre Gondois wrote: >> The DeviceTree Specification v0.3 specifies that the cache node >> 'compatible' and 'cache-level' properties are 'required'. Cf. >> s3.8 Multi-level and Shared Cache Nodes >> The 'cache-unified' property should be present if one of the >> properties for unified cache is present ('cache-size', ...). >> >> Update the Device Trees accordingly. >> >> Signed-off-by: Pierre Gondois >> --- >> arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi | 1 + >> arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 2 ++ >> arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi | 1 + >> 3 files changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> b/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> index 1c76b4375b2e..6e1e00939214 100644 >> --- a/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld11.dtsi >> @@ -52,6 +52,7 @@ cpu1: cpu@1 { >> >> l2: l2-cache { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> }; >> >> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> index 9308458f9611..db7d20a1a301 100644 >> --- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> +++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi >> @@ -86,10 +86,12 @@ cpu3: cpu@101 { >> >> a72_l2: l2-cache0 { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> >> a53_l2: l2-cache1 { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> }; >> >> diff --git a/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> b/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> index b0c29510a7da..9ce544c9ea0a 100644 >> --- a/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> +++ b/arch/arm64/boot/dts/socionext/uniphier-pxs3.dtsi >> @@ -83,6 +83,7 @@ cpu3: cpu@3 { >> >> l2: l2-cache { >> compatible = "cache"; >> + cache-level = <2>; >> }; >> }; >> Looks good to me. "cache-unified" will be added with other cache-related (size etc.) properties if needed. Reviewed-by: Kunihiko Hayashi Thank you, --- Best Regards Kunihiko Hayashi