On 22.03.22 16:31, Anthony PERARD wrote:
> On Thu, Mar 10, 2022 at 08:34:16AM +0100, Juergen Gross wrote:
>> diff --git a/xen/include/Makefile b/xen/include/Makefile
>> index a3c2511f5f..b52a2da40c 100644
>> --- a/xen/include/Makefile
>> +++ b/xen/include/Makefile
>> @@ -77,6 +77,18 @@ $(obj)/compat/xlat.h: $(addprefix $(obj)/compat/.xlat/,$(xlat-y)) $(obj)/config/
>>   	cat $(filter %.h,$^) >$@.new
>>   	mv -f $@.new $@
>>   
>> +quiet_cmd_genhyp = GEN     $@
>> +define cmd_genhyp
>> +    awk -f $(src)/../scripts/gen_hypercall.awk <$< >$@
> 
> You should use "$(srctree)" instead of "$(src)/..".
> 
> $(srctree) always point to the source tree of the hypervisor. ( $(src)
> doesn't necessarily point to "include/" in the source tree. )

Okay.

> 
>> +endef
>> +
>> +all: $(obj)/xen/hypercall-defs.h
>> +
>> +$(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(src)/../scripts/gen_hypercall.awk FORCE
> 
> Here as well, it would be better to use $(srctree) instead of $(src)/.. .

Thanks,


Juergen