All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Simon Horman <horms@verge.net.au>, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes
Date: Mon, 30 Apr 2018 14:25:33 +0300	[thread overview]
Message-ID: <6550082.BIGKvazxOf@avalon> (raw)
In-Reply-To: <20180430105325.27753-1-kieran.bingham+renesas@ideasonboard.com>

Hi Kieran,

Thank you for the patch.

On Monday, 30 April 2018 13:53:25 EEST Kieran Bingham wrote:
> Commit 5d3b50d3c04d ("ARM: dts: renesas: r8a7790: Add FDP1 instances")
> introduced the FDP1 for the r8a7790, but broke the sort ordering of the
> device tree nodes.
> 
> Move the last VSP up to it's peers to correct the ordering.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7790.dtsi | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index c244aae7a026..b66a18af28f1 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1616,6 +1616,15 @@
>  			resets = <&cpg 128>;
>  		};
> 
> +		vsp@fe938000 {
> +			compatible = "renesas,vsp1";
> +			reg = <0 0xfe938000 0 0x8000>;
> +			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 127>;
> +			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> +			resets = <&cpg 127>;
> +		};
> +
>  		fdp1@fe940000 {
>  			compatible = "renesas,fdp1";
>  			reg = <0 0xfe940000 0 0x2400>;
> @@ -1643,15 +1652,6 @@
>  			resets = <&cpg 117>;
>  		};
> 
> -		vsp@fe938000 {
> -			compatible = "renesas,vsp1";
> -			reg = <0 0xfe938000 0 0x8000>;
> -			interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> -			clocks = <&cpg CPG_MOD 127>;
> -			power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
> -			resets = <&cpg 127>;
> -		};
> -
>  		jpu: jpeg-codec@fe980000 {
>  			compatible = "renesas,jpu-r8a7790",
>  				     "renesas,rcar-gen2-jpu";


-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2018-04-30 11:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22 10:35 [PATCH 0/4] ARM: dts: renesas: Enable FDP1 devices Laurent Pinchart
2018-04-22 10:35 ` [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances Laurent Pinchart
2018-04-23 11:07   ` Simon Horman
2018-04-26  9:29     ` Laurent Pinchart
2018-04-30  6:59       ` Simon Horman
2018-04-30 10:53         ` [PATCH] ARM: dts: r8a7790: Fix sort order of VSP1/FDP1 nodes Kieran Bingham
2018-04-30 11:25           ` Laurent Pinchart [this message]
2018-05-01  5:39             ` Simon Horman
2018-04-24 15:01   ` [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances Geert Uytterhoeven
2018-04-25  6:49     ` Simon Horman
2018-04-22 10:35 ` [PATCH 2/4] ARM: dts: renesas: r8a7791: " Laurent Pinchart
2018-04-23 11:04   ` Simon Horman
2018-04-24 15:01   ` Geert Uytterhoeven
2018-04-25  6:50     ` Simon Horman
2018-04-22 10:35 ` [PATCH 3/4] ARM: dts: renesas: r8a7793: " Laurent Pinchart
2018-04-23 11:04   ` Simon Horman
2018-04-24 15:02   ` Geert Uytterhoeven
2018-04-25  6:50     ` Simon Horman
2018-04-22 10:35 ` [PATCH 4/4] ARM: dts: renesas: r8a7794: " Laurent Pinchart
2018-04-23 11:05   ` Simon Horman
2018-04-24 15:02   ` Geert Uytterhoeven
2018-04-25  6:51     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6550082.BIGKvazxOf@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=horms@verge.net.au \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.