From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E980C433F5 for ; Sat, 5 Mar 2022 04:25:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231209AbiCEE0B (ORCPT ); Fri, 4 Mar 2022 23:26:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbiCEEZ7 (ORCPT ); Fri, 4 Mar 2022 23:25:59 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1693D53708; Fri, 4 Mar 2022 20:25:04 -0800 (PST) X-UUID: f91cd922797a4c02b60543ed4c65f1a6-20220305 X-UUID: f91cd922797a4c02b60543ed4c65f1a6-20220305 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1076188222; Sat, 05 Mar 2022 12:25:00 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Mar 2022 12:24:59 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Mar 2022 12:24:58 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 5 Mar 2022 12:24:57 +0800 Message-ID: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver From: Jiaxin Yu To: AngeloGioacchino Del Regno , CC: , , , , , , , , , , , , , , , Date: Sat, 5 Mar 2022 12:24:57 +0800 In-Reply-To: References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: > Il 17/02/22 14:41, Jiaxin Yu ha scritto: > > Mt6366 is a new version of mt6358, and they are same about audio > > part. > > So we can reuse the driver of mt6358. > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > I'm sorry but this commit makes very little sense. > > If you want to advertise MT6366 support, please write a note and/or > a new compatible string inside of the mt6358 driver (and dt- > bindings), > then, please drop this commit. > Hello angelogioacchino, Thank you for your advice. If I add a new compatible string inside of the mt6358 driver and dt- bindings, then the machine driver which want to use mt6366 should select SND_SOC_MT6358. like below: config SND_SOC_MT8186_MT6366_DA7219_MAX98357 tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A codec" depends on I2C && GPIOLIB depends on SND_SOC_MT8186 && MTK_PMIC_WRAP select SND_SOC_MT6366 ==> SND_SOC_MT6358 ... I just doubt it's enough to make sense. I originally wanted to put this relationship in the sound/soc/codecs layer. So that this relationship is not perceived by users(machine driver). However, if the general practice is like this, I will adopt your suggestion. Thank you again. > > > --- > > sound/soc/codecs/Kconfig | 8 ++++++++ > > sound/soc/codecs/Makefile | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > > index 8fa24783ce01..6631094678f5 100644 > > --- a/sound/soc/codecs/Kconfig > > +++ b/sound/soc/codecs/Kconfig > > @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS > > imply SND_SOC_MT6351 > > imply SND_SOC_MT6358 > > imply SND_SOC_MT6359 > > + imply SND_SOC_MT6366 > > imply SND_SOC_MT6660 > > imply SND_SOC_NAU8315 > > imply SND_SOC_NAU8540 > > @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET > > for ASoC codec soc-jack detection mechanism. > > Select N if you don't have jack on board. > > > > +config SND_SOC_MT6366 > > + tristate "MediaTek MT6366 Codec" > > + depends on MTK_PMIC_WRAP > > + help > > + Enable support for the platform which uses MT6366 as > > + external codec device. > > + > > config SND_SOC_MT6660 > > tristate "Mediatek MT6660 Speaker Amplifier" > > depends on I2C > > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile > > index 42d00aa4ee46..1279684feaf0 100644 > > --- a/sound/soc/codecs/Makefile > > +++ b/sound/soc/codecs/Makefile > > @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- > > mt6351.o > > obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o > > obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o > > +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o > > obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o > > obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E833C433EF for ; Sat, 5 Mar 2022 04:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HRETAX8zMncqjCgt8f1f7zAEFUyerE6Oe3pIkGSpRRM=; b=D+Sg9B3/eWGmsl YL/oUAQlvAqo5/WpTfQyli8/FbBndxzDZQv78ubOqd7t04phfN+5Ql/RGt+0cgetpiGeOl3aQeTwG q4DB6MfysRiAKQHath8UOqK8j67TwP4A1Lzghx77vsXpK6ZyqBAV0sv6qXOJqvskQXxU0rb+JkT6B LDlKyKoppQyFzNSObtJ0MSAojt+fBzFKjrj/EHLaC1KDeguBEpWCFPfnwuDtL6Qa7uA5sX+q/faU6 9WCV/FCD/gBdOdPVf0fQ5z1EbxF+3PDkm3p9AzkqsJb+RjQC7SAsWuMWWxvrLSCU4BbYG+FFPJUvi tk8wIc52Vl9DPNnWLAVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQLz7-00Ciqv-PE; Sat, 05 Mar 2022 04:25:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQLyu-00CiqC-VV; Sat, 05 Mar 2022 04:25:27 +0000 X-UUID: 8583f9f085db485088290c2563c6628c-20220304 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=4uH3o7mLmCQeRNiU//+zwKjq/fJbA1kQPGfCCkSbis0=; b=b1kWvrCVxqLQn1B9eDRKA7xTd/odukW4/WJocADxZRN6girImQzyiNwa1wPcJzxR+v/7iyCN2xxsZ4Pw58zqR6tBiPDlbo/+UjgEbFdeFP7YY+s7yExSLfSOq1o8tWCFxYBihhzlWFtiJ7YtPd5IlRN+CNTSRWznLvYbDLNkc9k=; X-UUID: 8583f9f085db485088290c2563c6628c-20220304 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1884387100; Fri, 04 Mar 2022 21:25:13 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 4 Mar 2022 20:25:12 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Mar 2022 12:24:58 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 5 Mar 2022 12:24:57 +0800 Message-ID: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver From: Jiaxin Yu To: AngeloGioacchino Del Regno , CC: , , , , , , , , , , , , , , , Date: Sat, 5 Mar 2022 12:24:57 +0800 In-Reply-To: References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_202525_069699_950E22CF X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: > Il 17/02/22 14:41, Jiaxin Yu ha scritto: > > Mt6366 is a new version of mt6358, and they are same about audio > > part. > > So we can reuse the driver of mt6358. > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > I'm sorry but this commit makes very little sense. > > If you want to advertise MT6366 support, please write a note and/or > a new compatible string inside of the mt6358 driver (and dt- > bindings), > then, please drop this commit. > Hello angelogioacchino, Thank you for your advice. If I add a new compatible string inside of the mt6358 driver and dt- bindings, then the machine driver which want to use mt6366 should select SND_SOC_MT6358. like below: config SND_SOC_MT8186_MT6366_DA7219_MAX98357 tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A codec" depends on I2C && GPIOLIB depends on SND_SOC_MT8186 && MTK_PMIC_WRAP select SND_SOC_MT6366 ==> SND_SOC_MT6358 ... I just doubt it's enough to make sense. I originally wanted to put this relationship in the sound/soc/codecs layer. So that this relationship is not perceived by users(machine driver). However, if the general practice is like this, I will adopt your suggestion. Thank you again. > > > --- > > sound/soc/codecs/Kconfig | 8 ++++++++ > > sound/soc/codecs/Makefile | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > > index 8fa24783ce01..6631094678f5 100644 > > --- a/sound/soc/codecs/Kconfig > > +++ b/sound/soc/codecs/Kconfig > > @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS > > imply SND_SOC_MT6351 > > imply SND_SOC_MT6358 > > imply SND_SOC_MT6359 > > + imply SND_SOC_MT6366 > > imply SND_SOC_MT6660 > > imply SND_SOC_NAU8315 > > imply SND_SOC_NAU8540 > > @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET > > for ASoC codec soc-jack detection mechanism. > > Select N if you don't have jack on board. > > > > +config SND_SOC_MT6366 > > + tristate "MediaTek MT6366 Codec" > > + depends on MTK_PMIC_WRAP > > + help > > + Enable support for the platform which uses MT6366 as > > + external codec device. > > + > > config SND_SOC_MT6660 > > tristate "Mediatek MT6660 Speaker Amplifier" > > depends on I2C > > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile > > index 42d00aa4ee46..1279684feaf0 100644 > > --- a/sound/soc/codecs/Makefile > > +++ b/sound/soc/codecs/Makefile > > @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- > > mt6351.o > > obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o > > obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o > > +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o > > obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o > > obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEADEC433EF for ; Sat, 5 Mar 2022 04:26:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 558E01AF5; Sat, 5 Mar 2022 05:25:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 558E01AF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646454370; bh=ZwbbXQUlOHQetbbfyLpgu4qGfFTC17m6goqwT7zI3lE=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NxrDgJAiU4ZYNPgStqUr+9NT0aeftOgRgHwBM9wxGvRLHbN+i81/uo1/lImFMTp9v N50bu1qZlE7Run7XFiuthJtB5gN/UpLF7KC2ctV7pkB8ZuwqFCtZCrqBamT6ePj/sd vYXC23Za7vJt9+z1OjROJmVPhrsJX8K5XErY4l88= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EB07AF800F0; Sat, 5 Mar 2022 05:25:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 39AD8F80237; Sat, 5 Mar 2022 05:25:17 +0100 (CET) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E8EF8F800D1 for ; Sat, 5 Mar 2022 05:25:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E8EF8F800D1 X-UUID: f91cd922797a4c02b60543ed4c65f1a6-20220305 X-UUID: f91cd922797a4c02b60543ed4c65f1a6-20220305 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1076188222; Sat, 05 Mar 2022 12:25:00 +0800 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Mar 2022 12:24:59 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Mar 2022 12:24:58 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 5 Mar 2022 12:24:57 +0800 Message-ID: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver From: Jiaxin Yu To: AngeloGioacchino Del Regno , Date: Sat, 5 Mar 2022 12:24:57 +0800 In-Reply-To: References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, geert+renesas@glider.be, linux-kernel@vger.kernel.org, zhangqilong3@huawei.com, tiwai@suse.com, lgirdwood@gmail.com, tzungbi@google.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, trevor.wu@mediatek.com, p.zabel@pengutronix.de, matthias.bgg@gmail.com, aaronyu@google.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: > Il 17/02/22 14:41, Jiaxin Yu ha scritto: > > Mt6366 is a new version of mt6358, and they are same about audio > > part. > > So we can reuse the driver of mt6358. > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > I'm sorry but this commit makes very little sense. > > If you want to advertise MT6366 support, please write a note and/or > a new compatible string inside of the mt6358 driver (and dt- > bindings), > then, please drop this commit. > Hello angelogioacchino, Thank you for your advice. If I add a new compatible string inside of the mt6358 driver and dt- bindings, then the machine driver which want to use mt6366 should select SND_SOC_MT6358. like below: config SND_SOC_MT8186_MT6366_DA7219_MAX98357 tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A codec" depends on I2C && GPIOLIB depends on SND_SOC_MT8186 && MTK_PMIC_WRAP select SND_SOC_MT6366 ==> SND_SOC_MT6358 ... I just doubt it's enough to make sense. I originally wanted to put this relationship in the sound/soc/codecs layer. So that this relationship is not perceived by users(machine driver). However, if the general practice is like this, I will adopt your suggestion. Thank you again. > > > --- > > sound/soc/codecs/Kconfig | 8 ++++++++ > > sound/soc/codecs/Makefile | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > > index 8fa24783ce01..6631094678f5 100644 > > --- a/sound/soc/codecs/Kconfig > > +++ b/sound/soc/codecs/Kconfig > > @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS > > imply SND_SOC_MT6351 > > imply SND_SOC_MT6358 > > imply SND_SOC_MT6359 > > + imply SND_SOC_MT6366 > > imply SND_SOC_MT6660 > > imply SND_SOC_NAU8315 > > imply SND_SOC_NAU8540 > > @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET > > for ASoC codec soc-jack detection mechanism. > > Select N if you don't have jack on board. > > > > +config SND_SOC_MT6366 > > + tristate "MediaTek MT6366 Codec" > > + depends on MTK_PMIC_WRAP > > + help > > + Enable support for the platform which uses MT6366 as > > + external codec device. > > + > > config SND_SOC_MT6660 > > tristate "Mediatek MT6660 Speaker Amplifier" > > depends on I2C > > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile > > index 42d00aa4ee46..1279684feaf0 100644 > > --- a/sound/soc/codecs/Makefile > > +++ b/sound/soc/codecs/Makefile > > @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- > > mt6351.o > > obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o > > obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o > > +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o > > obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o > > obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E7D2C433F5 for ; Sat, 5 Mar 2022 04:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=he7va2A7vUrlhH/QEk3PzuJ1UhsfCQ/5DiXY1uw8+Rg=; b=2SmuMDQtUsl7Tb /wxODAV8jTENruysT1/fWEjuodqhbNNPRwh/zpzhQBtGMEDOedpCvnJogBDw+R6cEw1OkP+IvAN/Y u1vN3EnjTxp886zi1rgR9GeRULMC/8Xbb7bxLLDzrUGjqvBvdFgIA0eSTgsPKyL37F/YKx8bHCBIC 6+xvrw7TRSgRXKswmKVs2/AnS8aITqMZ3elndB69OY1I1ABJAoodssyzNmWlNdibnKTN9fNvtWZpa qAogitNtguKKRJKvaqdZ6x0WwK3EUOdm7tZqiX2UgknutpTElf4TAoZ4gp6W3yWapAnFQf1z5HIQt 2s6wC4EkGy002GP3sYtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQLyz-00Ciqo-8G; Sat, 05 Mar 2022 04:25:29 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQLyu-00CiqC-VV; Sat, 05 Mar 2022 04:25:27 +0000 X-UUID: 8583f9f085db485088290c2563c6628c-20220304 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=4uH3o7mLmCQeRNiU//+zwKjq/fJbA1kQPGfCCkSbis0=; b=b1kWvrCVxqLQn1B9eDRKA7xTd/odukW4/WJocADxZRN6girImQzyiNwa1wPcJzxR+v/7iyCN2xxsZ4Pw58zqR6tBiPDlbo/+UjgEbFdeFP7YY+s7yExSLfSOq1o8tWCFxYBihhzlWFtiJ7YtPd5IlRN+CNTSRWznLvYbDLNkc9k=; X-UUID: 8583f9f085db485088290c2563c6628c-20220304 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1884387100; Fri, 04 Mar 2022 21:25:13 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 4 Mar 2022 20:25:12 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Mar 2022 12:24:58 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 5 Mar 2022 12:24:57 +0800 Message-ID: <6555d89deb9087825f865b9d4265f07465e7ae09.camel@mediatek.com> Subject: Re: [v2 01/17] ASoC: mediatek: mt6366: add codec driver From: Jiaxin Yu To: AngeloGioacchino Del Regno , CC: , , , , , , , , , , , , , , , Date: Sat, 5 Mar 2022 12:24:57 +0800 In-Reply-To: References: <20220217134205.15400-1-jiaxin.yu@mediatek.com> <20220217134205.15400-2-jiaxin.yu@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220304_202525_069699_950E22CF X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-02-18 at 15:54 +0100, AngeloGioacchino Del Regno wrote: > Il 17/02/22 14:41, Jiaxin Yu ha scritto: > > Mt6366 is a new version of mt6358, and they are same about audio > > part. > > So we can reuse the driver of mt6358. > > > > Signed-off-by: Jiaxin Yu > > Hello Jiaxin, > I'm sorry but this commit makes very little sense. > > If you want to advertise MT6366 support, please write a note and/or > a new compatible string inside of the mt6358 driver (and dt- > bindings), > then, please drop this commit. > Hello angelogioacchino, Thank you for your advice. If I add a new compatible string inside of the mt6358 driver and dt- bindings, then the machine driver which want to use mt6366 should select SND_SOC_MT6358. like below: config SND_SOC_MT8186_MT6366_DA7219_MAX98357 tristate "ASoC Audio driver for MT8186 with DA7219 MAX98357A codec" depends on I2C && GPIOLIB depends on SND_SOC_MT8186 && MTK_PMIC_WRAP select SND_SOC_MT6366 ==> SND_SOC_MT6358 ... I just doubt it's enough to make sense. I originally wanted to put this relationship in the sound/soc/codecs layer. So that this relationship is not perceived by users(machine driver). However, if the general practice is like this, I will adopt your suggestion. Thank you again. > > > --- > > sound/soc/codecs/Kconfig | 8 ++++++++ > > sound/soc/codecs/Makefile | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > > index 8fa24783ce01..6631094678f5 100644 > > --- a/sound/soc/codecs/Kconfig > > +++ b/sound/soc/codecs/Kconfig > > @@ -132,6 +132,7 @@ config SND_SOC_ALL_CODECS > > imply SND_SOC_MT6351 > > imply SND_SOC_MT6358 > > imply SND_SOC_MT6359 > > + imply SND_SOC_MT6366 > > imply SND_SOC_MT6660 > > imply SND_SOC_NAU8315 > > imply SND_SOC_NAU8540 > > @@ -1888,6 +1889,13 @@ config SND_SOC_MT6359_ACCDET > > for ASoC codec soc-jack detection mechanism. > > Select N if you don't have jack on board. > > > > +config SND_SOC_MT6366 > > + tristate "MediaTek MT6366 Codec" > > + depends on MTK_PMIC_WRAP > > + help > > + Enable support for the platform which uses MT6366 as > > + external codec device. > > + > > config SND_SOC_MT6660 > > tristate "Mediatek MT6660 Speaker Amplifier" > > depends on I2C > > diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile > > index 42d00aa4ee46..1279684feaf0 100644 > > --- a/sound/soc/codecs/Makefile > > +++ b/sound/soc/codecs/Makefile > > @@ -465,6 +465,7 @@ obj-$(CONFIG_SND_SOC_MT6351) += snd-soc- > > mt6351.o > > obj-$(CONFIG_SND_SOC_MT6358) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6359) += snd-soc-mt6359.o > > obj-$(CONFIG_SND_SOC_MT6359_ACCDET) += mt6359-accdet.o > > +obj-$(CONFIG_SND_SOC_MT6366) += snd-soc-mt6358.o > > obj-$(CONFIG_SND_SOC_MT6660) += snd-soc-mt6660.o > > obj-$(CONFIG_SND_SOC_NAU8315) += snd-soc-nau8315.o > > obj-$(CONFIG_SND_SOC_NAU8540) += snd-soc-nau8540.o > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel