All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
@ 2021-02-23 11:12 Philippe Mathieu-Daudé
  2021-02-23 18:47 ` Richard Henderson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-23 11:12 UTC (permalink / raw)
  To: qemu-devel; +Cc: Taylor Simpson, Richard Henderson, Philippe Mathieu-Daudé

Fix a trivial incorrect usage of variable argument macros detected
by Coverity (missing_va_end: va_end was not called for ap).

Fixes: Coverity CID 1446720 (VARARGS)
Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/hexagon/opcodes.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/hexagon/opcodes.c b/target/hexagon/opcodes.c
index 4eef5fc40f6..35d790cdd5b 100644
--- a/target/hexagon/opcodes.c
+++ b/target/hexagon/opcodes.c
@@ -82,6 +82,7 @@ static void init_attribs(int tag, ...)
     while ((attr = va_arg(ap, int)) != 0) {
         set_bit(attr, opcode_attribs[tag]);
     }
+    va_end(ap);
 }
 
 const OpcodeEncoding opcode_encodings[] = {
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
  2021-02-23 11:12 [PATCH] target/hexagon/opcodes: Add missing varargs cleanup Philippe Mathieu-Daudé
@ 2021-02-23 18:47 ` Richard Henderson
  2021-02-23 20:40 ` Taylor Simpson
  2021-03-05 19:04 ` Richard Henderson
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2021-02-23 18:47 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Taylor Simpson

On 2/23/21 3:12 AM, Philippe Mathieu-Daudé wrote:
> Fix a trivial incorrect usage of variable argument macros detected
> by Coverity (missing_va_end: va_end was not called for ap).
> 
> Fixes: Coverity CID 1446720 (VARARGS)
> Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/hexagon/opcodes.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
  2021-02-23 11:12 [PATCH] target/hexagon/opcodes: Add missing varargs cleanup Philippe Mathieu-Daudé
  2021-02-23 18:47 ` Richard Henderson
@ 2021-02-23 20:40 ` Taylor Simpson
  2021-03-05 19:04 ` Richard Henderson
  2 siblings, 0 replies; 4+ messages in thread
From: Taylor Simpson @ 2021-02-23 20:40 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Richard Henderson



> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> Behalf Of Philippe Mathieu-Daudé
> Sent: Tuesday, February 23, 2021 5:13 AM
> To: qemu-devel@nongnu.org
> Cc: Richard Henderson <richard.henderson@linaro.org>; Taylor Simpson
> <tsimpson@quicinc.com>; Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
>
> Fix a trivial incorrect usage of variable argument macros detected
> by Coverity (missing_va_end: va_end was not called for ap).
>
> Fixes: Coverity CID 1446720 (VARARGS)
> Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/hexagon/opcodes.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target/hexagon/opcodes.c b/target/hexagon/opcodes.c
> index 4eef5fc40f6..35d790cdd5b 100644
> --- a/target/hexagon/opcodes.c
> +++ b/target/hexagon/opcodes.c
> @@ -82,6 +82,7 @@ static void init_attribs(int tag, ...)
>      while ((attr = va_arg(ap, int)) != 0) {
>          set_bit(attr, opcode_attribs[tag]);
>      }
> +    va_end(ap);
>  }
>

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Tested-by: Taylor Simpson <tsimpson@quicinc.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] target/hexagon/opcodes: Add missing varargs cleanup
  2021-02-23 11:12 [PATCH] target/hexagon/opcodes: Add missing varargs cleanup Philippe Mathieu-Daudé
  2021-02-23 18:47 ` Richard Henderson
  2021-02-23 20:40 ` Taylor Simpson
@ 2021-03-05 19:04 ` Richard Henderson
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2021-03-05 19:04 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Taylor Simpson

On 2/23/21 3:12 AM, Philippe Mathieu-Daudé wrote:
> Fix a trivial incorrect usage of variable argument macros detected
> by Coverity (missing_va_end: va_end was not called for ap).
> 
> Fixes: Coverity CID 1446720 (VARARGS)
> Fixes: e3c00c2ed75 ("Hexagon (target/hexagon) opcode data structures")
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/hexagon/opcodes.c | 1 +
>   1 file changed, 1 insertion(+)

Queued to hexagon-next.

r~


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-05 19:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-23 11:12 [PATCH] target/hexagon/opcodes: Add missing varargs cleanup Philippe Mathieu-Daudé
2021-02-23 18:47 ` Richard Henderson
2021-02-23 20:40 ` Taylor Simpson
2021-03-05 19:04 ` Richard Henderson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.