From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dctJV-0003hu-DG for qemu-devel@nongnu.org; Wed, 02 Aug 2017 09:03:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dctJS-0002Pe-Ae for qemu-devel@nongnu.org; Wed, 02 Aug 2017 09:03:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58660) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dctJS-0002PK-29 for qemu-devel@nongnu.org; Wed, 02 Aug 2017 09:03:46 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09CB1C047B66 for ; Wed, 2 Aug 2017 13:03:45 +0000 (UTC) References: <1501515652-33372-1-git-send-email-imammedo@redhat.com> <1501515652-33372-4-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <6561933e-ae98-5eb0-b58c-f90ee8d471cd@redhat.com> Date: Wed, 2 Aug 2017 16:03:38 +0300 MIME-Version: 1.0 In-Reply-To: <1501515652-33372-4-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.10 3/5] tests: acpi: rename test_acpi_tables()/test_dst_table() to reflect its usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" On 31/07/2017 18:40, Igor Mammedov wrote: > Main purpose of test_dst_table() is loading a table from QEMU > with checking that checksum in header matches actual one, > rename it reflect main action it performs. > > Likewise test_acpi_tables() name is to broad, while the function > only loads tables referenced by RSDT, rename it to reflect it. > > Signed-off-by: Igor Mammedov > --- > tests/bios-tables-test.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index adbcc55..ed32e9a 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -206,7 +206,11 @@ static void test_acpi_facs_table(test_data *data) > ACPI_ASSERT_CMP(facs_table->signature, "FACS"); > } > > -static void test_dst_table(AcpiSdtTable *sdt_table, uint32_t addr) > +/** fetch_table > + * load ACPI table at @addr into table descriptor @sdt_table > + * and check that header checksum matches actual one. > + */ > +static void fetch_table(AcpiSdtTable *sdt_table, uint32_t addr) > { > uint8_t checksum; > > @@ -229,14 +233,15 @@ static void test_acpi_dsdt_table(test_data *data) > AcpiSdtTable dsdt_table; > uint32_t addr = data->fadt_table.dsdt; > > - test_dst_table(&dsdt_table, addr); > + fetch_table(&dsdt_table, addr); > ACPI_ASSERT_CMP(dsdt_table.header.signature, "DSDT"); > > /* Since DSDT isn't in RSDT, add DSDT to ASL test tables list manually */ > g_array_append_val(data->tables, dsdt_table); > } > > -static void test_acpi_tables(test_data *data) > +/* Load all tables and add to test list directly RSDT referenced tables */ > +static void fetch_rsdt_referenced_tables(test_data *data) > { > int tables_nr = data->rsdt_tables_nr - 1; /* fadt is first */ > int i; > @@ -245,7 +250,7 @@ static void test_acpi_tables(test_data *data) > AcpiSdtTable ssdt_table; > > uint32_t addr = data->rsdt_tables_addr[i + 1]; /* fadt is first */ > - test_dst_table(&ssdt_table, addr); > + fetch_table(&ssdt_table, addr); > g_array_append_val(data->tables, ssdt_table); > } > } > @@ -638,7 +643,7 @@ static void test_acpi_one(const char *params, test_data *data) > test_acpi_fadt_table(data); > test_acpi_facs_table(data); > test_acpi_dsdt_table(data); > - test_acpi_tables(data); > + fetch_rsdt_referenced_tables(data); > > if (iasl) { > if (getenv(ACPI_REBUILD_EXPECTED_AML)) { > Reviewed-by: Marcel Apfelbaum Thanks, Marcel