From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755609AbaIKOaU (ORCPT ); Thu, 11 Sep 2014 10:30:20 -0400 Received: from gloria.sntech.de ([95.129.55.99]:41445 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755430AbaIKOaQ convert rfc822-to-8bit (ORCPT ); Thu, 11 Sep 2014 10:30:16 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Caesar Wang Cc: rui.zhang@intel.com, edubezval@gmail.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, huangtao@rock-chips.com, cf@rock-chips.com, dianders@chromium.org, dtor@chromium.org, zyw@rock-chips.com, addy.ke@rock-chips.com, dmitry.torokhov@gmail.com Subject: Re: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 Date: Thu, 11 Sep 2014 15:58:04 +0200 Message-ID: <6563337.jht9ZmlHCg@diego> User-Agent: KMail/4.12.4 (Linux/3.13-1-amd64; KDE/4.13.3; x86_64; ; ) In-Reply-To: <540FBC21.2090504@rock-chips.com> References: <1409710239-19941-1-git-send-email-caesar.wang@rock-chips.com> <3426113.Zcq8V2S7cg@diego> <540FBC21.2090504@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Caesar, Am Mittwoch, 10. September 2014, 10:49:05 schrieb Caesar Wang: > Hi Heiko, > > 在 2014年09月09日 19:37, Heiko Stübner 写道: > > Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang: > >> Signed-off-by: Caesar Wang > >> --- > >> > >> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/rk3288.dtsi > >> b/arch/arm/boot/dts/rk3288.dtsi > >> index 36be7bb..3d672e3 100644 > >> --- a/arch/arm/boot/dts/rk3288.dtsi > >> +++ b/arch/arm/boot/dts/rk3288.dtsi [...] > >> @@ -611,5 +622,12 @@ > >> > >> rockchip,pins = <5 15 3 &pcfg_pull_none>; > >> > >> }; > >> > >> }; > >> > >> + > >> + tsadc { > >> + tsadc_int: tsadc-int { > >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>; > >> + }; > >> + }; > > > > After looking this up in the schematics I see that this is the > > overtemperature-protection output pin ... labeled OTP_OUT. > > So I'd think the pinconfig should reflect this pin-name, especially as > > tsadc-int suggests, that this would be an interrupt leading into the > > tsadc, while in fact it is an output to a separate circuit. > > Maybe,I guess your mean as the follows . > Please correct it and Laugh out if I got it wrong. I'll never laugh ... just try get the best solution / trying to understand backgrounds. > > tsadc { > otp_out: otp-out { > rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>; > }; > > tsadc_int: tsadc-int { > rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>; > }; > }; > Then,I deal with the otp_out in thermal driver. > I believe The "otp_out" will restart board if it's a high active. > > tsadc_int: tsadc-int { > + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>; > + }; > > But,I think the about will be implemented in thermal driver. I only meant the pin name (tsadc-int -> otp-out). In the schmatics the pin (controlled by the tsadc) is labeled otp_out and leads to the overtemperature protection circuit as expected. And as it's controlled by the tsadc, it should of course stay as the desired func_1. Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 Date: Thu, 11 Sep 2014 15:58:04 +0200 Message-ID: <6563337.jht9ZmlHCg@diego> References: <1409710239-19941-1-git-send-email-caesar.wang@rock-chips.com> <3426113.Zcq8V2S7cg@diego> <540FBC21.2090504@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <540FBC21.2090504@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Caesar Wang Cc: huangtao@rock-chips.com, devicetree@vger.kernel.org, addy.ke@rock-chips.com, dmitry.torokhov@gmail.com, linux-pm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, edubezval@gmail.com, zyw@rock-chips.com, cf@rock-chips.com, rui.zhang@intel.com, dtor@chromium.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgQ2Flc2FyLAoKQW0gTWl0dHdvY2gsIDEwLiBTZXB0ZW1iZXIgMjAxNCwgMTA6NDk6MDUgc2No cmllYiBDYWVzYXIgV2FuZzoKPiBIaSBIZWlrbywKPiAKPiDlnKggMjAxNOW5tDA55pyIMDnml6Ug MTk6MzcsIEhlaWtvIFN0w7xibmVyIOWGmemBkzoKPiA+IEFtIE1pdHR3b2NoLCAzLiBTZXB0ZW1i ZXIgMjAxNCwgMTA6MTA6Mzggc2NocmllYiBDYWVzYXIgV2FuZzoKPiA+PiBTaWduZWQtb2ZmLWJ5 OiBDYWVzYXIgV2FuZyA8Y2Flc2FyLndhbmdAcm9jay1jaGlwcy5jb20+Cj4gPj4gLS0tCj4gPj4g Cj4gPj4gICBhcmNoL2FybS9ib290L2R0cy9yazMyODguZHRzaSB8IDE4ICsrKysrKysrKysrKysr KysrKwo+ID4+ICAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKykKPiA+PiAKPiA+PiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvcmszMjg4LmR0c2kKPiA+PiBiL2FyY2gvYXJt L2Jvb3QvZHRzL3JrMzI4OC5kdHNpCj4gPj4gaW5kZXggMzZiZTdiYi4uM2Q2NzJlMyAxMDA2NDQK PiA+PiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9yazMyODguZHRzaQo+ID4+ICsrKyBiL2FyY2gv YXJtL2Jvb3QvZHRzL3JrMzI4OC5kdHNpCgpbLi4uXQoKPiA+PiBAQCAtNjExLDUgKzYyMiwxMiBA QAo+ID4+IAo+ID4+ICAgCQkJCXJvY2tjaGlwLHBpbnMgPSA8NSAxNSAzICZwY2ZnX3B1bGxfbm9u ZT47Cj4gPj4gICAJCQkKPiA+PiAgIAkJCX07Cj4gPj4gICAJCQo+ID4+ICAgCQl9Owo+ID4+IAo+ ID4+ICsKPiA+PiArCQl0c2FkYyB7Cj4gPj4gKwkJCXRzYWRjX2ludDogdHNhZGMtaW50IHsKPiA+ PiArCQkJCXJvY2tjaGlwLHBpbnMgPSA8MCAxMCBSS19GVU5DXzEgJnBjZmdfcHVsbF91cD47Cj4g Pj4gKwkJCX07Cj4gPj4gKwkJfTsKPiA+IAo+ID4gQWZ0ZXIgbG9va2luZyB0aGlzIHVwIGluIHRo ZSBzY2hlbWF0aWNzIEkgc2VlIHRoYXQgdGhpcyBpcyB0aGUKPiA+IG92ZXJ0ZW1wZXJhdHVyZS1w cm90ZWN0aW9uIG91dHB1dCBwaW4gLi4uIGxhYmVsZWQgT1RQX09VVC4KPiA+IFNvIEknZCB0aGlu ayB0aGUgcGluY29uZmlnIHNob3VsZCByZWZsZWN0IHRoaXMgcGluLW5hbWUsIGVzcGVjaWFsbHkg YXMKPiA+IHRzYWRjLWludCBzdWdnZXN0cywgdGhhdCB0aGlzIHdvdWxkIGJlIGFuIGludGVycnVw dCBsZWFkaW5nIGludG8gdGhlCj4gPiB0c2FkYywgd2hpbGUgaW4gZmFjdCBpdCBpcyBhbiBvdXRw dXQgdG8gYSBzZXBhcmF0ZSBjaXJjdWl0Lgo+IAo+IE1heWJlLEkgZ3Vlc3MgIHlvdXIgbWVhbiBh cyB0aGUgZm9sbG93cyAuCj4gUGxlYXNlIGNvcnJlY3QgaXQgYW5kICBMYXVnaCBvdXQgaWYgSSBn b3QgaXQgd3JvbmcuCgpJJ2xsIG5ldmVyIGxhdWdoIC4uLiBqdXN0IHRyeSBnZXQgdGhlIGJlc3Qg c29sdXRpb24gLyB0cnlpbmcgdG8gdW5kZXJzdGFuZCAKYmFja2dyb3VuZHMuCgo+IAo+IHRzYWRj IHsKPiAgICAgICAgICAgICAgb3RwX291dDogb3RwLW91dCB7Cj4gICAgICAgICAgICAgICAgICBy b2NrY2hpcCxwaW5zID0gPDAgMTAgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47Cj4gICAg ICAgICAgICAgIH07Cj4gCj4gICAgICAgICAgICAgIHRzYWRjX2ludDogdHNhZGMtaW50IHsKPiAg ICAgICAgICAgICAgICAgIHJvY2tjaGlwLHBpbnMgPSA8MCAxMCBSS19GVU5DXzEgJnBjZmdfcHVs bF9ub25lPjsKPiAgICAgICAgICAgICAgfTsKPiAgICAgICAgICB9Owo+IFRoZW4sSSBkZWFsIHdp dGggdGhlIG90cF9vdXQgaW4gdGhlcm1hbCBkcml2ZXIuCj4gSSBiZWxpZXZlIFRoZSAib3RwX291 dCIgd2lsbCByZXN0YXJ0IGJvYXJkIGlmIGl0J3MgYSBoaWdoIGFjdGl2ZS4KPiAKPiB0c2FkY19p bnQ6IHRzYWRjLWludCB7Cj4gKwkJCQlyb2NrY2hpcCxwaW5zID0gPDAgMTAgUktfRlVOQ18xICZw Y2ZnX3B1bGxfdXA+Owo+ICsJCQl9Owo+IAo+IEJ1dCxJIHRoaW5rIHRoZSBhYm91dCB3aWxsIGJl IGltcGxlbWVudGVkIGluIHRoZXJtYWwgZHJpdmVyLgoKSSBvbmx5IG1lYW50IHRoZSBwaW4gbmFt ZSAodHNhZGMtaW50IC0+IG90cC1vdXQpLiBJbiB0aGUgc2NobWF0aWNzIHRoZSBwaW4gCihjb250 cm9sbGVkIGJ5IHRoZSB0c2FkYykgaXMgbGFiZWxlZCBvdHBfb3V0IGFuZCBsZWFkcyB0byB0aGUg b3ZlcnRlbXBlcmF0dXJlIApwcm90ZWN0aW9uIGNpcmN1aXQgYXMgZXhwZWN0ZWQuIEFuZCBhcyBp dCdzIGNvbnRyb2xsZWQgYnkgdGhlIHRzYWRjLCBpdCBzaG91bGQgCm9mIGNvdXJzZSBzdGF5IGFz IHRoZSBkZXNpcmVkIGZ1bmNfMS4KCgpIZWlrbwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Thu, 11 Sep 2014 15:58:04 +0200 Subject: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 In-Reply-To: <540FBC21.2090504@rock-chips.com> References: <1409710239-19941-1-git-send-email-caesar.wang@rock-chips.com> <3426113.Zcq8V2S7cg@diego> <540FBC21.2090504@rock-chips.com> Message-ID: <6563337.jht9ZmlHCg@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Caesar, Am Mittwoch, 10. September 2014, 10:49:05 schrieb Caesar Wang: > Hi Heiko, > > ? 2014?09?09? 19:37, Heiko St?bner ??: > > Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang: > >> Signed-off-by: Caesar Wang > >> --- > >> > >> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++ > >> 1 file changed, 18 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/rk3288.dtsi > >> b/arch/arm/boot/dts/rk3288.dtsi > >> index 36be7bb..3d672e3 100644 > >> --- a/arch/arm/boot/dts/rk3288.dtsi > >> +++ b/arch/arm/boot/dts/rk3288.dtsi [...] > >> @@ -611,5 +622,12 @@ > >> > >> rockchip,pins = <5 15 3 &pcfg_pull_none>; > >> > >> }; > >> > >> }; > >> > >> + > >> + tsadc { > >> + tsadc_int: tsadc-int { > >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>; > >> + }; > >> + }; > > > > After looking this up in the schematics I see that this is the > > overtemperature-protection output pin ... labeled OTP_OUT. > > So I'd think the pinconfig should reflect this pin-name, especially as > > tsadc-int suggests, that this would be an interrupt leading into the > > tsadc, while in fact it is an output to a separate circuit. > > Maybe,I guess your mean as the follows . > Please correct it and Laugh out if I got it wrong. I'll never laugh ... just try get the best solution / trying to understand backgrounds. > > tsadc { > otp_out: otp-out { > rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>; > }; > > tsadc_int: tsadc-int { > rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>; > }; > }; > Then,I deal with the otp_out in thermal driver. > I believe The "otp_out" will restart board if it's a high active. > > tsadc_int: tsadc-int { > + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>; > + }; > > But,I think the about will be implemented in thermal driver. I only meant the pin name (tsadc-int -> otp-out). In the schmatics the pin (controlled by the tsadc) is labeled otp_out and leads to the overtemperature protection circuit as expected. And as it's controlled by the tsadc, it should of course stay as the desired func_1. Heiko