All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fernando Fernandez Mancera <ffmancera@riseup.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v3 1/2] jump: Introduce chain_expr in jump and goto statements
Date: Fri, 24 May 2019 09:17:37 +0200	[thread overview]
Message-ID: <6570754e-30ab-b24b-4f4d-507a6ac74edf@riseup.net> (raw)
In-Reply-To: <1ff8b9ea-ce19-301f-e683-790417a179a7@riseup.net>

Hi Pablo,

On 5/21/19 9:38 PM, Fernando Fernandez Mancera wrote:
> Hi Pablo,
> 
> On 5/21/19 11:28 AM, Pablo Neira Ayuso wrote:
>> On Thu, May 16, 2019 at 10:45:58PM +0200, Fernando Fernandez Mancera wrote:
>>> Now we can introduce expressions as a chain in jump and goto statements. This
>>> is going to be used to support variables as a chain in the following patches.
>>
>> Something is wrong with json:
>>
>> json.c: In function ‘verdict_expr_json’:
>> json.c:683:11: warning: assignment from incompatible pointer type
>> [-Wincompatible-pointer-types]
>>      chain = expr->chain;
>>            ^
>> parser_json.c: In function ‘json_parse_verdict_expr’:
>> parser_json.c:1086:8: warning: passing argument 3 of
>> ‘verdict_expr_alloc’ from incompatible pointer type
>> [-Wincompatible-pointer-types]
>>         chain ? xstrdup(chain) : NULL);
>>         ^~~~~
>>
>> Most likely --enable-json missing there.
>>
> 
> Sorry, I am going to fix that.
> [...]

I am compiling nftables with:

$ ./configure --enable-json
$ make

And I am not getting any error, am I missing something? Thanks! :-)

  parent reply	other threads:[~2019-05-24  7:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 20:45 [PATCH nft v3 1/2] jump: Introduce chain_expr in jump and goto statements Fernando Fernandez Mancera
2019-05-16 20:45 ` [PATCH nft v3 2/2] jump: Allow goto and jump to a variable using nft input files Fernando Fernandez Mancera
2019-05-21  9:28 ` [PATCH nft v3 1/2] jump: Introduce chain_expr in jump and goto statements Pablo Neira Ayuso
2019-05-21 19:38   ` Fernando Fernandez Mancera
2019-05-21 19:42     ` Pablo Neira Ayuso
2019-05-24  7:17     ` Fernando Fernandez Mancera [this message]
2019-05-24  7:29       ` Fernando Fernandez Mancera
2019-05-24  9:21         ` Pablo Neira Ayuso
2019-05-24 10:29           ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6570754e-30ab-b24b-4f4d-507a6ac74edf@riseup.net \
    --to=ffmancera@riseup.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.