From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C7A9C433DF for ; Wed, 5 Aug 2020 16:02:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F31123432 for ; Wed, 5 Aug 2020 16:02:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y/eN+N/b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F31123432 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cl1biKV5UyiEhmbkV43OtWsgsaOZiJ0IDTJV36cbBZs=; b=Y/eN+N/bIs1fj26OgQq3D1QZ8 Y1Xp4GLWPMJYhNi3g/+GpgNka9+lUnEmV92q8TI7vLi1GF4BF0h1l+YzEPRE/7/8Hijx498Mh2uDr AECDJWSHalx1BfibFsLfqtUZWLFLbRMGagayaGO8XxPiPY0CqIvAS8RZUmCWEXz2eCnd/obG3SUHZ FhtesPBbID0v2lBJKOW1MeUfrEhet2NUS40BZ+48TzFpQnzzyU2/y1/FI+1vaxN2AOXqU4KMs37IC eymhY4tAczgsf1CTqdpyFzdhRe6kAyRgwMWDsXcyNqCXho8ZOOUpMnj9S/jTsfX+MStXb84cdPoCM KSz/lISoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3LpP-0008Vx-Sy; Wed, 05 Aug 2020 15:59:43 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k3LpN-0008VE-RI for linux-arm-kernel@lists.infradead.org; Wed, 05 Aug 2020 15:59:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8D7101424; Wed, 5 Aug 2020 08:59:37 -0700 (PDT) Received: from [10.37.12.82] (unknown [10.37.12.82]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F9CC3F7D7; Wed, 5 Aug 2020 08:59:32 -0700 (PDT) Subject: Re: [PATCH v7 16/25] coresight: allow funnel and replicator drivers to be built as modules To: tingwei@codeaurora.org, mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org References: <20200805025458.2978-1-tingwei@codeaurora.org> <20200805025458.2978-17-tingwei@codeaurora.org> From: Suzuki K Poulose Message-ID: <6572f524-804b-cd51-8d8c-e1e522bcbef0@arm.com> Date: Wed, 5 Aug 2020 17:04:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200805025458.2978-17-tingwei@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200805_115941_976523_426B648D X-CRM114-Status: GOOD ( 17.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, saiprakash.ranjan@codeaurora.org, kim.phillips@arm.com, jinlmao@codeaurora.org, gregkh@linuxfoundation.org, coresight@lists.linaro.org, rdunlap@infradead.org, ykaukab@suse.de, linux@armlinux.org.uk, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/05/2020 03:54 AM, Tingwei Zhang wrote: > From: Kim Phillips > > Allow to build coresight-funnel and coresight-replicator as modules, > for ease of development. > > - Kconfig becomes a tristate, to allow =m > - add funnel_remove and replicator_remove functions, > for module unload > - add a MODULE_DEVICE_TABLE for autoloading on boot > > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: Alexander Shishkin > Cc: Randy Dunlap > Cc: Suzuki K Poulose > Cc: Greg Kroah-Hartman > Cc: Russell King > Signed-off-by: Kim Phillips > Signed-off-by: Tingwei Zhang > Tested-by: Mike Leach nit: Please split the changes to multiple drivers into their respective patches. Also, I don't see any harm in merging the "remove multiple init calls" patches with the respective "allow module" for the respective drivers. Otherwise looks good to me. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel