From: Milan Broz <gmazyland@gmail.com>
To: "Jérôme Carretero" <cJ-ko@zougloub.eu>
Cc: dm-devel@redhat.com, mpatocka@redhat.com, samitolvanen@google.com
Subject: Re: [dm-devel] [PATCH] dm-verity: Fix FEC for RS roots non-aligned to block size
Date: Tue, 23 Feb 2021 11:57:07 +0100 [thread overview]
Message-ID: <6576ebcf-f250-fbf5-063c-91bd7cb1e5e6@gmail.com> (raw)
In-Reply-To: <20210222220110.22ee6d0e@pouet.cJ>
On 23/02/2021 04:00, Jérôme Carretero wrote:
> Tested-by: Jérôme Carretero <cJ-ko@zougloub.eu>
>
>
> I smoke-tested by fuzzing contiguous ranges of user data (not hash
> tree) and correction works up to the amount of added correction (since
> erasures are identified by hashes).
Thanks for testing!
> Since the fix looks obvious, this should probably CC to stable?
Yes, I forgot to add the tag, I think this should go to all stable kernels.
(It only needs dm_bufio_set_sector_offset() that was added later than FEC, IIRC.)
Milan
p.s.
There are also bugs in userspace veritysetup if FEC has hash area is stored
on the same device, then code miscalculates parity bytes then.
This will be fixed soon in next stable cryptsetup release.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-02-23 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 21:15 [dm-devel] [PATCH] dm-verity: Fix FEC for RS roots non-aligned to block size Milan Broz
2021-02-23 3:00 ` Jérôme Carretero
2021-02-23 10:57 ` Milan Broz [this message]
2021-02-23 16:51 ` Sami Tolvanen
2021-02-23 20:21 ` [PATCH 1/2] dm-bufio: subtract the number of initial sectors in dm_bufio_get_device_size Milan Broz
2021-02-23 20:21 ` [dm-devel] " Milan Broz
2021-02-23 20:21 ` [PATCH 2/2] dm-verity: Fix FEC for RS roots non-aligned to block size Milan Broz
2021-02-23 20:21 ` [dm-devel] " Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6576ebcf-f250-fbf5-063c-91bd7cb1e5e6@gmail.com \
--to=gmazyland@gmail.com \
--cc=cJ-ko@zougloub.eu \
--cc=dm-devel@redhat.com \
--cc=mpatocka@redhat.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.