From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965609Ab2CBXn0 (ORCPT ); Fri, 2 Mar 2012 18:43:26 -0500 Received: from usindpps06.hds.com ([207.126.252.19]:52717 "EHLO usindpps06.hds.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755873Ab2CBXnZ (ORCPT ); Fri, 2 Mar 2012 18:43:25 -0500 From: Satoru Moriya To: Rik van Riel CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "lwoodman@redhat.com" , "jweiner@redhat.com" , "shaohua.li@intel.com" , KOSAKI Motohiro , "dle-develop@lists.sourceforge.net" , Seiji Aguchi Date: Fri, 2 Mar 2012 18:43:01 -0500 Subject: RE: [RFC][PATCH] avoid swapping out with swappiness==0 Thread-Topic: [RFC][PATCH] avoid swapping out with swappiness==0 Thread-Index: Acz4xn5SAjgXOus7RFGcNtjskfzr0wAB1qTA Message-ID: <65795E11DBF1E645A09CEC7EAEE94B9CB945618C@USINDEVS02.corp.hds.com> References: <65795E11DBF1E645A09CEC7EAEE94B9CB9455FE2@USINDEVS02.corp.hds.com> <4F514E09.5060801@redhat.com> In-Reply-To: <4F514E09.5060801@redhat.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: ja-JP, en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 spamscore=0 ipscore=0 suspectscore=1 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1012030000 definitions=main-1203020230 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q22NhZeK021210 Hi Rik, Thank you for reviewing. On 03/02/2012 05:47 PM, Rik van Riel wrote: > On 03/02/2012 12:36 PM, Satoru Moriya wrote: >> @@ -1999,7 +1999,7 @@ out: >> unsigned long scan; >> >> scan = zone_nr_lru_pages(mz, lru); >> - if (priority || noswap) { >> + if (priority || noswap || !vmscan_swappiness(mz, sc)) { >> scan>>= priority; >> if (!scan&& force_scan) >> scan = SWAP_CLUSTER_MAX; > > However, I do not understand why we fail to scale the number of pages > we want to scan with priority if "noswap". > > For that matter, surely if we do not want to swap out anonymous pages, > we WANT to go into this if branch, in order to make sure we set "scan" > to 0? > > scan = div64_u64(scan * fraction[file], denominator); > > With your patch and swappiness=0, or no swap space, it looks like we > do not zero out "scan" and may end up scanning anonymous pages. With my patch, if swappiness==0 or noswap==1, fraction[file] is set to 0. As a result, scan will be set to 0, too. > Am I overlooking something? Is this correct? > > I mean, it is Friday and my brain is very full... Have a nice weekend ;) Regards, Satoru {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx169.postini.com [74.125.245.169]) by kanga.kvack.org (Postfix) with SMTP id AE0616B004A for ; Fri, 2 Mar 2012 18:43:10 -0500 (EST) From: Satoru Moriya Date: Fri, 2 Mar 2012 18:43:01 -0500 Subject: RE: [RFC][PATCH] avoid swapping out with swappiness==0 Message-ID: <65795E11DBF1E645A09CEC7EAEE94B9CB945618C@USINDEVS02.corp.hds.com> References: <65795E11DBF1E645A09CEC7EAEE94B9CB9455FE2@USINDEVS02.corp.hds.com> <4F514E09.5060801@redhat.com> In-Reply-To: <4F514E09.5060801@redhat.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "lwoodman@redhat.com" , "jweiner@redhat.com" , "shaohua.li@intel.com" , KOSAKI Motohiro , "dle-develop@lists.sourceforge.net" , Seiji Aguchi SGkgUmlrLA0KDQpUaGFuayB5b3UgZm9yIHJldmlld2luZy4NCg0KT24gMDMvMDIvMjAxMiAwNTo0 NyBQTSwgUmlrIHZhbiBSaWVsIHdyb3RlOg0KPiBPbiAwMy8wMi8yMDEyIDEyOjM2IFBNLCBTYXRv cnUgTW9yaXlhIHdyb3RlOg0KPj4gQEAgLTE5OTksNyArMTk5OSw3IEBAIG91dDoNCj4+ICAgICAg ICAgICB1bnNpZ25lZCBsb25nIHNjYW47DQo+Pg0KPj4gICAgICAgICAgIHNjYW4gPSB6b25lX25y X2xydV9wYWdlcyhteiwgbHJ1KTsNCj4+IC0gICAgICAgIGlmIChwcmlvcml0eSB8fCBub3N3YXAp IHsNCj4+ICsgICAgICAgIGlmIChwcmlvcml0eSB8fCBub3N3YXAgfHwgIXZtc2Nhbl9zd2FwcGlu ZXNzKG16LCBzYykpIHsNCj4+ICAgICAgICAgICAgICAgc2Nhbj4+PSBwcmlvcml0eTsNCj4+ICAg ICAgICAgICAgICAgaWYgKCFzY2FuJiYgIGZvcmNlX3NjYW4pDQo+PiAgICAgICAgICAgICAgICAg ICBzY2FuID0gU1dBUF9DTFVTVEVSX01BWDsNCj4gDQo+IEhvd2V2ZXIsIEkgZG8gbm90IHVuZGVy c3RhbmQgd2h5IHdlIGZhaWwgdG8gc2NhbGUgdGhlIG51bWJlciBvZiBwYWdlcyANCj4gd2Ugd2Fu dCB0byBzY2FuIHdpdGggcHJpb3JpdHkgaWYgIm5vc3dhcCIuDQo+IA0KPiBGb3IgdGhhdCBtYXR0 ZXIsIHN1cmVseSBpZiB3ZSBkbyBub3Qgd2FudCB0byBzd2FwIG91dCBhbm9ueW1vdXMgcGFnZXMs IA0KPiB3ZSBXQU5UIHRvIGdvIGludG8gdGhpcyBpZiBicmFuY2gsIGluIG9yZGVyIHRvIG1ha2Ug c3VyZSB3ZSBzZXQgInNjYW4iIA0KPiB0byAwPw0KPiANCj4gc2NhbiA9IGRpdjY0X3U2NChzY2Fu ICogZnJhY3Rpb25bZmlsZV0sIGRlbm9taW5hdG9yKTsNCj4gDQo+IFdpdGggeW91ciBwYXRjaCBh bmQgc3dhcHBpbmVzcz0wLCBvciBubyBzd2FwIHNwYWNlLCBpdCBsb29rcyBsaWtlIHdlIA0KPiBk byBub3QgemVybyBvdXQgInNjYW4iIGFuZCBtYXkgZW5kIHVwIHNjYW5uaW5nIGFub255bW91cyBw YWdlcy4NCg0KV2l0aCBteSBwYXRjaCwgaWYgc3dhcHBpbmVzcz09MCBvciBub3N3YXA9PTEsIGZy YWN0aW9uW2ZpbGVdIGlzDQpzZXQgdG8gMC4gQXMgYSByZXN1bHQsIHNjYW4gd2lsbCBiZSBzZXQg dG8gMCwgdG9vLg0KDQo+IEFtIEkgb3Zlcmxvb2tpbmcgc29tZXRoaW5nPyAgSXMgdGhpcyBjb3Jy ZWN0Pw0KPiANCj4gSSBtZWFuLCBpdCBpcyBGcmlkYXkgYW5kIG15IGJyYWluIGlzIHZlcnkgZnVs bC4uLg0KDQpIYXZlIGEgbmljZSB3ZWVrZW5kIDspDQoNClJlZ2FyZHMsDQpTYXRvcnUNCg== -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org