All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ulf Samuelsson <yocto@emagii.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: Yocto-mailing-list <yocto@yoctoproject.org>
Subject: Re: [PATCH] bb.build.addtask: add simple check for circular dependency
Date: Fri, 18 Jan 2019 17:07:06 +0100	[thread overview]
Message-ID: <657D18B2-09CD-4447-AEE5-D634323EE3DF@emagii.com> (raw)
In-Reply-To: <0295F92F-54D9-411E-A0C6-3DD0176C6041@gmail.com>




> 18 jan. 2019 kl. 16:56 skrev Alexander Kanavin <alex.kanavin@gmail.com>:
> 
> 
> 
>>> On 18 Jan 2019, at 16.34, Burton, Ross <ross.burton@intel.com> wrote:
>>> 
>>> On Fri, 18 Jan 2019 at 15:08, Ulf Samuelsson <yocto@emagii.com> wrote:
>>> We could insert a check if the KNOWN_TASKS is valid in a verification test.
>>> When building core-image-minimal, the task order within core-image-minimal is analyzed, (dependencies on all other recipes is filtered away).
>>> Then you find out if there are tasks added, missing, and/or in the wrong order.
>> 
>> What about people who add new tasks?  Do they now need to go and
>> extend KNOWN_TASKS correctly too?
> 
> I might be missing something, but isn’t the right moment to detect loops when the task graph is fully formed? Then just run generic DFS on it, not a difficult or heavy algorithm.
> 
> Alex

The problem in our system was that the build crashed before that.

Best Regards,
Ulf Samuelsson




      reply	other threads:[~2019-01-18 16:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17 18:15 [PATCH] bb.build.addtask: add simple check for circular dependency Ulf Samuelsson
2019-01-17 21:05 ` Richard Purdie
2019-01-17 22:50   ` Ulf Samuelsson
2019-01-17 23:17     ` Burton, Ross
2019-01-18  4:30       ` Ulf Samuelsson
2019-01-18 11:29         ` Richard Purdie
2019-01-18 14:16           ` Ulf Samuelsson
2019-01-18 14:40             ` Richard Purdie
2019-01-18 15:07               ` Ulf Samuelsson
2019-01-18 15:34                 ` Burton, Ross
2019-01-18 15:56                   ` Alexander Kanavin
2019-01-18 16:07                     ` Ulf Samuelsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=657D18B2-09CD-4447-AEE5-D634323EE3DF@emagii.com \
    --to=yocto@emagii.com \
    --cc=alex.kanavin@gmail.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.