From: Sinan Kaya <okaya@codeaurora.org>
To: Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module
Date: Wed, 24 Jan 2018 11:10:33 -0500 [thread overview]
Message-ID: <657b80d6-a880-e504-7f85-6a2dc47e0f8a@codeaurora.org> (raw)
In-Reply-To: <bb50db91-f37a-46da-138d-826237ac69f7@redhat.com>
On 1/24/2018 11:09 AM, Hans de Goede wrote:
>>>> There must be a middle ground somewhere.
>>>
>>> One thing which comes to mind is to simply not allow building i2c as a module
>>> when ACPI is selected, something like this should work I think:
>>>
>>> config I2C
>>> tristate "I2C support"
>>> select RT_MUTEXES
>>> select IRQ_DOMAIN
>>> + # force building I2C in on ACPI systems, for opregion availability
>>> + depends on y || !ACPI
>>
>> This works for me.
>
> OK, so feel free to turn it into a proper patch and submit it
> upstream.
OK. Let me do some build tests.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-01-24 16:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 14:02 [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module Eric Auger
2018-01-08 16:22 ` Sinan Kaya
2018-01-24 5:56 ` Wolfram Sang
2018-01-24 6:27 ` Mika Westerberg
2018-01-24 13:29 ` Sinan Kaya
2018-01-24 14:24 ` Mika Westerberg
2018-01-24 14:44 ` Andy Shevchenko
2018-01-24 14:59 ` Hans de Goede
2018-01-24 15:12 ` Sinan Kaya
2018-01-24 15:23 ` Hans de Goede
2018-01-24 15:37 ` Sinan Kaya
2018-01-24 16:09 ` Hans de Goede
2018-01-24 16:10 ` Sinan Kaya [this message]
2018-01-24 16:56 ` Auger Eric
2018-01-24 14:46 ` Andy Shevchenko
2018-01-24 14:49 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657b80d6-a880-e504-7f85-6a2dc47e0f8a@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.