From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jeremy Linton <jeremy.linton@arm.com>, netdev@vger.kernel.org
Cc: steve.glendinning@shawell.net
Subject: Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL
Date: Wed, 15 Jun 2016 00:42:38 +0300 [thread overview]
Message-ID: <658086be-8ea6-c419-65f5-c627fb2d0654@cogentembedded.com> (raw)
In-Reply-To: <576079BC.8010802@arm.com>
On 06/15/2016 12:40 AM, Jeremy Linton wrote:
>>>>> If the interrupt configuration isn't set and we are using the
>>>>
>>>> It's never set, judging by the driver code.
>>>>
>>>>> internal phy, then we need to poll the phy to reliably detect
>>>>> phy state changes.
>>>>
>>>> What address your internal PHY is at? Mine is at 1, and things seem
>>>> to work reliably after probing:
>>>>
>>>> SMSC LAN8700 18000000.etherne:01: attached PHY driver [SMSC LAN8700]
>>>> (mii_bus:phy_addr=18000000.etherne:01, irq=-1)
>>>>
>>>> I'm using the device tree on my board.
>>>
>>> Ok, I'm back on the machine, this is what mine says without that patch.
>>>
>>> SMSC LAN911x Internal PHY 18000000.etherne:01: attached PHY driver [SMSC
>>> LAN911x Internal PHY] (mii_bus:phy_addr=18000000.etherne:01, irq=0)
>>
>> Hum, that's unexpected... things are probably more complex that I
>> thought. Do you have extra patches to this driver by changce?
>
> No, the initial kernel where the problem was discovered is
> 4.5.2-301.fc24.aarch64, but I built a mainline 4.6, and modprobed the driver
> with the same effect.
>
>
> Although, now that I'm looking closer at phy_irq, I'm curious how it works for
> anyone else...
Does anything change when you comment out that memcpy()? It shouldn't
probably...
MBR, Sergei
next prev parent reply other threads:[~2016-06-14 21:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 16:16 [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL Jeremy Linton
2016-06-14 18:30 ` Sergei Shtylyov
2016-06-14 19:27 ` Sergei Shtylyov
2016-06-14 19:49 ` Sergei Shtylyov
2016-06-14 20:12 ` Andrew Lunn
2016-06-14 20:21 ` Sergei Shtylyov
2016-06-14 20:13 ` Jeremy Linton
2016-06-14 18:42 ` Andrew Lunn
2016-06-14 20:48 ` Jeremy Linton
2016-06-14 20:44 ` Sergei Shtylyov
2016-06-14 20:59 ` Jeremy Linton
2016-06-14 21:24 ` Sergei Shtylyov
2016-06-14 22:26 ` Andrew Lunn
2016-06-15 15:50 ` Jeremy Linton
2016-06-14 21:02 ` Jeremy Linton
2016-06-14 21:12 ` Jeremy Linton
2016-06-14 21:26 ` Sergei Shtylyov
2016-06-14 21:29 ` Jeremy Linton
2016-06-14 21:34 ` Sergei Shtylyov
2016-06-14 21:40 ` Jeremy Linton
2016-06-14 21:42 ` Sergei Shtylyov [this message]
2016-06-14 21:53 ` Jeremy Linton
2016-06-14 21:56 ` Sergei Shtylyov
2016-06-15 15:56 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658086be-8ea6-c419-65f5-c627fb2d0654@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jeremy.linton@arm.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.