From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 15/28] drm: omapdrm: hdmi: Store PHY features in HDMI transmitter drivers Date: Tue, 9 May 2017 14:27:23 +0300 Message-ID: <6581f98f-932f-fc01-ab45-a10861ddb179@ti.com> References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-16-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1020123910==" Return-path: Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FA39899BE for ; Tue, 9 May 2017 11:27:55 +0000 (UTC) In-Reply-To: <20170508113303.27521-16-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1020123910== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ihEHg1aXCMqEq5KB2vbW7ow4RmjsnlHED" --ihEHg1aXCMqEq5KB2vbW7ow4RmjsnlHED Content-Type: multipart/mixed; boundary="CVwqslnE6w7llnSfSrXUJpiprNFQBvTNl"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: <6581f98f-932f-fc01-ab45-a10861ddb179@ti.com> Subject: Re: [PATCH v2 15/28] drm: omapdrm: hdmi: Store PHY features in HDMI transmitter drivers References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-16-laurent.pinchart@ideasonboard.com> In-Reply-To: <20170508113303.27521-16-laurent.pinchart@ideasonboard.com> --CVwqslnE6w7llnSfSrXUJpiprNFQBvTNl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/17 14:32, Laurent Pinchart wrote: > The HDMI PHY features are dependent on the HDMI transmitter model. The > PHY driver contains features for all supported transmitters, and select= s > the appropriate features based on the OMAP SoC version. >=20 > It makes more sense to store the features in the HDMI transmitter > drivers and pass them to the HDMI PHY initialization function, as the > HDMI transmitter drivers are transmitter-specific and don't need to > check the OMAP SoC version. I don't think this is correct. PHY and HDMI are separate components, you could swap the PHY. In theory, at least. While the PHY .c is not a separate driver, I still like that it contains information about the PHY hardware versions which it supports, like a real driver would. The same applies to the next patch, the PLL is not part of HDMI. In the third patch you pass 4 or 5 to the WP code as a version. So maybe rather create an HDMI_VERSION (or something) enum, which can be passed to phy, pll and wp? Tomi --CVwqslnE6w7llnSfSrXUJpiprNFQBvTNl-- --ihEHg1aXCMqEq5KB2vbW7ow4RmjsnlHED Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEaebAAoJEPo9qoy8lh71iiwP+wZiQLrKa+nL94rG2tAI1AI/ 7PbWbibIAYWd6pTWgHlVogyNAsHcZUNSWZeE/MEykDMnVMaXkgXduH7jGie//BDy 7wWj5aEuFrlyyhnJE2SaHrJF09K1rFZCJqp0VFL3lea9snwae2Na3qQTbkK9lwAb AVebIeUrjcdeol305DnevL68bGqvGay7F2ET3x9RvT0HE8bEJy90bhK6QPMdbua2 LWi3TZ4ivnZMnGEf4aBx1wjxsfJMbfX3VBrJxs1TYPaC3sQPLQ6tUWTm+mVItUI5 tzMnRok1/m9bMDCHp4QYfffRjRLaGUL0bC/cLrZ2YuvCv1Khn0z4dHSIYzKUd8Fv kG6dCn6iDHk04xTRwqygiYBqgEjWs85Jl6wQO7jHmT75Mm8dEJCK0G1AO9dd7Bk7 qzNQOj3NUbdbpXg+4Zqx2xA7/OVcGUMoFgo48Qbs/aKNb2IM8JH0lc+ptowVe/HJ 2HAP9AlDtwi0AGFtgxKpWUhCNO02mYj3qHwmIiYwJ1HbqFTVdG0M5J+Zb80nnBcQ V9e8Xnr+2FNhJqw02pi4oOgpgcFTQkAZ3cqQvppeqCwQvlxe6j9H2T3uJw9ei5cc MhFuYZMAvwte44pUYluR7aCJJARV5ZrAov42HoEM4jeeQwBKEsc5EUZ7Gp09QDFF cNCVTS4wV2ZBvbKk6LMO =Sujy -----END PGP SIGNATURE----- --ihEHg1aXCMqEq5KB2vbW7ow4RmjsnlHED-- --===============1020123910== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1020123910==--