From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A007C433EF for ; Thu, 25 Nov 2021 14:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355740AbhKYOfr (ORCPT ); Thu, 25 Nov 2021 09:35:47 -0500 Received: from gateway24.websitewelcome.com ([192.185.51.59]:38954 "EHLO gateway24.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349901AbhKYOdn (ORCPT ); Thu, 25 Nov 2021 09:33:43 -0500 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 24734E6AD for ; Thu, 25 Nov 2021 08:30:30 -0600 (CST) Received: from gator4132.hostgator.com ([192.185.4.144]) by cmsmtp with SMTP id qFlemvifczD3VqFlems9qi; Thu, 25 Nov 2021 08:30:30 -0600 X-Authority-Reason: nr=8 Received: from host-79-34-250-122.business.telecomitalia.it ([79.34.250.122]:43166 helo=[10.0.0.34]) by gator4132.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1mqFlc-0044qe-Pz; Thu, 25 Nov 2021 08:30:29 -0600 Message-ID: <65848fd0-0b37-dde6-fa5a-259c07b69f34@kernel.org> Date: Thu, 25 Nov 2021 15:30:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode Content-Language: en-US To: Steven Rostedt Cc: Tao Zhou , Ingo Molnar , Tom Zanussi , Masami Hiramatsu , Juri Lelli , Clark Williams , John Kacur , Peter Zijlstra , Thomas Gleixner , Sebastian Andrzej Siewior , linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <1d9826696a1e8c3584158c0dd570b8b22db708db.1635535309.git.bristot@kernel.org> <20211124171212.537b43c3@gandalf.local.home> <20211124171503.584c8dd2@gandalf.local.home> <20211125092018.17e36369@oasis.local.home> From: Daniel Bristot de Oliveira In-Reply-To: <20211125092018.17e36369@oasis.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4132.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - kernel.org X-BWhitelist: no X-Source-IP: 79.34.250.122 X-Source-L: No X-Exim-ID: 1mqFlc-0044qe-Pz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: host-79-34-250-122.business.telecomitalia.it ([10.0.0.34]) [79.34.250.122]:43166 X-Source-Auth: kernel@bristot.me X-Email-Count: 1 X-Source-Cap: YnJpc3RvdG1lO2JyaXN0b3RtZTtnYXRvcjQxMzIuaG9zdGdhdG9yLmNvbQ== X-Local-Domain: no Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/21 15:20, Steven Rostedt wrote: > On Thu, 25 Nov 2021 14:45:30 +0100 > Daniel Bristot de Oliveira wrote: > >>> Or do you think that 1d should be the default, and we have: >>> >>> tracefs_hist_alloc() -- 1d histogram >>> tracefs_hist_alloc_2d() -- 2d histogram >>> tracefs_hist_alloc_nd() -- Nd histogram? >>> >>> ?? >> >> IMHO, the function names in your second email sound more intuitive, i.e., >> tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd(). >> >>> We haven't tagged it yet, so we could change it again (and then your code >>> will work as is). >> >> two birds with a single stone :-) > > Just to confirm (confused by "second email" above), you prefer that we > update the API to: > > tracefs_hist_alloc() > tracefs_hist_alloc_2d() > tracefs_hist_alloc_nd() > > Right? Right! -- Daniel > Thanks, > > -- Steve >